From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
Leif Lindholm <leif@nuviainc.com>
Subject: Re: [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot
Date: Tue, 24 Mar 2020 22:55:17 +0100 [thread overview]
Message-ID: <CAKv+Gu9F7fj=TSxJpvMPm-zk_DkvAbtc6iAzuPu+ZaTg+bqXvQ@mail.gmail.com> (raw)
In-Reply-To: <20200324215342.666-1-samer@elhajmahmoud.com>
On Tue, 24 Mar 2020 at 22:53, Samer El-Haj-Mahmoud
<samer@elhajmahmoud.com> wrote:
>
> Enable HTTP Boot (with and without TLS) on RPi4
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Which NIC are you HTTP booting from?
> ---
> Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 2e98c3e16b91..f6b627af279c 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -25,12 +25,6 @@ [Defines]
> SKUID_IDENTIFIER = DEFAULT
> FLASH_DEFINITION = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
>
> - #
> - # Network definition
> - #
> - DEFINE NETWORK_TLS_ENABLE = FALSE
> - DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> -
> #
> # Defines for default states. These can be changed on the command line.
> # -D FLAG=VALUE
> @@ -139,6 +133,7 @@ [LibraryClasses.common]
> IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
> OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> + TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>
> #
> # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
> @@ -358,6 +353,8 @@ [PcdsFixedAtBuild.common]
> gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04
> !endif
>
> + gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> +
> [LibraryClasses.common]
> ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
> ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-03-24 21:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-24 21:53 [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot Samer El-Haj-Mahmoud
2020-03-24 21:55 ` Ard Biesheuvel [this message]
2020-03-24 22:02 ` [edk2-devel] " Samer El-Haj-Mahmoud
2020-03-25 9:20 ` Ard Biesheuvel
2020-03-25 12:48 ` Samer El-Haj-Mahmoud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9F7fj=TSxJpvMPm-zk_DkvAbtc6iAzuPu+ZaTg+bqXvQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox