From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67])
 by mx.groups.io with SMTP id smtpd.web11.1729.1585086930287613276
 for <devel@edk2.groups.io>;
 Tue, 24 Mar 2020 14:55:30 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=zzZhC/a0;
 spf=pass (domain: linaro.org, ip: 209.85.128.67, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wm1-f67.google.com with SMTP id z18so273680wmk.2
        for <devel@edk2.groups.io>; Tue, 24 Mar 2020 14:55:30 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=nnVUWCdHLbEbGCZyhZUlBlYozMeRbMdapHjU7fEPaPg=;
        b=zzZhC/a0j+kBcuARiWBFzB7Ula1VLQZnTu7gDMap+6pVoLLrNCescX8PPgDR/8Jinl
         TmveNw1vNFFmCENrhRXjoW68U9pkjoX3rAKmhbcbssLKnCb6wJdDal0UH5lDoQZ6eDmU
         7lOBz1kPMIokRKpmgk2OJW/Vctj6ImgZBdRhEgPAz/xeBURAOuyR0mFXvEAlqR0nhByN
         ydDm+sn0KZzg8G35GjqTM0SeJlklhH4rZx7fiZA8vCgsZ6/0VJUFkSq/bgi/oc4SwEu4
         UOzID1gXtQ70Zisi8ahu+Uag0Cxeq53lJLpVb2x7FHnXRIY5yOuWjPAe6YBv995AVxM9
         GgUA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=nnVUWCdHLbEbGCZyhZUlBlYozMeRbMdapHjU7fEPaPg=;
        b=XATzV9E1PUXoN7ukngCMm/VyK3J+rq347kCy8g9RcbIP26+sjwO1Dam5Jse9itIuhY
         t2d/hdgxp3vBFa8y/Jp3TlFo7qoR9Q1T0X5uxRjKFK/H2t3AIYcbwIVJmWc7bZwKjZmm
         VkJ87izGM9x1sIw2HaRhH/BSX/4691xNvPqq6aiAJInnQBa3y6CqPfhPgSW3zZVY50eN
         eFgS4kCtVcNRLMv+yHatz/V6H6pCCi74EdzQjI4eCnvnwD+9YtYOxxUlTXv/cNypCorK
         nsVPZDHE8q/gCY76ozj7aYx77ZpQmNlKXbpdqGRe/+qoBfxY3Pqd+YOsFRdApGo9r5SK
         XI1g==
X-Gm-Message-State: ANhLgQ3Hudl6dqL2ZxDQkAPaXqZ3Z0Rft72MOZbYEi4+BdhU9rzLxmy8
	Mg+o6eFVkvlHQaVT6HA4ZMptjxGzX1QSFUJDwGFwtw==
X-Google-Smtp-Source: ADFU+vuv5NX3SnAuwJ0SvJS0ePCsBr1AzBR0pstoigaPwDGbDCHO4P1bKY4GNLpOtcAn3K4BdJWSq6qrs1FBQpPofac=
X-Received: by 2002:a1c:ac8a:: with SMTP id v132mr132864wme.62.1585086928763;
 Tue, 24 Mar 2020 14:55:28 -0700 (PDT)
MIME-Version: 1.0
References: <20200324215342.666-1-samer@elhajmahmoud.com>
In-Reply-To: <20200324215342.666-1-samer@elhajmahmoud.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 24 Mar 2020 22:55:17 +0100
Message-ID: <CAKv+Gu9F7fj=TSxJpvMPm-zk_DkvAbtc6iAzuPu+ZaTg+bqXvQ@mail.gmail.com>
Subject: Re: [[edk2-platform][PATCH 1/1] Platform/RaspberryPi/RPi4: Enable HTTP Boot
To: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 24 Mar 2020 at 22:53, Samer El-Haj-Mahmoud
<samer@elhajmahmoud.com> wrote:
>
> Enable HTTP Boot (with and without TLS) on RPi4
>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Signed-off-by: Samer El-Haj-Mahmoud <samer@elhajmahmoud.com>

Which NIC are you HTTP booting from?

> ---
>  Platform/RaspberryPi/RPi4/RPi4.dsc | 9 +++------
>  1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index 2e98c3e16b91..f6b627af279c 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -25,12 +25,6 @@ [Defines]
>    SKUID_IDENTIFIER               = DEFAULT
>    FLASH_DEFINITION               = Platform/RaspberryPi/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf
>
> -  #
> -  # Network definition
> -  #
> -  DEFINE NETWORK_TLS_ENABLE       = FALSE
> -  DEFINE NETWORK_HTTP_BOOT_ENABLE = FALSE
> -
>    #
>    # Defines for default states.  These can be changed on the command line.
>    # -D FLAG=VALUE
> @@ -139,6 +133,7 @@ [LibraryClasses.common]
>    IntrinsicLib|CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf
>    BaseCryptLib|CryptoPkg/Library/BaseCryptLib/BaseCryptLib.inf
>    OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf
> +  TlsLib|CryptoPkg/Library/TlsLib/TlsLib.inf
>
>    #
>    # Uncomment (and comment out the next line) For RealView Debugger. The Standard IO window
> @@ -358,6 +353,8 @@ [PcdsFixedAtBuild.common]
>    gEfiSecurityPkgTokenSpaceGuid.PcdRemovableMediaImageVerificationPolicy|0x04
>  !endif
>
> +  gEfiNetworkPkgTokenSpaceGuid.PcdAllowHttpConnections|TRUE
> +
>  [LibraryClasses.common]
>    ArmLib|ArmPkg/Library/ArmLib/ArmBaseLib.inf
>    ArmMmuLib|ArmPkg/Library/ArmMmuLib/ArmMmuBaseLib.inf
> --
> 2.17.1
>