From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AD23421EB5283 for ; Thu, 31 Aug 2017 06:56:04 -0700 (PDT) Received: by mail-io0-x229.google.com with SMTP id n71so23430245iod.1 for ; Thu, 31 Aug 2017 06:58:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=SE5muO5aEZAkx+bTAIqjM4PE0opFPTYQCFdWYdmx3sE=; b=NeL7vqhdFhTPYN0+Oq4hWHw7v4cBW7wxaliQYFBxlOgy9+PX+759SpEzTNpeBzk3+M NAIDL3mLgligmBmMw7obBIRPzaSqj5fjtylpxTMxM6VSoGSj73CjitFTOlQP2HtkPRdT hXu+seRYDrvOzCi60GxLEyUJ3SN6uHmOU2FNM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=SE5muO5aEZAkx+bTAIqjM4PE0opFPTYQCFdWYdmx3sE=; b=M4u2ePD9DkTjKYyWdrNhPSs4+g8U/aMBbIVMelzatxyXRcErnL/1vnXnGb1mdrHG8Q 7hk/EfTg9Sg6mu4uz1/TLlba+/t7egicY8as3rUBKKdWUzqAdw9VStON/E0jJ9nsLLbR Wa8ZjfJvcUVZSCGW16Iq+BZbcqte6zJ4EIxPlUVK5dr55T0R9hRgsAwfAEKREiOXzQ3F TyNxK3P86YRJX6Xk3W50nb0Fa91EThsA3cTrThOJFK4zOFtklWokjDzQOxA8k1kRnPVU GXEQagtob5lqJRUlsd0uTip7EGdSFm566/AB/kwnRUUDc4cMPPSTd9PE54O8q9EqQm+9 Tzdw== X-Gm-Message-State: AHPjjUj4hvWafIqkcmHVv54ZkyK0uzRpGUf5NJi+D/HYWFLZN86mVKDQ Hp3F8Y3ikRCOv6lAEbBB1no8a/LnPpuV X-Google-Smtp-Source: ADKCNb6j6vNvf2RR4ObAsMuuYKOTisGVFch1B8DSu6J+UANYY3rjikfcxN3sjL2aM3enN3/lRFJ0fzsIrjNZVjhGkwU= X-Received: by 10.107.155.78 with SMTP id d75mr5344166ioe.224.1504187927463; Thu, 31 Aug 2017 06:58:47 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Thu, 31 Aug 2017 06:58:46 -0700 (PDT) In-Reply-To: References: <20170825122554.17819-1-ard.biesheuvel@linaro.org> <20170829154603.fvhfwp66asipxnoe@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 31 Aug 2017 14:58:46 +0100 Message-ID: To: Leif Lindholm Cc: Marcin Wojtas , edk2-devel-01 Subject: Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 13:56:05 -0000 Content-Type: text/plain; charset="UTF-8" On 31 August 2017 at 14:51, Leif Lindholm wrote: > On 30 August 2017 at 14:26, Ard Biesheuvel wrote: >> On 29 August 2017 at 18:01, Ard Biesheuvel wrote: >>> On 29 August 2017 at 16:53, Marcin Wojtas wrote: >>>> 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel : >>>>> On 29 August 2017 at 16:47, Marcin Wojtas wrote: >>>>>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm : >>>>>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote: >>>>>>>> Instead of hardcoding the non-cache coherent nature of this device >>>>>>>> by invoking UncachedMemoryAllocationLib directly for allocating >>>>>>>> shared buffers, switch to DmaLib, which encapsulates this at a >>>>>>>> more abstract level. This allows the driver to be shared with >>>>>>>> platforms that are cache coherent (by simply switching to another >>>>>>>> DmaLib implementation), and removes the hardcoded dependency on >>>>>>>> UncachedMemoryAllocationLib, which will be removed from upstream >>>>>>>> EDK2. >>>>>>>> >>>>>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>>>>> Signed-off-by: Ard Biesheuvel >>>>>>> >>>>>>> Ah, and there is the non-bogus fix :) >>>>>>> Reviewed-by: Leif Lindholm >>>>>> >>>>>> Please let me just run this on the HW before merge - I'll do it tomorrow. >>>>>> >>>>> >>>>> Sure. Note that you will need to sync EDK2 after I merged the DmaLib >>>>> changes (which I will do today) >>>> >>>> Ok, please let know once it's available and also it would be great if >>>> this patch could be shared via github repo. >>>> >>> >>> The prerequisite patches for DmaLib are in EDK2 now. >>> >>> https://git.linaro.org/people/ard.biesheuvel/edk2-platforms.git/log/?h=mvpp2-dmalib >> >> Note that I just updated this branch to use NonCoherentDmaLib rather >> than ArmDmaLib > > For clarity - my Reviewed-by: still applies. > Thank. Pushed as bff9700855e43e4948fb4f7249b9a4fb5451072e