public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH edk2-platforms] Platform/Hisilicon: fix D03/D05 capsule image names
@ 2018-02-09 13:16 Leif Lindholm
  2018-02-09 13:20 ` Ard Biesheuvel
  0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2018-02-09 13:16 UTC (permalink / raw)
  To: edk2-devel; +Cc: ard.biesheuvel

Due to copy-paste error, both d03 and d05 ended up with capsule sections
named Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7 in their .fdf files.
Change these to the actual platform names.

Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 Platform/Hisilicon/D03/D03.fdf | 2 +-
 Platform/Hisilicon/D05/D05.fdf | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf
index e6a4820256..09613fb8f6 100644
--- a/Platform/Hisilicon/D03/D03.fdf
+++ b/Platform/Hisilicon/D03/D03.fdf
@@ -400,7 +400,7 @@ [FmpPayload.FmpPayloadSystemFirmwarePkcs7]
 
   FV = SystemFirmwareUpdateCargo
 
-[Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7]
+[Capsule.D03FirmwareUpdateCapsuleFmpPkcs7]
 CAPSULE_GUID                = 6dcbd5ed-e82d-4c44-bda1-7194199ad92a # gEfiFmpCapsuleGuid
 CAPSULE_HEADER_SIZE         = 0x20
 CAPSULE_HEADER_INIT_VERSION = 0x1
diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf
index 22609bb588..17a43d8edb 100644
--- a/Platform/Hisilicon/D05/D05.fdf
+++ b/Platform/Hisilicon/D05/D05.fdf
@@ -425,7 +425,7 @@ [FmpPayload.FmpPayloadSystemFirmwarePkcs7]
 
   FV = SystemFirmwareUpdateCargo
 
-[Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7]
+[Capsule.D05FirmwareUpdateCapsuleFmpPkcs7]
 CAPSULE_GUID                = 6dcbd5ed-e82d-4c44-bda1-7194199ad92a # gEfiFmpCapsuleGuid
 CAPSULE_HEADER_SIZE         = 0x20
 CAPSULE_HEADER_INIT_VERSION = 0x1
-- 
2.11.0



^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH edk2-platforms] Platform/Hisilicon: fix D03/D05 capsule image names
  2018-02-09 13:16 [PATCH edk2-platforms] Platform/Hisilicon: fix D03/D05 capsule image names Leif Lindholm
@ 2018-02-09 13:20 ` Ard Biesheuvel
  2018-02-09 13:31   ` Leif Lindholm
  0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2018-02-09 13:20 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: edk2-devel@lists.01.org

On 9 February 2018 at 13:16, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> Due to copy-paste error, both d03 and d05 ended up with capsule sections
> named Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7 in their .fdf files.
> Change these to the actual platform names.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  Platform/Hisilicon/D03/D03.fdf | 2 +-
>  Platform/Hisilicon/D05/D05.fdf | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf
> index e6a4820256..09613fb8f6 100644
> --- a/Platform/Hisilicon/D03/D03.fdf
> +++ b/Platform/Hisilicon/D03/D03.fdf
> @@ -400,7 +400,7 @@ [FmpPayload.FmpPayloadSystemFirmwarePkcs7]
>
>    FV = SystemFirmwareUpdateCargo
>
> -[Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7]
> +[Capsule.D03FirmwareUpdateCapsuleFmpPkcs7]
>  CAPSULE_GUID                = 6dcbd5ed-e82d-4c44-bda1-7194199ad92a # gEfiFmpCapsuleGuid
>  CAPSULE_HEADER_SIZE         = 0x20
>  CAPSULE_HEADER_INIT_VERSION = 0x1
> diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf
> index 22609bb588..17a43d8edb 100644
> --- a/Platform/Hisilicon/D05/D05.fdf
> +++ b/Platform/Hisilicon/D05/D05.fdf
> @@ -425,7 +425,7 @@ [FmpPayload.FmpPayloadSystemFirmwarePkcs7]
>
>    FV = SystemFirmwareUpdateCargo
>
> -[Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7]
> +[Capsule.D05FirmwareUpdateCapsuleFmpPkcs7]
>  CAPSULE_GUID                = 6dcbd5ed-e82d-4c44-bda1-7194199ad92a # gEfiFmpCapsuleGuid
>  CAPSULE_HEADER_SIZE         = 0x20
>  CAPSULE_HEADER_INIT_VERSION = 0x1
> --
> 2.11.0
>


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH edk2-platforms] Platform/Hisilicon: fix D03/D05 capsule image names
  2018-02-09 13:20 ` Ard Biesheuvel
@ 2018-02-09 13:31   ` Leif Lindholm
  0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2018-02-09 13:31 UTC (permalink / raw)
  To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org

On Fri, Feb 09, 2018 at 01:20:16PM +0000, Ard Biesheuvel wrote:
> On 9 February 2018 at 13:16, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > Due to copy-paste error, both d03 and d05 ended up with capsule sections
> > named Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7 in their .fdf files.
> > Change these to the actual platform names.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks - pushed as a235eabe39.

> > ---
> >  Platform/Hisilicon/D03/D03.fdf | 2 +-
> >  Platform/Hisilicon/D05/D05.fdf | 2 +-
> >  2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/Platform/Hisilicon/D03/D03.fdf b/Platform/Hisilicon/D03/D03.fdf
> > index e6a4820256..09613fb8f6 100644
> > --- a/Platform/Hisilicon/D03/D03.fdf
> > +++ b/Platform/Hisilicon/D03/D03.fdf
> > @@ -400,7 +400,7 @@ [FmpPayload.FmpPayloadSystemFirmwarePkcs7]
> >
> >    FV = SystemFirmwareUpdateCargo
> >
> > -[Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7]
> > +[Capsule.D03FirmwareUpdateCapsuleFmpPkcs7]
> >  CAPSULE_GUID                = 6dcbd5ed-e82d-4c44-bda1-7194199ad92a # gEfiFmpCapsuleGuid
> >  CAPSULE_HEADER_SIZE         = 0x20
> >  CAPSULE_HEADER_INIT_VERSION = 0x1
> > diff --git a/Platform/Hisilicon/D05/D05.fdf b/Platform/Hisilicon/D05/D05.fdf
> > index 22609bb588..17a43d8edb 100644
> > --- a/Platform/Hisilicon/D05/D05.fdf
> > +++ b/Platform/Hisilicon/D05/D05.fdf
> > @@ -425,7 +425,7 @@ [FmpPayload.FmpPayloadSystemFirmwarePkcs7]
> >
> >    FV = SystemFirmwareUpdateCargo
> >
> > -[Capsule.StyxFirmwareUpdateCapsuleFmpPkcs7]
> > +[Capsule.D05FirmwareUpdateCapsuleFmpPkcs7]
> >  CAPSULE_GUID                = 6dcbd5ed-e82d-4c44-bda1-7194199ad92a # gEfiFmpCapsuleGuid
> >  CAPSULE_HEADER_SIZE         = 0x20
> >  CAPSULE_HEADER_INIT_VERSION = 0x1
> > --
> > 2.11.0
> >


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2018-02-09 13:25 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-09 13:16 [PATCH edk2-platforms] Platform/Hisilicon: fix D03/D05 capsule image names Leif Lindholm
2018-02-09 13:20 ` Ard Biesheuvel
2018-02-09 13:31   ` Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox