From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x230.google.com (mail-io0-x230.google.com [IPv6:2607:f8b0:4001:c06::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 087BA8036F for ; Wed, 22 Mar 2017 08:20:00 -0700 (PDT) Received: by mail-io0-x230.google.com with SMTP id z13so67340297iof.2 for ; Wed, 22 Mar 2017 08:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=i+/pCFlvIeLfUuJRKxCEhs8oVcbpVA+owdl2w2k5fZ0=; b=OWStcMoZ+6IFvA5O5VgUxAE4/zQgugXuaAzEYPhhSVSixuBlED+UqdjGBd8L/j3x2z wmFn5EapTLMZrqL9hTAuzopc0QMU4zIPgjNMseiK+8ZSF+dxdqT5mYOhlGs6YJfYydHv FD0Xr42IlnZ76SXQNKKXzDwZXcCXgELDJweHI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=i+/pCFlvIeLfUuJRKxCEhs8oVcbpVA+owdl2w2k5fZ0=; b=k9HKXITxzZ04dJ1cSP76hlWnUd1/2ozUHn9omhZwHxMM0fRrYpKGTf2NFDgZLKViKQ nY78ZNj6atlHj5F3ZSFTUp8IeT32UjwNgl1Hvv1rIWJujIRDY+zYPsB+/GodPdbiMl6V w0edeWZYexjnL1Q7cPWcAXuAsUJdNnIRxbKW5k5DCrjT1F27EFgX4oFGVDvwQJEfnRxA Da31HvykDIdwQCxwYfs8mpdSD7XSbjRrfktebSSu9rl33qPTc3DrZ4V5LqCl3rmgsLWU ROAovFupZxJkb3RmmUx+Xp5hJ62lZAlozr8RVZ1cDczCLr9nvgjNfkzoLbOqprVDAoqv 5mTQ== X-Gm-Message-State: AFeK/H0PmtFKH9ayVSvNaA0Mxo1afCQPNKyeItYzHcaBHkd9RXIAYXRd+yrkDlLIhiyntGCbhZpru7rOVeIAQhtH X-Received: by 10.107.141.134 with SMTP id p128mr28527396iod.83.1490195999394; Wed, 22 Mar 2017 08:19:59 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Wed, 22 Mar 2017 08:19:58 -0700 (PDT) In-Reply-To: References: <1490191448-22398-1-git-send-email-ard.biesheuvel@linaro.org> <1490191448-22398-2-git-send-email-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Wed, 22 Mar 2017 15:19:58 +0000 Message-ID: To: "Carsey, Jaben" Cc: "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "lersek@redhat.com" , "Ni, Ruiyu" , "Kinney, Michael D" , "Steele, Kelly" Subject: Re: [PATCH 1/4] ShellPkg: add GUID declaration for FILE_GUID of UEFI Shell app to package X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 15:20:00 -0000 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 22 March 2017 at 15:13, Carsey, Jaben wrote: > Ard, > > I am good with this change. > > What do you think about a comment to the INF file so that if someone make= s a change to the GUI there, they are informed that they need to change thi= s location? I worry as usually updating an INF GUID is permitted without a= ny need to change another file... > Something like this perhaps? --- a/ShellPkg/Application/Shell/Shell.inf +++ b/ShellPkg/Application/Shell/Shell.inf @@ -17,7 +17,7 @@ [Defines] INF_VERSION =3D 0x00010006 BASE_NAME =3D Shell - FILE_GUID =3D 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 + FILE_GUID =3D 7C04A583-9E3E-4f1c-AD65-E05268D0B4D1 # gUefiShellFile= Guid MODULE_TYPE =3D UEFI_APPLICATION VERSION_STRING =3D 1.0 ENTRY_POINT =3D UefiMain (Note that the same FILE_GUID occurs in ShellBinPkg as well, but people are unlikely that randomly change that one without regard to the source build)