From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received-SPF: Pass (sender SPF authorized) identity=mailfrom;
 client-ip=2607:f8b0:4001:c0b::232; helo=mail-it0-x232.google.com;
 envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org 
Received: from mail-it0-x232.google.com (mail-it0-x232.google.com
 [IPv6:2607:f8b0:4001:c0b::232])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id B72DF21B0285D
 for <edk2-devel@lists.01.org>; Fri,  8 Dec 2017 00:35:30 -0800 (PST)
Received: by mail-it0-x232.google.com with SMTP id f190so3228312ita.5
 for <edk2-devel@lists.01.org>; Fri, 08 Dec 2017 00:40:04 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=2ORXGutc/gu0Uv66up/rsT1zdwfIFQpT3aBKdLAWHE0=;
 b=dvEfLDUw62KzG8OulBbGJ2y4YfSu2nO2LnAZOP+A4l0FxEzOEdWT5u7//nWQQofP5T
 uCs0UiPM88iDv+GozMoRCFxLntIIDSfPhV4hyABEShLh+TJIVGG3gT9TD6CpYWzwu0Vi
 vZefb9UeniFTcf049BGbqN3E9Z7NTUNGtTJjQ=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=2ORXGutc/gu0Uv66up/rsT1zdwfIFQpT3aBKdLAWHE0=;
 b=jnVI7Ja6bPMeUDa+LY6zvuZ5kANropDr5N1jtT6TpKeNV75rY7DYu90HAdJ8U7VJm0
 L69RiuLQf6wzxMoLSCgwKER2vVeiuKQsziN7jM7n263M9DjwP79LwA3IgSnN0YDJEQPL
 rfDnN219XYQQmRSq51pYU0Hq4aeo+2aegSbzinpYDig610Q9r8PRcFnsFYZJIR1mBlFo
 hUAaTWK/Ebu1OE9hVXjWtInG4YWZRM5zW0qFBiT+15qdsEKZLY34eeRVSHodMnyMScQt
 20ccG9HPJq/lnp6k4KFWJrJfd6z6diitUIBsFrVRSNsV0SQZeLXMtytivycWhUxYwa1/
 xZRg==
X-Gm-Message-State: AKGB3mKoG+qikN3+y9OWypnHZsCSWSrYpmMwkwcfHSw//MvA7PpN5uFC
 iC1AACjX9kVencoxj/g3vHqsSEstPwXorT3XZR2fEg==
X-Google-Smtp-Source: AGs4zMZnKppXbpvbZMMepkvfnBfyQwG+kF2o/FrW5Lysh2dC687u5SeiFJLuvlleGWBWZxyXE6z2BiExZIIo+wQk864=
X-Received: by 10.107.180.18 with SMTP id d18mr1739121iof.52.1512722403406;
 Fri, 08 Dec 2017 00:40:03 -0800 (PST)
MIME-Version: 1.0
Received: by 10.107.104.16 with HTTP; Fri, 8 Dec 2017 00:40:02 -0800 (PST)
In-Reply-To: <CAPv3WKegcw-yuu0wj7vBQOwMia7PyHhX1gfVkr__b7Nf22L-JQ@mail.gmail.com>
References: <1512674434-32326-1-git-send-email-mw@semihalf.com>
 <1512674434-32326-6-git-send-email-mw@semihalf.com>
 <CAKv+Gu_LD8ewHrAoovg-S3jW-nJhv8=va7x0zG5eNHmd=WcMLA@mail.gmail.com>
 <CAPv3WKegcw-yuu0wj7vBQOwMia7PyHhX1gfVkr__b7Nf22L-JQ@mail.gmail.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Fri, 8 Dec 2017 08:40:02 +0000
Message-ID: <CAKv+Gu9FygHZ_Bg828AHvUo1uarZMEhdYBrQ+FCga7Gn6ubtzA@mail.gmail.com>
To: Marcin Wojtas <mw@semihalf.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Leif Lindholm <leif.lindholm@linaro.org>, 
 Nadav Haklai <nadavh@marvell.com>, Neta Zur Hershkovits <neta@marvell.com>, 
 Kostya Porotchkin <kostap@marvell.com>, Hua Jing <jinghua@marvell.com>, 
 =?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>, 
 Konrad Adamczyk <ka@semihalf.com>
Subject: Re: [platforms: PATCH v2 5/5] Marvell/Drivers: Drop 'PciEmulation' naming
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Fri, 08 Dec 2017 08:35:30 -0000
Content-Type: text/plain; charset="UTF-8"

On 7 December 2017 at 23:08, Marcin Wojtas <mw@semihalf.com> wrote:
> Hi Ard,
>
> 2017-12-07 20:49 GMT+01:00 Ard Biesheuvel <ard.biesheuvel@linaro.org>:
>> Hi Marcin,
>>
>> On 7 December 2017 at 19:20, Marcin Wojtas <mw@semihalf.com> wrote:
>>> 'PciEmulation' is not a proper naming for a driver, which
>>> uses NonDiscoverableDeviceRegistrationLib for handling
>>> the devices attached via internal bus of the SoC.
>>> Rename it to MvNonDiscoverableDxe and move under
>>> Silicon/Marvell/Drivers directory.
>>>
>>
>> Thank you!
>>
>>> Contributed-under: TianoCore Contribution Agreement 1.1
>>> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
>>> ---
>>>  Platform/Marvell/Armada70x0Db/Armada70x0Db.fdf                                                             |  4 +--
>>>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc                                                              |  4 +--
>>>  Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c}     | 26 ++++++++++----------
>>>  Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} |  8 +++---
>>>  4 files changed, 21 insertions(+), 21 deletions(-)
>>>  rename Silicon/Marvell/{PciEmulation/PciEmulation.c => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.c} (84%)
>>>  rename Silicon/Marvell/{PciEmulation/PciEmulation.inf => Drivers/NonDiscoverableDevices/MvNonDiscoverableDxe.inf} (91%)
>>>
>>
>> Could we please have
>>
>> Drivers/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf
>>
>> instead?
>>
>
> My intention was to keep a generic naming at the first level inside
> the Silicon/Drivers/Marvell:
> I2c  Net SdMmc  Spi
>
> I can change it in a way you want, but to my taste
> MvNonDiscoverableDxe doesn't fully fit the company above. Do you see
> any possible compromise? :)
>

Well, if you want 'generic' at the level below
Silicon/Drivers/Marvell, you will still need
MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf below that.

So

Drivers/NonDiscoverable/MvNonDiscoverableDxe/MvNonDiscoverableDxe.inf

perhaps?