From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::233; helo=mail-it0-x233.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x233.google.com (mail-it0-x233.google.com [IPv6:2607:f8b0:4001:c0b::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B3EA320945BB5 for ; Tue, 10 Oct 2017 13:32:42 -0700 (PDT) Received: by mail-it0-x233.google.com with SMTP id l196so219890itl.4 for ; Tue, 10 Oct 2017 13:36:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jpYNrSKruE5dJIvmg9opBnzuYAF7+0/zNDp0VNMnPic=; b=Ygb8up87Dy3hej7w3oFoinL+U9AcJ45xfj+9UGEk+kNd1Jr/FF+33ml/uaH2V4zNzs 873sUOkOjxCta36rYNDMiyIU5Rm+6/VNuZbTC+eX1GiY0hRpzZt0qu7aprXQPSusYT6G r0Dbsu4YfocwLX5YFj+plrhWOfYgh6zv1/ftY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jpYNrSKruE5dJIvmg9opBnzuYAF7+0/zNDp0VNMnPic=; b=l4gIheUxx1F/JqlqohUfm64wmG3hMIK962ip2+niruBfSUd0v4gC2jlb80vaYgeSu2 dwjkXjMZIYuTRhwpUzVM1cPo5as23mAIxbwRt06gsZMQzlR/kdQVn4vmGzLUc2z+dBjX RAVWeCykilNttLJ8klekLDQ7tKsJXXiJAeJiIUrGRTPZKA2UmiSqMYt+V3O0NiifpXp8 RQChTgc18IEkWtKuyP1DE40WV7Rk1h91mmgBMSLbx4hq1/7QZzMl3Y9ne0J672/06Dn7 Q/De0bYCUGJ8N43OagUaX0GgYmWG/GLGrUh5qKTTg3y74QDZ8KTP9RsW3fTa4EmA7rvZ Hgyw== X-Gm-Message-State: AMCzsaUpsRaFEJOYM89dqfstH3P7KPnxKlyip0+AgZcf1uT4XWMa41K3 wCKmXCOcTYx8vVxw+p7HnOl8Ffky2tBIWM31zIAJPA== X-Google-Smtp-Source: AOwi7QDXIQEieDx2W05tlnNyQyNd5JlFJzY9CnEB51sOM/YIBR7WwkUcXkYvfrkWMfWm8IPKOicrqepF357lAdsT+PA= X-Received: by 10.36.50.150 with SMTP id j144mr19910606ita.52.1507667770383; Tue, 10 Oct 2017 13:36:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Tue, 10 Oct 2017 13:36:09 -0700 (PDT) In-Reply-To: <20171010152649.oau3kjesmjtogb4w@bivouac.eciton.net> References: <1507568462-28775-1-git-send-email-mw@semihalf.com> <1507568462-28775-2-git-send-email-mw@semihalf.com> <20171010143715.w4glyje3pw24kvsm@bivouac.eciton.net> <20171010150327.43zpe5x6gjo4umrx@bivouac.eciton.net> <20171010152649.oau3kjesmjtogb4w@bivouac.eciton.net> From: Ard Biesheuvel Date: Tue, 10 Oct 2017 21:36:09 +0100 Message-ID: To: Leif Lindholm Cc: Marcin Wojtas , edk2-devel-01 , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , Hua Jing , semihalf-dabros-jan Subject: Re: [platforms: PATCH 01/13] Marvell/Armada: Introduce platform initialization driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Oct 2017 20:32:42 -0000 Content-Type: text/plain; charset="UTF-8" On 10 October 2017 at 16:26, Leif Lindholm wrote: > On Tue, Oct 10, 2017 at 05:06:42PM +0200, Marcin Wojtas wrote: >> 2017-10-10 17:03 GMT+02:00 Leif Lindholm : >> > On Tue, Oct 10, 2017 at 04:45:10PM +0200, Marcin Wojtas wrote: >> >> Hi Leif, >> >> >> >> 2017-10-10 16:37 GMT+02:00 Leif Lindholm : >> >> > On Mon, Oct 09, 2017 at 07:00:50PM +0200, Marcin Wojtas wrote: >> >> >> In order to enable modification of dynamic PCD's for the libraries >> >> >> and DXE drivers, this patch introduces new driver. It is >> >> >> executed prior to other drivers. Mpp, ComPhy and Utmi libraries >> >> >> initialization were moved from PrePi stage to DXE. >> >> >> >> >> >> To force the correct driver dispatch sequence, introduce a protocol GUID >> >> >> and install the protocol as a NULL protocol when PlatInitDxe executes. >> >> >> >> >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> >> >> Signed-off-by: Marcin Wojtas >> >> >> Signed-off-by: Ard Biesheuvel >> >> > >> >> > What does Ard's Signed-off-by signify here? >> >> > (I know the authorship on some of these is a bit blurred, since you've >> >> > been working together, but I'd like to be clear.) >> >> >> >> These were the lines, introducing/installing protocol GUID stuff. It >> >> was in a small separate patch, but I squashed it into bigger one. >> > >> > Personally, I would in this instance do: >> > >> > Ard >> > >> > >> > It's verbose, but reasonably clear. >> > >> >> How about: >> >> In order to enable modification of dynamic PCD's for the libraries >> and DXE drivers, this patch introduces new driver. It is >> executed prior to other drivers. Mpp, ComPhy and Utmi libraries >> initialization were moved from PrePi stage to DXE. >> >> Signed-off-by: Marcin Wojtas >> >> To force the correct driver dispatch sequence, introduce a protocol GUID >> and install the protocol as a NULL protocol when PlatInitDxe executes. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> Signed-off-by: Marcin Wojtas >> >> ? >> >> Was that, what you meant? > > I think Contibuted-under: still needs to come first. > > I don't think we have an explicit policy for how to deal with > multi-contributor patches. The ones we do see tend to just keep a > single commit message and list the contributors. > > In Linux. it would be something like > Signed-off-by: Marcin Wojtas > [Introduce protocol GUID to force correct driver dispatch order] > Signed-off-by: Ard Biesheuvel > Signed-off-by: Marcin Wojtas > > I would be quite happy to use the same format here. > Well, Tianocore still conflates authorship with a statement regarding the origin of the contribution. I wonder how this is supposed to work when Linaro engineers such as myself contribute code that was authored by engineers working in member companies, e.g., Socionext. The license and the contract that company has with Linaro give me the right to contribute that code, but that does not make me the author, and I cannot add a Signed-off-by that wasn't present when we received the code (even if I knew the name of the author)