From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AF8782035D329 for ; Tue, 9 Jan 2018 00:22:42 -0800 (PST) Received: by mail-io0-x244.google.com with SMTP id 87so17642830ior.5 for ; Tue, 09 Jan 2018 00:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yImXE7r9BGYvXb+zA6u6dZ/rRLfEbVbxtB8gF2SVzq4=; b=O/y2od1NNq9fU/fI0gGBC5G44B1PJYS1RSTiUt9maZK86j6ZTIgQKNfqJbq+RNywTa osfJNFMeEkGMBHOe2psENSwbtWWXzCaGh2brgb+1Fud8fTzVxUOWh0YibqhFJ3jf+R93 LmWCSWq4smTwyJ9beRs8NKq7L7ZBuCLA/ptho= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yImXE7r9BGYvXb+zA6u6dZ/rRLfEbVbxtB8gF2SVzq4=; b=pJ6VY3NPFvFGS/9By1gBs1CSxEt3AhRa5A3f69vPNtihjfjfmKxKNZnTNPEG/Byzf3 zGhUviSy8tCXv0g1DleaP0wiVM+5w9kCnsl43KIPU3o9Z7A/EU/EVK6VukAPyxZ+0QLw GTM7SRu/9qj3f211xBhi+yyQR7tz/Po4IWLBmq6DvruFGOLyDIHnH+K4ONwzVUOoRYxV N9kFnkvEx+6xttsCZvEWyJFPHrCfPEQ6yPUYDe2nf86SzKzg5C0u16DEkHxSXcs+NFUn oszGz49vHkSY0+FgBHqzfXEXfxTN3kOXTEXumOL3WcQHQvbhXFu55RygwTb+oIQC/dZu 2pQQ== X-Gm-Message-State: AKwxytePvtqRSU63Yl0TbVY3G+JlJOfaLpvOdN2l0/vjj1ezN1cDvLsP ndVJUxRClstS9yjLCwjxAuRflesymgXvJd+m8HRe6A== X-Google-Smtp-Source: ACJfBou9rX81WULXcU7im6is4xRArtaQoBIgPGS5e9gSnYwM9uXIRYWRH+8gFRR9KG7VuEUXIuK2aQOYwB5D45wz6yk= X-Received: by 10.107.35.85 with SMTP id j82mr13722657ioj.253.1515486472656; Tue, 09 Jan 2018 00:27:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.37.197 with HTTP; Tue, 9 Jan 2018 00:27:52 -0800 (PST) In-Reply-To: References: <1513945005-30002-1-git-send-email-meenakshi.aggarwal@nxp.com> <1515426912-13557-1-git-send-email-meenakshi.aggarwal@nxp.com> <1515426912-13557-3-git-send-email-meenakshi.aggarwal@nxp.com> From: Ard Biesheuvel Date: Tue, 9 Jan 2018 08:27:52 +0000 Message-ID: To: Meenakshi Aggarwal Cc: Leif Lindholm , "Kinney, Michael D" , "edk2-devel@lists.01.org" , Udit Kumar , Varun Sethi Subject: Re: [PATCH edk2-platforms v2 2/2] LS1046 : Enable support of SATA controller X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 08:22:43 -0000 Content-Type: text/plain; charset="UTF-8" On 9 January 2018 at 04:37, Meenakshi Aggarwal wrote: > > >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Monday, January 08, 2018 8:42 PM >> To: Meenakshi Aggarwal >> Cc: Leif Lindholm ; Kinney, Michael D >> ; edk2-devel@lists.01.org; Udit Kumar >> ; Varun Sethi >> Subject: Re: [PATCH edk2-platforms v2 2/2] LS1046 : Enable support of SATA >> controller >> >> On 8 January 2018 at 15:55, Meenakshi Aggarwal >> wrote: >> > Enable support of SATA drives on ls1046 board. >> > >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Meenakshi Aggarwal >> > --- >> > Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc | 8 ++++++++ >> > Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.fdf | 12 >> ++++++++++++ >> > .../NXP/LS1046aRdbPkg/Library/PlatformLib/ArmPlatformLib.inf | 2 ++ >> > .../NXP/LS1046aRdbPkg/Library/PlatformLib/NxpQoriqLsMem.c | 8 >> ++++++++ >> > Silicon/NXP/LS1046A/LS1046A.dsc | 5 +++++ >> > 5 files changed, 35 insertions(+) >> > >> > diff --git a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc >> b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc >> > index 9d2482b..93fc848 100644 >> > --- a/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc >> > +++ b/Platform/NXP/LS1046aRdbPkg/LS1046aRdbPkg.dsc >> > @@ -63,6 +63,13 @@ >> > # >> > gNxpQoriqLsTokenSpaceGuid.PcdI2cSlaveAddress|0x51 >> > >> > + # >> > + # Errata Pcds >> > + # >> > + gNxpQoriqLsTokenSpaceGuid.PcdSataErratumA009185|TRUE >> > + gNxpQoriqLsTokenSpaceGuid.PcdSataErratumA010554|TRUE >> > + gNxpQoriqLsTokenSpaceGuid.PcdSataErratumA010635|TRUE >> > + >> > >> ########################################################## >> ###################### >> > # >> > # Components Section - list of all EDK II Modules needed by this Platform >> > @@ -71,3 +78,4 @@ >> > [Components.common] >> > edk2-platforms/Platform/NXP/Drivers/WatchDog/WatchDogDxe.inf >> > edk2-platforms/Platform/NXP/Drivers/I2cDxe/I2cDxe.inf >> > + edk2-platforms/Platform/NXP/Drivers/SataInitDxe/SataInitDxe.inf >> >> This looks wrong to me. Your .dsc/.fdf files should not contain these >> edk2-platforms prefixes. Instead, you should set your PACKAGES_PATH >> correctly to include your edk2-platforms directory. >> > OK, We will remove this from .dsc/.fdf files. > My concern is as there are already a lot of patches are under review so it will be > Better if review gets completed once, then we will share the updated in next revision of patch > As this needs to be change in multiple patches. > > There is one more comment from you on keeping shred Drivers and Library in Silicon/NXP directory. > In this case also, this will need a rework in all patches sent till date. > > So once review comments been recieved we will made the changes in next revision of patch. > I have a better idea. Let's disregard all current submissions in flight, and repost the next one as a single series so that I don't have to keep track of all the different ones.