From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x233.google.com (mail-io0-x233.google.com [IPv6:2607:f8b0:4001:c06::233]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AAC8D21E62BB5 for ; Fri, 1 Sep 2017 02:28:09 -0700 (PDT) Received: by mail-io0-x233.google.com with SMTP id 81so12944287ioj.5 for ; Fri, 01 Sep 2017 02:30:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=N+JQAuE0yJQCK6APu3XFCppGtlEcy3Sk+742PQZkh0I=; b=MYPhbCfP0qefQK9nCgVgxDJKPR2ae9tsEmxiQqv8cwjTXIpcO6GsIe0HsegDxMQEME LaBusAUvZaS69rdBIrVetjOSUZ83gzNu5MG9iCC3Fm5XVt1bicBHRl5j/llRdcRE1vjL 1udtzrtxF04hxGk48KOFboxv4OEVALjW0eIkE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=N+JQAuE0yJQCK6APu3XFCppGtlEcy3Sk+742PQZkh0I=; b=rw+mbRz7vYaM1LtD1jq+H9eXQinVpafajw25iSkOGF7aXhEJaY2zA4KDQ4frzwnmXg 9XC4bCmMJQbb01ANYJyncrfDSaZGrh2MSrxCaXNIkqBt3rkV1QBq0Nh/MdZ8PdVlBNsF fdsn/v8mUZg1fqvJqYudvnzbfvrAY9TGN4djniQB/VDxMudvuDYR1VkqZ+wAJ72rF+Oh /1Z+yXUwh5PkaX7KHFAJxBAqRXHsrI3p/K8hqPwCQpBjr96jGYEo12aobcCEzhwO1EVp oBGUs3OL/JbRp9/uLDSo7fml5WD/Q24nd1NzhZSSxUEniC9V+pBc3QqeUmUl9guTcfGc BZZA== X-Gm-Message-State: AHPjjUj8dkozC1eJu5PMVx1RHr8yfN3KCdV0otMK5LiHrVbDJ+nXKp/R zNvxEXT6/5lahoOhYJdwK7dCCw8xxOXO X-Google-Smtp-Source: ADKCNb5mMX5getX4jx+ejFhO2juQZKqjalJytAe5Kf0Fpl8vwC74mN/AAjk/yWvnBvW4FnpnooIq7g9hYvP6gJqQSTo= X-Received: by 10.107.162.142 with SMTP id l136mr942995ioe.192.1504258253420; Fri, 01 Sep 2017 02:30:53 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Fri, 1 Sep 2017 02:30:52 -0700 (PDT) In-Reply-To: <1504233451-6455-5-git-send-email-mw@semihalf.com> References: <1504233451-6455-1-git-send-email-mw@semihalf.com> <1504233451-6455-5-git-send-email-mw@semihalf.com> From: Ard Biesheuvel Date: Fri, 1 Sep 2017 10:30:52 +0100 Message-ID: To: Marcin Wojtas Cc: "edk2-devel@lists.01.org" , Leif Lindholm , Nadav Haklai , Neta Zur Hershkovits , Kostya Porotchkin , jinghua@marvell.com, Alexander Graf , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Joe Zhou Subject: Re: [platforms: PATCH 4/7] Drivers/Net/Pp2Dxe: Increase amount of ingress resources X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Sep 2017 09:28:10 -0000 Content-Type: text/plain; charset="UTF-8" On 1 September 2017 at 03:37, Marcin Wojtas wrote: > From: Joe Zhou > > Increase Rx ring and BM pool size for each port, which is > helpful when dealing with more intense incoming network > traffic. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Joe Zhou Signed-off-by: Marcin Wojtas If you need to change these simultaneously, shouldn't one be defined in terms of the other? > --- > Platform/Marvell/Drivers/Net/Pp2Dxe/Mvpp2LibHw.h | 2 +- > Platform/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/Platform/Marvell/Drivers/Net/Pp2Dxe/Mvpp2LibHw.h b/Platform/Marvell/Drivers/Net/Pp2Dxe/Mvpp2LibHw.h > index 52509b0..0ebf936 100644 > --- a/Platform/Marvell/Drivers/Net/Pp2Dxe/Mvpp2LibHw.h > +++ b/Platform/Marvell/Drivers/Net/Pp2Dxe/Mvpp2LibHw.h > @@ -965,7 +965,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > #define MVPP2_RXQ_TOTAL_NUM (MVPP2_MAX_PORTS * MVPP2_MAX_RXQ) > > /* Max number of Rx descriptors */ > -#define MVPP2_MAX_RXD 32 > +#define MVPP2_MAX_RXD 64 > > /* Max number of Tx descriptors */ > #define MVPP2_MAX_TXD 32 > diff --git a/Platform/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h b/Platform/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h > index b85cff7..9e71ec9 100644 > --- a/Platform/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h > +++ b/Platform/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.h > @@ -138,7 +138,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > #define MVPP2_BM_SWF_LONG_POOL(Port) ((Port > 2) ? 2 : Port) > #define MVPP2_BM_SWF_SHORT_POOL 3 > #define MVPP2_BM_POOL 0 > -#define MVPP2_BM_SIZE 32 > +#define MVPP2_BM_SIZE 64 > > /* > * BM short pool packet Size > -- > 1.8.3.1 >