Re: [PATCH 0/2] OvmfPkg, ArmVirtPkg: sync Timeout with PcdPlatformBootTimeOut

["Ard Biesheuvel" <ard.biesheuvel@linaro.org>]

On Wed, 4 Mar 2020 at 15:51, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 03/04/20 10:54, Ard Biesheuvel wrote:
> > On Wed, 4 Mar 2020 at 10:44, Laszlo Ersek <lersek@redhat.com> wrote:
> >>
> >> Repo:   https://pagure.io/lersek/edk2.git
> >> Branch: timeout_var
> >>
> >> In the PlatformBootManagerLib instances, set the Timeout global variable
> >> to the same value as PcdPlatformBootTimeOut. This way the "setvar"
> >> command in the UEFI shell, and the "efibootmgr" command in a Linux
> >> guest, can report the front page timeout that was requested on the QEMU
> >> command line (see GetFrontPageTimeoutFromQemu() in
> >> "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c").
> >>
> >> A DEBUG_VERBOSE message is logged on success too, for our QE team's
> >> sake.
> >>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> Cc: Jordan Justen <jordan.l.justen@intel.com>
> >> Cc: Leif Lindholm <leif@nuviainc.com>
> >> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> >>
> >> Thanks
> >> Laszlo
> >>
> >> Laszlo Ersek (2):
> >>   OvmfPkg/PlatformBootManagerLib: sync Timeout with
> >>     PcdPlatformBootTimeOut
> >>   ArmVirtPkg/PlatformBootManagerLib: sync Timeout with
> >>     PcdPlatformBootTimeOut
> >>
> >
> > Provided that the use of the bare 'sizeof <identifier>' doesn't throw
> > up any build errors with Clang (I seem to remember a report from Mike
> > Kinney about this?)
> >
> > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> I use the "sizeof" operator exclusively without parens if the operand is
> not a type name, at least in packages that I co-maintain. I don't recall
> any particular build failures (even from the edk2 CI).
>

OK fine. I don't remember the exact details, and I kind of like this
notation as well, so ... :-)