From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66])
 by mx.groups.io with SMTP id smtpd.web10.12359.1583333555170000428
 for <devel@edk2.groups.io>;
 Wed, 04 Mar 2020 06:52:35 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=dll6AiuE;
 spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f66.google.com with SMTP id y17so2748173wrn.6
        for <devel@edk2.groups.io>; Wed, 04 Mar 2020 06:52:34 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc:content-transfer-encoding;
        bh=B9nTJMvIESVLIcxhNTGLzXpTlyeDwwB6n93KNwCRHAM=;
        b=dll6AiuEnPBDEvzQrNHbTGbSw4pmcyarbkDe+4/qla4R0mmMzAcB9iaUws4ThWF7bd
         57yq3TMr9MfypzUsxfq3MERxhOLT8ri5Ezy3smgxslI5WCddyYA/mCh4x/la8TJkUuIq
         l7nfIxgcGjSb13Nv3J9IrSPLs3RogMbWiHagewnu3YG5FghCVPISAFgFo7D8gtbi7FEQ
         Q1NXtKVEzbKF7III6k7Wfv+MzzKM9UllF3QGGbjFvbGiepghOiQ1QWVoVfJt1q6R6rKH
         v2X3H3RJGtA3UTtbREAOqVUN3m5XItUj+2AMfUj8SY/gDjsiD9YECOERTfipl66xhSOi
         lg9A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc:content-transfer-encoding;
        bh=B9nTJMvIESVLIcxhNTGLzXpTlyeDwwB6n93KNwCRHAM=;
        b=m/U5wLHK/8/LDSVLn1+gVvjXiOs1VUZyGdWUOhpyoX20kGVa3EaMJkh12nvve01Igv
         6wezGooXPsSA0R80JPDyM8IPoI/gSEPAARQnLxji6Vq0IjWrJcJ3K2r+enpKWoPxh5CD
         Jk70OXYKx7wIMYc+DWtHreWmKJVbuJtTYmt/4kXG7E/FQ59Q6C34O1oOUZiE+XzN4AqT
         +HJ6+w5j3x6erIYQsW6jXRNuETkSb1WxXDQfU9gMNZqRGKHHgYebkjjBDjDNtRx6qqH0
         PBiavG1s4dZNMZ/9UXO4fv0tEjdi/THj08imEbGp+lu3CgOq6BxtsLEl/az/DAtTQuHB
         5T7Q==
X-Gm-Message-State: ANhLgQ0WuPrITjRzQoacRAgotGyWkEdqHYi2gPJi+KiVRaVQNkgtyrad
	g8a5/rZW4uScHgalhmjcK5fq8cHJIphOTSnLRHyXjQ==
X-Google-Smtp-Source: ADFU+vvKTaFolKVuXhnejhN6gPBmGvAFhXJ051/y8JKkf48K3H6OF2HnQyzyocPtRvIO8MnCgS/+dyQg1blbNOtiweU=
X-Received: by 2002:adf:f84a:: with SMTP id d10mr4579681wrq.208.1583333553771;
 Wed, 04 Mar 2020 06:52:33 -0800 (PST)
MIME-Version: 1.0
References: <20200304094413.19462-1-lersek@redhat.com> <CAKv+Gu8UN3rUZO7_PwgfHYQKZMMkWAAw0OfStKZdJ6L+dEQ4zQ@mail.gmail.com>
 <929a77fa-0224-86e2-1ed5-231616052f44@redhat.com>
In-Reply-To: <929a77fa-0224-86e2-1ed5-231616052f44@redhat.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Wed, 4 Mar 2020 15:52:22 +0100
Message-ID: <CAKv+Gu9J-YKewLmEmTJLX_+HXNF6h+BmrK7QkXje1PtYQ4vT6A@mail.gmail.com>
Subject: Re: [PATCH 0/2] OvmfPkg, ArmVirtPkg: sync Timeout with PcdPlatformBootTimeOut
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Jordan Justen <jordan.l.justen@intel.com>, 
	Leif Lindholm <leif@nuviainc.com>, =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= <philmd@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Wed, 4 Mar 2020 at 15:51, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 03/04/20 10:54, Ard Biesheuvel wrote:
> > On Wed, 4 Mar 2020 at 10:44, Laszlo Ersek <lersek@redhat.com> wrote:
> >>
> >> Repo:   https://pagure.io/lersek/edk2.git
> >> Branch: timeout_var
> >>
> >> In the PlatformBootManagerLib instances, set the Timeout global variab=
le
> >> to the same value as PcdPlatformBootTimeOut. This way the "setvar"
> >> command in the UEFI shell, and the "efibootmgr" command in a Linux
> >> guest, can report the front page timeout that was requested on the QEM=
U
> >> command line (see GetFrontPageTimeoutFromQemu() in
> >> "OvmfPkg/Library/QemuBootOrderLib/QemuBootOrderLib.c").
> >>
> >> A DEBUG_VERBOSE message is logged on success too, for our QE team's
> >> sake.
> >>
> >> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >> Cc: Jordan Justen <jordan.l.justen@intel.com>
> >> Cc: Leif Lindholm <leif@nuviainc.com>
> >> Cc: Philippe Mathieu-Daud=C3=A9 <philmd@redhat.com>
> >>
> >> Thanks
> >> Laszlo
> >>
> >> Laszlo Ersek (2):
> >>   OvmfPkg/PlatformBootManagerLib: sync Timeout with
> >>     PcdPlatformBootTimeOut
> >>   ArmVirtPkg/PlatformBootManagerLib: sync Timeout with
> >>     PcdPlatformBootTimeOut
> >>
> >
> > Provided that the use of the bare 'sizeof <identifier>' doesn't throw
> > up any build errors with Clang (I seem to remember a report from Mike
> > Kinney about this?)
> >
> > Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> I use the "sizeof" operator exclusively without parens if the operand is
> not a type name, at least in packages that I co-maintain. I don't recall
> any particular build failures (even from the edk2 CI).
>

OK fine. I don't remember the exact details, and I kind of like this
notation as well, so ... :-)