From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmVirtPkg: remove DmaLib library class resolution
Date: Wed, 30 Aug 2017 10:36:07 +0100 [thread overview]
Message-ID: <CAKv+Gu9JS6cZchgBNJRqrge=Gbt9ZACJdhJt0nCP=bxfZkN9mQ@mail.gmail.com> (raw)
In-Reply-To: <1d61fe4a-d733-c433-8cbb-198acd01df92@redhat.com>
On 30 August 2017 at 09:31, Laszlo Ersek <lersek@redhat.com> wrote:
> On 08/30/17 09:44, Ard Biesheuvel wrote:
>> The virt targets never use non-coherent DMA, so there is no point
>> in having a shared DmaLib library class resolution pointing to
>> ArmDmaLib. So drop it.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>> ArmVirtPkg/ArmVirt.dsc.inc | 1 -
>> 1 file changed, 1 deletion(-)
>>
>> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc
>> index 6a5544e6958d..3770b1ec7565 100644
>> --- a/ArmVirtPkg/ArmVirt.dsc.inc
>> +++ b/ArmVirtPkg/ArmVirt.dsc.inc
>> @@ -91,7 +91,6 @@ [LibraryClasses.common]
>> DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLib.inf
>> CpuExceptionHandlerLib|ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf
>> ArmDisassemblerLib|ArmPkg/Library/ArmDisassemblerLib/ArmDisassemblerLib.inf
>> - DmaLib|ArmPkg/Library/ArmDmaLib/ArmDmaLib.inf
>> ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf
>> ArmGicArchLib|ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.inf
>> ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Pushed as 3946497ff570
Thanks.
prev parent reply other threads:[~2017-08-30 9:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-30 7:44 [PATCH] ArmVirtPkg: remove DmaLib library class resolution Ard Biesheuvel
2017-08-30 8:31 ` Laszlo Ersek
2017-08-30 9:36 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9JS6cZchgBNJRqrge=Gbt9ZACJdhJt0nCP=bxfZkN9mQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox