From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22f.google.com (mail-it0-x22f.google.com [IPv6:2607:f8b0:4001:c0b::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E647D21E95E0F for ; Wed, 30 Aug 2017 02:33:26 -0700 (PDT) Received: by mail-it0-x22f.google.com with SMTP id o132so3930247itc.1 for ; Wed, 30 Aug 2017 02:36:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aRmRqJvoiq/o1SDxb09m7wpFk/v1PYO3/hKl/Jpdisw=; b=NN4wwdDFts4IjxUx2Jmrqn8WDpEbkLQxAEZDjw5hcoF/o9D9QDFnYdQXUWISulrpel vej4Th6qDJB8B56+DDM2ya95IIwjbOqHwid+czSyuIeb15vQtG6XuouaJuaXXGImKD11 rwfBVKMgzv3sdgLG+Dk7ZttOmKzJc0e6DSaac= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aRmRqJvoiq/o1SDxb09m7wpFk/v1PYO3/hKl/Jpdisw=; b=E3YnCcrWToKI4CHQIKM7/677WZeocL8rP67omVY3Kz5VHi7A+jPZ/agqF0p935S34A tHf3okEkE60D6mN+6CcDc7pHiR8AGbMTiKGJS8VmOPdx0WR6vQodDFaf/4xHLlVinXH4 DKAVYCze/K+qVhyqMb2npo09TxZSFI4t6AulpRl1HDwax1DbVG1jhx+NGLV9h+vI7aya JzsMEHGvMz5PBkxT20rv94tvd1sce9So1/sqZQRB+FKUu6UFlk+jIM8Vll3TmAuLB/C4 wUZPITXai4hI9dEnEBHU7I+OWzHMrnSBDOPNlckt0nQbH/QnfNqgr8WOmh1seX5FAiSt Bv1A== X-Gm-Message-State: AHYfb5ioQbGE9QrqEVNwfxwEx4ha2TImcAylVnU+yZjrGUZDzt6UwlQX lKZHPMZvHB2/6FFCP3Uw978xG5ZDKGX1 X-Received: by 10.36.91.195 with SMTP id g186mr781442itb.63.1504085767785; Wed, 30 Aug 2017 02:36:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Wed, 30 Aug 2017 02:36:07 -0700 (PDT) In-Reply-To: <1d61fe4a-d733-c433-8cbb-198acd01df92@redhat.com> References: <20170830074448.31459-1-ard.biesheuvel@linaro.org> <1d61fe4a-d733-c433-8cbb-198acd01df92@redhat.com> From: Ard Biesheuvel Date: Wed, 30 Aug 2017 10:36:07 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmVirtPkg: remove DmaLib library class resolution X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Aug 2017 09:33:27 -0000 Content-Type: text/plain; charset="UTF-8" On 30 August 2017 at 09:31, Laszlo Ersek wrote: > On 08/30/17 09:44, Ard Biesheuvel wrote: >> The virt targets never use non-coherent DMA, so there is no point >> in having a shared DmaLib library class resolution pointing to >> ArmDmaLib. So drop it. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> ArmVirtPkg/ArmVirt.dsc.inc | 1 - >> 1 file changed, 1 deletion(-) >> >> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc >> index 6a5544e6958d..3770b1ec7565 100644 >> --- a/ArmVirtPkg/ArmVirt.dsc.inc >> +++ b/ArmVirtPkg/ArmVirt.dsc.inc >> @@ -91,7 +91,6 @@ [LibraryClasses.common] >> DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLib.inf >> CpuExceptionHandlerLib|ArmPkg/Library/ArmExceptionLib/ArmExceptionLib.inf >> ArmDisassemblerLib|ArmPkg/Library/ArmDisassemblerLib/ArmDisassemblerLib.inf >> - DmaLib|ArmPkg/Library/ArmDmaLib/ArmDmaLib.inf >> ArmGicLib|ArmPkg/Drivers/ArmGic/ArmGicLib.inf >> ArmGicArchLib|ArmVirtPkg/Library/ArmVirtGicArchLib/ArmVirtGicArchLib.inf >> ArmPlatformStackLib|ArmPlatformPkg/Library/ArmPlatformStackLib/ArmPlatformStackLib.inf >> > > Reviewed-by: Laszlo Ersek Pushed as 3946497ff570 Thanks.