Re: [PATCH] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 19 April 2017 at 00:51, Kinney, Michael D <michael.d.kinney@intel.com> wrote:
> Ard,
>
> I found IORT signature defined in Acpi60.h and Acpi61.h, so no
> changes required there.
>
>   ///
>   /// "IORT" I/O Remapping Table
>   ///
>   #define EFI_ACPI_6_1_IO_REMAPPING_TABLE_SIGNATURE  SIGNATURE_32('I', 'O', 'R', 'T')
>

Ah yes, I did spot that but I didn't remember it when replying before.

> I do see some other structures in Acpixx.h that have commented out fields
> for the same reason you provided, so the commented out fields look ok.
> Acpixx.h uses // style comments instead of /* */ style.
>

OK, I will change to // style then -- I have no preference either way

> Are any of these structures defined in the ACPI 6.0 Spec?  Or are they
> only defined in the ARM spec.  If any of them are in the ACPI 6.0 Spec,
> then those should go into the Acpi60.h and Acpi61.h files.
>

No. The ACPI spec mentions IORT but only as a reserved table. The
structure is only defined in the DEN0049 ARM spec.

-- 
Ard.