From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ard.biesheuvel@linaro.org>
Received: from mail-it0-x230.google.com (mail-it0-x230.google.com
 [IPv6:2607:f8b0:4001:c0b::230])
 (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits))
 (No client certificate requested)
 by ml01.01.org (Postfix) with ESMTPS id 971F821A6F108
 for <edk2-devel@lists.01.org>; Wed, 19 Apr 2017 00:03:26 -0700 (PDT)
Received: by mail-it0-x230.google.com with SMTP id b15so23794922iti.1
 for <edk2-devel@lists.01.org>; Wed, 19 Apr 2017 00:03:26 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google;
 h=mime-version:in-reply-to:references:from:date:message-id:subject:to
 :cc; bh=iERaopLmiq0gqWYIRvQ7GFK3VxBz0qElFzv9yozZmPU=;
 b=fuj1P4+zZ77sOaZNiS+DIbBaW4VEvyeaSxZnKj4gS2tcof0W9DIBdjQCryY3fvB8KC
 fYE8TpaoITv47p7LYik1FvsxkWoud5gCDgBiUJSPZVivn1KtvTEBoJR5PnTiQ/mh4u/M
 kJjZZXQNA7w5WcGgRxo3SQSaDxfWnqJzsTGEY=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:in-reply-to:references:from:date
 :message-id:subject:to:cc;
 bh=iERaopLmiq0gqWYIRvQ7GFK3VxBz0qElFzv9yozZmPU=;
 b=HnESXFsc7JJwHIO3ykrNAYfWc78a9bVXnIN/SpqEEhaHfq7ZAnIia6Ep4rHSzPOaE/
 hkyyuMzcbLwx+KrWMq33LCvCSGOt/yNIalFN0Ino2LHYvLT0FK9TlrzNP3XN3/IgHydd
 3NiZ//gyNXm3pQjuH+5O7BqcYRnVXci7PCALTdjlUBAsJuo5dmFpfJ7l13TjSSXCRCCG
 xu+tiRyjWZfnSd0abM54Qu/niX43GPYIL4dG9L9bzaWx3oLZ0jJlxo9w4LrIZ+UlK3fX
 I4qTVD5jV2ONelKlAIo6YXF6SCr29D8/oFq2GBJDJUCH6d7kjXdtaTbK8IFSay09L3Wp
 L0cw==
X-Gm-Message-State: AN3rC/5W78GFjFMF7wUVTV6mHVwbN6hpwwr/pOTR7AJWHIw9EmGRzOrj
 hbxrmypYkvTX44KCeolACALDpHM37CR/
X-Received: by 10.36.120.82 with SMTP id p79mr18298328itc.59.1492585402091;
 Wed, 19 Apr 2017 00:03:22 -0700 (PDT)
MIME-Version: 1.0
Received: by 10.107.201.76 with HTTP; Wed, 19 Apr 2017 00:03:21 -0700 (PDT)
In-Reply-To: <E92EE9817A31E24EB0585FDF735412F57D16A9AC@ORSMSX113.amr.corp.intel.com>
References: <20170413163705.26316-1-ard.biesheuvel@linaro.org>
 <CAKv+Gu-hp_ixKiewoa9rtQQK1mcNaSH832mQzaR6fWmtw8Kq4A@mail.gmail.com>
 <E92EE9817A31E24EB0585FDF735412F57D16A904@ORSMSX113.amr.corp.intel.com>
 <CAKv+Gu8Xjzc=pk3vm0h6UcCe9QxEuPfdYTKp1M79-FAaMfw9rg@mail.gmail.com>
 <E92EE9817A31E24EB0585FDF735412F57D16A9AC@ORSMSX113.amr.corp.intel.com>
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Date: Wed, 19 Apr 2017 08:03:21 +0100
Message-ID: <CAKv+Gu9Ju7J4qjz538=ACSHZLZ_eqA3upPweFSe=7BaYHTv4fQ@mail.gmail.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
 Leif Lindholm <leif.lindholm@linaro.org>, 
 "Gao, Liming" <liming.gao@intel.com>,
 Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Subject: Re: [PATCH] MdePkg/IndustryStandard: add definitions for ACPI 6.0 IORT
X-BeenThere: edk2-devel@lists.01.org
X-Mailman-Version: 2.1.22
Precedence: list
List-Id: EDK II Development  <edk2-devel.lists.01.org>
List-Unsubscribe: <https://lists.01.org/mailman/options/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=unsubscribe>
List-Archive: <http://lists.01.org/pipermail/edk2-devel/>
List-Post: <mailto:edk2-devel@lists.01.org>
List-Help: <mailto:edk2-devel-request@lists.01.org?subject=help>
List-Subscribe: <https://lists.01.org/mailman/listinfo/edk2-devel>,
 <mailto:edk2-devel-request@lists.01.org?subject=subscribe>
X-List-Received-Date: Wed, 19 Apr 2017 07:03:26 -0000
Content-Type: text/plain; charset=UTF-8

On 19 April 2017 at 00:51, Kinney, Michael D <michael.d.kinney@intel.com> wrote:
> Ard,
>
> I found IORT signature defined in Acpi60.h and Acpi61.h, so no
> changes required there.
>
>   ///
>   /// "IORT" I/O Remapping Table
>   ///
>   #define EFI_ACPI_6_1_IO_REMAPPING_TABLE_SIGNATURE  SIGNATURE_32('I', 'O', 'R', 'T')
>

Ah yes, I did spot that but I didn't remember it when replying before.

> I do see some other structures in Acpixx.h that have commented out fields
> for the same reason you provided, so the commented out fields look ok.
> Acpixx.h uses // style comments instead of /* */ style.
>

OK, I will change to // style then -- I have no preference either way

> Are any of these structures defined in the ACPI 6.0 Spec?  Or are they
> only defined in the ARM spec.  If any of them are in the ACPI 6.0 Spec,
> then those should go into the Acpi60.h and Acpi61.h files.
>

No. The ACPI spec mentions IORT but only as a reserved table. The
structure is only defined in the DEN0049 ARM spec.

-- 
Ard.