From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 94C4B2119FF32 for ; Thu, 27 Dec 2018 01:43:40 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id m62so23873099ith.5 for ; Thu, 27 Dec 2018 01:43:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=3EHhz303KWtuQPUmJgfMq3W1kcMQOaoyVO41kZqaHeU=; b=XXXCi/nQYqB/aq86b6zJLU6O+2eCAw6s1gZUuxVwyI5PWixA87+yDWuWVZkb/V5bJk N8CwdniUJjLInst8+uW/AcpAn1lAUM8JGcLFh3Vzr+3V1RQ2cFKt4eaXmd3hkqrxIUiV etvPoTN5yPyOOv+NBnv71hTHnEioVwMhSgnt8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=3EHhz303KWtuQPUmJgfMq3W1kcMQOaoyVO41kZqaHeU=; b=UboslI6WdbBKVCBvP8sqXTo+AZgp4qCk62ROTECYBW43qa8/04WhqsRJ0UXt9LCXK0 YwYq3dwZ1iVfSvMKKEOQlkDsT4kKvTmJAj7N6qrcUezTL19RJb6nAgsDbELiywh9cxp1 3cS8JZMVj9VseUW3OqgSH7/iNMmevXUw4KKXASQzHxpWpAnWyT47CUobJGZks2lFWPbA YEzOrV0+nutCxBH/DZUf8PZYvFrqrumJ4YP2fy1662RSwyYzS7qnKCz1FYlxRUaXLRMf bnfbrVitDJ1urHrO+RZJfvc6MTw2Ii6+oDGR2FvB1q71R4FdtaFI2BxEh7cYZbnX2CY+ ReqQ== X-Gm-Message-State: AA+aEWb27Af3KeFJ+0Kwmh/9akzrfprmvQXtca+YvTtFLaDSGhCpnn6O heVxCVNJyANgMaJ9pmnon/hkreqs/nX6P8zQwNTiwQ== X-Google-Smtp-Source: AFSGD/XfQJVzijC6uGJaptmieeJefZJsqfN6wNrqMWDY5tGjQX+UIKdQLXlSpOVJu5ZhkGI8JuqAmNCllMvL6rvkBwo= X-Received: by 2002:a24:710:: with SMTP id f16mr12898957itf.121.1545903819172; Thu, 27 Dec 2018 01:43:39 -0800 (PST) MIME-Version: 1.0 References: <20181220173104.11481-1-ard.biesheuvel@linaro.org> <20181220173104.11481-4-ard.biesheuvel@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Thu, 27 Dec 2018 10:43:27 +0100 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Leif Lindholm , =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Subject: Re: [PATCH 3/4] ArmPkg/DefaultExceptionHandlerLib: drop BASE variant X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Dec 2018 09:43:40 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 26 Dec 2018 at 22:27, Laszlo Ersek wrote: > > On 12/20/18 18:31, Ard Biesheuvel wrote: > > Drop the redundant BASE variant, which is no longer used anywhere > > now that DebugAgentSymbolsBaseLib no longer incorporates a vector > > table and exception handling. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > --- > > ArmPkg/ArmPkg.dsc | 1 - > > ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c | 35 --------------- > > ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf | 45 -------------------- > > ArmVirtPkg/ArmVirt.dsc.inc | 1 - > > 4 files changed, 82 deletions(-) > > > > diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc > > index 5d83c18b143e..d9f9935d70b6 100644 > > --- a/ArmPkg/ArmPkg.dsc > > +++ b/ArmPkg/ArmPkg.dsc > > @@ -141,7 +141,6 @@ > > ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf > > ArmPkg/Library/ArmLib/ArmBaseLib.inf > > ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf > > - ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf > > ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf > > ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > > > > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c b/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c > > deleted file mode 100644 > > index 4a54298b1189..000000000000 > > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerBase.c > > +++ /dev/null > > @@ -1,35 +0,0 @@ > > -/** @file > > - > > - Copyright (c) 2012, ARM Ltd. All rights reserved.
> > - > > - This program and the accompanying materials > > - are licensed and made available under the terms and conditions of the BSD License > > - which accompanies this distribution. The full text of the license may be found at > > - http://opensource.org/licenses/bsd-license.php > > - > > - THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > - WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > - > > -**/ > > - > > -#include > > - > > -/** > > - > > - @param FaultAddress Address to find PE/COFF image for. > > - @param ImageBase Return load address of found image > > - @param PeCoffSizeOfHeaders Return the size of the PE/COFF header for the image that was found > > - > > - @retval NULL FaultAddress not in a loaded PE/COFF image. > > - @retval Path and file name of PE/COFF image. > > - > > -**/ > > -CHAR8 * > > -GetImageName ( > > - IN UINTN FaultAddress, > > - OUT UINTN *ImageBase, > > - OUT UINTN *PeCoffSizeOfHeaders > > - ) > > -{ > > - return NULL; > > -} > > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf b/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf > > deleted file mode 100644 > > index b53a5e89f507..000000000000 > > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf > > +++ /dev/null > > @@ -1,45 +0,0 @@ > > -#/** @file > > -# > > -# Copyright (c) 2012, ARM Ltd. All rights reserved.
> > -# > > -# This program and the accompanying materials > > -# are licensed and made available under the terms and conditions of the BSD License > > -# which accompanies this distribution. The full text of the license may be found at > > -# http://opensource.org/licenses/bsd-license.php > > -# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > > -# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > > -# > > -# > > -#**/ > > - > > -[Defines] > > - INF_VERSION = 0x00010005 > > - BASE_NAME = DefaultExceptionHandlerBaseLib > > - FILE_GUID = 3d5261d5-5eb7-4559-98e7-475aa9d0dc42 > > - MODULE_TYPE = BASE > > - VERSION_STRING = 1.0 > > - LIBRARY_CLASS = DefaultExceptionHandlerLib > > - > > -[Sources.common] > > - DefaultExceptionHandlerBase.c > > - > > -[Sources.ARM] > > - Arm/DefaultExceptionHandler.c > > - > > -[Sources.AARCH64] > > - AArch64/DefaultExceptionHandler.c > > - > > -[Packages] > > - MdePkg/MdePkg.dec > > - ArmPkg/ArmPkg.dec > > - > > -[LibraryClasses] > > - BaseLib > > - PrintLib > > - DebugLib > > - PeCoffGetEntryPointLib > > - ArmDisassemblerLib > > - SerialPortLib > > - > > -[Guids] > > - gEfiDebugImageInfoTableGuid > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > > index 89c2db074711..c47955be940c 100644 > > --- a/ArmVirtPkg/ArmVirt.dsc.inc > > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > > @@ -174,7 +174,6 @@ > > BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > > > > DebugAgentLib|ArmPkg/Library/DebugAgentSymbolsBaseLib/DebugAgentSymbolsBaseLib.inf > > - DefaultExceptionHandlerLib|ArmPkg/Library/DefaultExceptionHandlerLib/DefaultExceptionHandlerLibBase.inf > > SerialPortLib|ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.inf > > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > > PeiServicesLib|MdePkg/Library/PeiServicesLib/PeiServicesLib.inf > > > > Can you split the ArmVirtPkg hunk to a separate patch? I think that, > after patch #1, it should be possible to remove the > [LibraryClasses.common.SEC] resolution from "ArmVirt.dsc.inc". Then the > present patch can continue saying "... no longer used anywhere". > > Such a split would be more idiomatic to edk2, and also more faithful to > the current subject line (which says "ArmPkg/DefaultExceptionHandlerLib: > ..."). > Sure