From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x232.google.com (mail-io0-x232.google.com [IPv6:2607:f8b0:4001:c06::232]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BFEF121A07AB5 for ; Mon, 3 Jul 2017 04:48:03 -0700 (PDT) Received: by mail-io0-x232.google.com with SMTP id z62so55266715ioi.3 for ; Mon, 03 Jul 2017 04:49:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ZUxo/StOp5yP8MDQg24HFp8Ofh0No4Ziv6UpG+W/9A4=; b=GgXKfCTjjLm/20Y+4xwmu/VbrV6c4Roienbeg9TQWt9k8a3j5aVhdh+tk/CzLHl2MY aqekOFuPJRhNTtNNG/bRHgbXzLMU/utwW0xFJpTOxd/RbMGii+ssxKsh6OF4qmw3PPx7 5ggs6LqfdzFVEcZ+WRV1ETPVOnOyCa9+CvO8Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ZUxo/StOp5yP8MDQg24HFp8Ofh0No4Ziv6UpG+W/9A4=; b=iJ+wPdlXtu8YWQ3ge4QnLyAveFjM6XOi/60d21qJCtR+o2WhX21/Ry2ZRE0NdRSdnP YSg9iMWXiTOb+9bnArxZTM0osqJz87jZ0V1AWd4RdgGXNMVff80/lmcnCcp36lTQ/w0l yKnUOOXEzRHdnns3Yekxm2UlVirPrCnfxcxPs8wYRoZL1dpf6n82hZYwpMVKeHR4RMfI +hQJs5SnCHbPXiCkGnLpYchoQPH7/u79Cu9oQjwDUQ3koH9miCB/Jug3/CRmnOoeQqTM t91ZMmPU4kGSO+f9RTTHzIeMujsSZtaY60YN10QlJkb6Vd7hqs0oXaXOW/ieyoW7UuVw LpzQ== X-Gm-Message-State: AKS2vOw7MBe7ascBSAhqaWrNR4AF54OjKfLyzMQdA42JtbEzosmItv3S iYiJ/g2nmXFuFF1Qc2KQ+1YuMBaAXIYx X-Received: by 10.107.63.214 with SMTP id m205mr36236369ioa.87.1499082579960; Mon, 03 Jul 2017 04:49:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.134.134 with HTTP; Mon, 3 Jul 2017 04:49:39 -0700 (PDT) In-Reply-To: <60ac3e5e-12b6-4bd5-6f7f-a7101b7c7edb@redhat.com> References: <20170629083221.485184-1-ruiyu.ni@intel.com> <60ac3e5e-12b6-4bd5-6f7f-a7101b7c7edb@redhat.com> From: Ard Biesheuvel Date: Mon, 3 Jul 2017 12:49:39 +0100 Message-ID: To: Laszlo Ersek Cc: "Leif Lindholm (Linaro address)" , Ruiyu Ni , "edk2-devel@lists.01.org" , Hao Wu , "Jordan Justen (Intel address)" , Andrew Fish Subject: Re: [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 11:48:04 -0000 Content-Type: text/plain; charset="UTF-8" On 1 July 2017 at 21:04, Laszlo Ersek wrote: > Ard, Leif, > > On 06/29/17 10:32, Ruiyu Ni wrote: >> Ruiyu Ni (3): >> MdePkg: Add ResetNotification protocol definition >> MdeModulePkg/ResetSystem: Remove unnecessary global variable >> MdeModulePkg/ResetSystem: Implement ResetNotification protocol >> >> .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 146 +++++++++++++++++++-- >> .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 21 ++- >> .../ResetSystemRuntimeDxe.inf | 5 +- >> MdePkg/Include/Protocol/ResetNotification.h | 86 ++++++++++++ >> MdePkg/MdePkg.dec | 3 + >> 5 files changed, 247 insertions(+), 14 deletions(-) >> create mode 100644 MdePkg/Include/Protocol/ResetNotification.h >> > > I think we should > - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe, > - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe > to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete > EmbeddedPkg/ResetRuntimeDxe from the tree. > > What do you guys think? > I would happily get rid of EmbeddedPkg/ResetRuntimeDxe, given that I can't really tell why it is there in the first place. Anyone have a clue? > Other producers of gEfiResetArchProtocolGuid could be affected as well > (just from a quick grep): > - DuetPkg/AcpiResetDxe > - EmulatorPkg/ResetRuntimeDxe > - Nt32Pkg/ResetRuntimeDxe > > Thanks > Laszlo