public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Subject: Re: [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency
Date: Fri, 17 Jan 2020 08:41:40 +0100	[thread overview]
Message-ID: <CAKv+Gu9L7pV0PCepJkRUhrKZUox4CsDs9TuXytKWEarR4Equ2Q@mail.gmail.com> (raw)
In-Reply-To: <20200116215528.GH20629@bivouac.eciton.net>

On Thu, 16 Jan 2020 at 22:55, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Jan 15, 2020 at 16:44:01 +0100, Ard Biesheuvel wrote:
> > StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got
> > away with not declaring it in its INF because of a transitive
> > dependency. However, this dependency got dropped in core EDK2,
> > resulting in build failures of the Styx platform.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Pushed, thanks.

> > ---
> >  Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> > index bcc2306ec93d..54a2e4ea9da6 100644
> > --- a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> > +++ b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf
> > @@ -35,6 +35,9 @@
> >    UefiRuntimeLib
> >    DxeServicesTableLib
> >
> > +[Guids]
> > +  gEfiEventVirtualAddressChangeGuid
> > +
> >  [FixedPcd]
> >    gArmTokenSpaceGuid.PcdFdBaseAddress
> >
> > --
> > 2.20.1
> >

      reply	other threads:[~2020-01-17  7:41 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-15 15:44 [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency Ard Biesheuvel
2020-01-16 21:55 ` Leif Lindholm
2020-01-17  7:41   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu9L7pV0PCepJkRUhrKZUox4CsDs9TuXytKWEarR4Equ2Q@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox