From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by mx.groups.io with SMTP id smtpd.web10.1334.1579246913519283976 for ; Thu, 16 Jan 2020 23:41:53 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=h5p4P2vV; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f66.google.com with SMTP id w5so8841287wmi.1 for ; Thu, 16 Jan 2020 23:41:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=VXWPRWfmq0lUn3QIFqjqUur7nlKsn1HNGC5FXGsRkrA=; b=h5p4P2vV38ouh3DYHKJ1+VMqdos1h3hz6MbBRIg/Uz9f2iknsxWkNq+KUUxRTpQu7e tQ8lqZ8+kQSWy52GQ/5dAE2nU8gGCPzyItrRMmMb2sgK8bvSh73rxAdFM7ubvrthnM6G QlVab7tdjHFAnGvLgVR3TyKwKNfNKIE/riYUQfvZX9w+c+dXD3aHEIGsN2gdQtkuxLYy 7C0xMAXAaaAJ71H5ayKV9ggwFV98CebaNfHj3BEVdZZcX1zv0dASCVykNrIo3W3nljJz hSJAG8zv/6e1uKTTSLGD8jaLBbYn7Dt1Zab4V4ZI3RXR2BcvQHpkO5boPyvjEvr0mSTZ XGcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=VXWPRWfmq0lUn3QIFqjqUur7nlKsn1HNGC5FXGsRkrA=; b=m0Paphbq/r74k8Z6d9B2PeAEm2yE5j+PCgukTzPnH3b6Xg6VIFzNrvPbBZqfqN1Y47 gxWy6X4C5OuWlfGqOB3kD9MbCMDDSayDBaYe+i8+XcPxrxUMEH3yUXRA9Xwg1ueD52nA /85+RxxGvpjfPlS1cqFvhlNEqb64NVgs5BkQCxE8VdHH5wjynWnj/QbI97e21ixBpXfe X/UjnP6b47KAHAvBrOriyr1wT9ToWc4pRMleI2UiS+Gf7/gmP8TGDqOUPm4xsg9EZ0xl VtjCHEl+j36iEzkrz79pjG6OQV9m6Jx/56iGSzHo1R8wSY80RiyYBVhXidFd1s7IRJm9 l/4Q== X-Gm-Message-State: APjAAAURrHTZ3nqCzIbZLD+bqbeGJ3V27ppkoH36cBrk3+2wNlojhW8o zJQq5uzQNqZ6cWFm5TBavviwsw15SYy4TNvGINYKmg== X-Google-Smtp-Source: APXvYqznW/kSLo/NbXrFlouN9L1QnZU/9FQAgR89AAfXbNg4YdOSOmwJn2l0eLk0HO0KpRexcuvyvZ6z6z9UEm66ZQc= X-Received: by 2002:a7b:cc81:: with SMTP id p1mr3065323wma.62.1579246911922; Thu, 16 Jan 2020 23:41:51 -0800 (PST) MIME-Version: 1.0 References: <20200115154401.12972-1-ard.biesheuvel@linaro.org> <20200116215528.GH20629@bivouac.eciton.net> In-Reply-To: <20200116215528.GH20629@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Fri, 17 Jan 2020 08:41:40 +0100 Message-ID: Subject: Re: [PATCH edk2-platforms] Silicon/AMD/StyxSpiFvDxe: declare missing GUID dependency To: Leif Lindholm Cc: edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" On Thu, 16 Jan 2020 at 22:55, Leif Lindholm wrote: > > On Wed, Jan 15, 2020 at 16:44:01 +0100, Ard Biesheuvel wrote: > > StyxSpiFvDxe depends on gEfiEventVirtualAddressChangeGuid, but got > > away with not declaring it in its INF because of a transitive > > dependency. However, this dependency got dropped in core EDK2, > > resulting in build failures of the Styx platform. > > > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Pushed, thanks. > > --- > > Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > > index bcc2306ec93d..54a2e4ea9da6 100644 > > --- a/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > > +++ b/Silicon/AMD/Styx/Drivers/StyxSpiFvDxe/StyxSpiFvDxe.inf > > @@ -35,6 +35,9 @@ > > UefiRuntimeLib > > DxeServicesTableLib > > > > +[Guids] > > + gEfiEventVirtualAddressChangeGuid > > + > > [FixedPcd] > > gArmTokenSpaceGuid.PcdFdBaseAddress > > > > -- > > 2.20.1 > >