From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>
Subject: Re: [PATCH v2 13/19] ArmVirtPkg/PlatformBds: Do not call BootLogoEnableLogo
Date: Mon, 26 Sep 2016 05:56:14 -0700 [thread overview]
Message-ID: <CAKv+Gu9LBfM1Q6PgybxgJ=XEoGvWiaUug2dPANomcDwZRipf7Q@mail.gmail.com> (raw)
In-Reply-To: <28a7843f-a178-c8e0-bb85-8d46ef8bd90b@redhat.com>
On 26 September 2016 at 03:06, Laszlo Ersek <lersek@redhat.com> wrote:
> On 09/26/16 11:30, Ruiyu Ni wrote:
>> Prototype of BootLogoEnableLogo will change in following patches, so
>> do not call BootLogoEnableLogo to avoid build failure.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Cc: Laszlo Ersek <lersek@redhat.com>
>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
>> ---
>> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 14 +++++++-------
>> .../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 -
>> 2 files changed, 7 insertions(+), 8 deletions(-)
>>
>> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> index c11196a..5d7c2a4 100644
>> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c
>> @@ -657,13 +657,13 @@ PlatformBootManagerAfterConsole (
>> //
>> // Show the splash screen.
>> //
>> - BootLogoEnableLogo (
>> - ImageFormatBmp, // ImageFormat
>> - PcdGetPtr (PcdLogoFile), // Logo
>> - EdkiiPlatformLogoDisplayAttributeCenter, // Attribute
>> - 0, // OffsetX
>> - 0 // OffsetY
>> - );
>> + // BootLogoEnableLogo (
>> + // ImageFormatBmp, // ImageFormat
>> + // PcdGetPtr (PcdLogoFile), // Logo
>> + // EdkiiPlatformLogoDisplayAttributeCenter, // Attribute
>> + // 0, // OffsetX
>> + // 0 // OffsetY
>> + // );
>>
>> //
>> // Connect the rest of the devices.
>> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>> index bec7fab..1f162c6 100644
>> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>> @@ -58,7 +58,6 @@ [LibraryClasses]
>> UefiRuntimeServicesTableLib
>>
>> [FixedPcd]
>> - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile
>> gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile
>> gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate
>> gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits
>>
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
next prev parent reply other threads:[~2016-09-26 12:56 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-26 9:30 [PATCH v2 00/19] Add HiiImageEx implementations Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 01/19] MdeModulePkg/HiiDatabase: Refine GetImageIdOrAddress Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 02/19] MdeModulePkg/HiiDatabase: Move common code to LocatePackageList() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 03/19] MdeModulePkg/HiiDatabase: Refine HiiNewImage() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 04/19] MdeModulePkg/HiiDatabase: Refine HiiGetImage() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 05/19] MdeModulePkg/HiiDatabase: Refine HiiSetImage() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 06/19] MdeModulePkg/HiiDatabase: Refine HiiDrawImage() Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 07/19] MdemodulePkg/HiiDatabase: Correct typo in comments Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 08/19] MdePkg/HiiImage.h: Include GraphicsOutput.h Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 09/19] MdeModulePkg/HiiDatabase: Update HiiImage to support PNG/JPEG Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 10/19] MdePkg/HiiImageDecoder.h: Add HiiImageDecoder protocol header file Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 11/19] MdeModulePkg/HiiDatabase: Add HiiImageEx implementation Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 12/19] Nt32Pkg/PlatformBds: Do not call BootLogoEnableLogo Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 13/19] ArmVirtPkg/PlatformBds: " Ruiyu Ni
2016-09-26 10:06 ` Laszlo Ersek
2016-09-26 12:56 ` Ard Biesheuvel [this message]
2016-09-26 9:30 ` [PATCH v2 14/19] OvmfPkg/PlatformBds: " Ruiyu Ni
2016-09-26 10:06 ` Laszlo Ersek
2016-09-26 9:30 ` [PATCH v2 15/19] MdeModulePkg/BootLogoLib&PlatformLogo: Use HII data types in parameters Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 16/19] MdeModulePkg/Logo: Add LogoDxe module Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 17/19] Nt32Pkg: Use the new LogoDxe driver Ruiyu Ni
2016-09-26 9:30 ` [PATCH v2 18/19] ArmVirtPkg: " Ruiyu Ni
2016-09-26 10:06 ` Laszlo Ersek
2016-09-26 12:56 ` Ard Biesheuvel
2016-09-26 9:30 ` [PATCH v2 19/19] OvmfPkg: " Ruiyu Ni
2016-09-26 10:06 ` Laszlo Ersek
2016-09-28 8:12 ` [PATCH v2 00/19] Add HiiImageEx implementations Gao, Liming
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9LBfM1Q6PgybxgJ=XEoGvWiaUug2dPANomcDwZRipf7Q@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox