From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x235.google.com (mail-io0-x235.google.com [IPv6:2607:f8b0:4001:c06::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5CFF31A1E06 for ; Mon, 26 Sep 2016 05:56:15 -0700 (PDT) Received: by mail-io0-x235.google.com with SMTP id r145so180957840ior.0 for ; Mon, 26 Sep 2016 05:56:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dO2SZsvm1PcTEYGppiCB7EgyB9dBiEKgnidAaz8RRW0=; b=iW5MZlvQFk3ZhwlNQUoPmhPLXADMwwAXYXTppW4YGBkQ3bra90+HzUB1gftbiXc4UF XAJdrCxTCWUE3B467qW5IhGBL54VktbpcyRaut87714PaV5iI85Hk5pNFQHgJ2lkTCq/ ev2O1p0ZEdlyUc3NdwWBRs2CslXUUwtkdnW3Q= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dO2SZsvm1PcTEYGppiCB7EgyB9dBiEKgnidAaz8RRW0=; b=LW/HS5jCd3ulimiSyJ0IiZECToItwy3K73GUvWgtST6RO3QSrFuN66AvPaWIfcXVGM FhCuN/0/hz0Yl3sYnx61c7iBq67YLbHGBH+lBUQO6wE5FvG1ovMyndxj5l1SCOe9KFU7 JgVzffOqtep+3O7mwAXfnR6q3ejQ3xFIzxS9DpVsB5cpYz77D1HwDNnQhAaQp5mWS4UY hI9qcUsWu32RYlGlVVS0ajNar3OeCvNQMHM2RhEWqWeeiOVPbDOTI6QmpfkinuukSISn +L5fvbiL7XC5dcjNaMxm4nxcuL1pKFWkI6US1ofbOWv/0mAJIiE5F6OgrzgH5Yn4tIh5 xJnQ== X-Gm-Message-State: AE9vXwME6WGsjMato9Ozc4UkGZgpvAd4viI03M9XBeZQPZqd3Q+rf7bxue+KQUGfCxCSf1tK94tKFPPpuhWOQLtf X-Received: by 10.107.133.17 with SMTP id h17mr27077283iod.148.1474894574617; Mon, 26 Sep 2016 05:56:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Mon, 26 Sep 2016 05:56:14 -0700 (PDT) In-Reply-To: <28a7843f-a178-c8e0-bb85-8d46ef8bd90b@redhat.com> References: <20160926093035.350612-1-ruiyu.ni@intel.com> <20160926093035.350612-14-ruiyu.ni@intel.com> <28a7843f-a178-c8e0-bb85-8d46ef8bd90b@redhat.com> From: Ard Biesheuvel Date: Mon, 26 Sep 2016 05:56:14 -0700 Message-ID: To: Laszlo Ersek Cc: Ruiyu Ni , "edk2-devel@lists.01.org" Subject: Re: [PATCH v2 13/19] ArmVirtPkg/PlatformBds: Do not call BootLogoEnableLogo X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 12:56:15 -0000 Content-Type: text/plain; charset=UTF-8 On 26 September 2016 at 03:06, Laszlo Ersek wrote: > On 09/26/16 11:30, Ruiyu Ni wrote: >> Prototype of BootLogoEnableLogo will change in following patches, so >> do not call BootLogoEnableLogo to avoid build failure. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Cc: Laszlo Ersek >> Cc: Ard Biesheuvel >> Signed-off-by: Ruiyu Ni >> --- >> ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c | 14 +++++++------- >> .../PlatformBootManagerLib/PlatformBootManagerLib.inf | 1 - >> 2 files changed, 7 insertions(+), 8 deletions(-) >> >> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c >> index c11196a..5d7c2a4 100644 >> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c >> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBm.c >> @@ -657,13 +657,13 @@ PlatformBootManagerAfterConsole ( >> // >> // Show the splash screen. >> // >> - BootLogoEnableLogo ( >> - ImageFormatBmp, // ImageFormat >> - PcdGetPtr (PcdLogoFile), // Logo >> - EdkiiPlatformLogoDisplayAttributeCenter, // Attribute >> - 0, // OffsetX >> - 0 // OffsetY >> - ); >> + // BootLogoEnableLogo ( >> + // ImageFormatBmp, // ImageFormat >> + // PcdGetPtr (PcdLogoFile), // Logo >> + // EdkiiPlatformLogoDisplayAttributeCenter, // Attribute >> + // 0, // OffsetX >> + // 0 // OffsetY >> + // ); >> >> // >> // Connect the rest of the devices. >> diff --git a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> index bec7fab..1f162c6 100644 >> --- a/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> +++ b/ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> @@ -58,7 +58,6 @@ [LibraryClasses] >> UefiRuntimeServicesTableLib >> >> [FixedPcd] >> - gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile >> gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile >> gEfiMdePkgTokenSpaceGuid.PcdUartDefaultBaudRate >> gEfiMdePkgTokenSpaceGuid.PcdUartDefaultDataBits >> > > Reviewed-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel