From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 98447208D6126 for ; Mon, 11 Feb 2019 01:01:10 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id c9so24344955itj.1 for ; Mon, 11 Feb 2019 01:01:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xTK807iTW69eQ2Yw+usdUXHsntOMthB8alQJOF8F5b4=; b=GDBab+IuUT+vvmfTMN5XP10j7OBX8VebgveZukJPFulqN9X0KEmdzNaecjGSkEvbeB q3VOaxVP2C5XZyK7sVVX2kc0sFZaIrg+dcveX9yeIoMIYYiuDwgshR3yN7Aib76OBbFH n0e87lxEo3BD8IVBTfDa1mgvIxy2K8UtdBUxQ3gw/VdErqzVkA4s83WgXP4FVF/Ay94O wKI7HwIKqMmOFjRRnwHzDyanVIouHKKr2YOHrp1kPo7hjiANoz7dz9837zD3uu0UA3QT K4M7VIxuZk/Snio7uP0jOibjnRyHZwuzDKQHxZ4VpPU7MX9ceXICUIHWXsL6zEDiXr3c kMtA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xTK807iTW69eQ2Yw+usdUXHsntOMthB8alQJOF8F5b4=; b=NDIpldYh1nLMR/k1IvF9gfI2bceFXsv/a9YjC92KdejeVfmD7uFn5SRLlnMmzyUv7G SvEY1YA1KPe36gZ3nJL1xyR+Ty894YmsxHiZcQ8DSNkJBhgxa99KhNxAtowgnDGFIQJ3 07ZmqsFoEePX/5ThSLM2t5PfA30GZwhYOLT4yICckRrUMHvy9MiWjZVCIu3ltGj2cwlE 5AjczG+tEgkbJyuTayt1vPnxnJ0eua5tW/Ag+aHbI+gIQjSmYPB0zZAcRBLU+8Qho/h0 MXej+2ElLVsQtKQZQ16+Rv+LU4QNMklPptkQHn9+FcYU6SEfTkey9XOVTY5Hhu11AjPo G7vQ== X-Gm-Message-State: AHQUAuZIUJHnlCVpgKlEr64w/dA7l/CglFZeNP3Hz0Pca9GDylh4eE28 mY97E55fnDTEJgGx1uC3f7IGTzG5LenIiMOorXCUfw== X-Google-Smtp-Source: AHgI3IaXmfwvRphogKYdLuCmwT+bccl/A1pBd9ZuEMXQG0Pv6ffpsICatlpXx0rLBZStNWMIEou/Ln51HOKaP5W0TJ4= X-Received: by 2002:a5e:d609:: with SMTP id w9mr15879019iom.170.1549875669424; Mon, 11 Feb 2019 01:01:09 -0800 (PST) MIME-Version: 1.0 References: <20190211024809.20408-1-shenglei.zhang@intel.com> <20190211024809.20408-6-shenglei.zhang@intel.com> In-Reply-To: <20190211024809.20408-6-shenglei.zhang@intel.com> From: Ard Biesheuvel Date: Mon, 11 Feb 2019 09:00:58 +0000 Message-ID: To: Shenglei Zhang Cc: "edk2-devel@lists.01.org" , Jordan Justen , Laszlo Ersek , Anthony Perard , Julien Grall Subject: Re: [PATCH v2 05/10] OvmfPkg/README: Remove UNIXGCC X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Feb 2019 09:01:10 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 11 Feb 2019 at 02:48, Shenglei Zhang wrote: > > Remove UNIXGCC in OvmfPkgIa32.dsc, OvmfPkgIa32X64.dsc > and OvmfPkgX64.dsc. > Remove content related to UNIXGCC in README. > https://bugzilla.tianocore.org/show_bug.cgi?id=1377 > > Cc: Jordan Justen > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Anthony Perard > Cc: Julien Grall > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Shenglei Zhang > Reviewed-by: Laszlo Ersek Acked-by: Ard Biesheuvel > --- > OvmfPkg/OvmfPkgIa32.dsc | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > OvmfPkg/OvmfPkgX64.dsc | 1 - > OvmfPkg/README | 19 ------------------- > 4 files changed, 22 deletions(-) > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index aee19b75d7..7872ead8de 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -61,7 +61,6 @@ > !endif > > [BuildOptions] > - GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index 90cbd8e341..eef8ae25f3 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -61,7 +61,6 @@ > !endif > > [BuildOptions] > - GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 83d16eb00b..6d5623857c 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -61,7 +61,6 @@ > !endif > > [BuildOptions] > - GCC:*_UNIXGCC_*_CC_FLAGS = -DMDEPKG_NDEBUG > GCC:RELEASE_*_*_CC_FLAGS = -DMDEPKG_NDEBUG > INTEL:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > MSFT:RELEASE_*_*_CC_FLAGS = /D MDEPKG_NDEBUG > diff --git a/OvmfPkg/README b/OvmfPkg/README > index 68ce0750af..c014d07bfb 100644 > --- a/OvmfPkg/README > +++ b/OvmfPkg/README > @@ -402,25 +402,6 @@ main firmware (MAINFV) into RAM memory at address 0x800000. The > remaining OVMF firmware then uses this decompressed firmware > volume image. > > -=== UNIXGCC Debug === > - > -If you build with the UNIXGCC toolchain, then debugging will be disabled > -due to larger image sizes being produced by the UNIXGCC toolchain. The > -first choice recommendation is to use GCC48 or newer instead. > - > -If you must use UNIXGCC, then you can override the build options for > -particular libraries and modules in the .dsc to re-enable debugging > -selectively. For example: > - [Components] > - OvmfPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf { > - > - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG > - } > - MdeModulePkg/Universal/BdsDxe/BdsDxe.inf { > - > - GCC:*_*_*_CC_FLAGS = -UMDEPKG_NDEBUG > - } > - > === UEFI Windows 7 & Windows 2008 Server === > > * One of the '-vga std' and '-vga qxl' QEMU options should be used. > -- > 2.18.0.windows.1 >