From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::241; helo=mail-io0-x241.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x241.google.com (mail-io0-x241.google.com [IPv6:2607:f8b0:4001:c06::241]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 70C4721BADAB2 for ; Wed, 18 Jul 2018 07:02:40 -0700 (PDT) Received: by mail-io0-x241.google.com with SMTP id y10-v6so4168895ioa.10 for ; Wed, 18 Jul 2018 07:02:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=flAI48G4nSP7chsPm2/Uo8NdSHWTK4arCDjLkCmD34c=; b=WMtJUNfZGaKW8feRTTqov+1c6qrpi5I+I8iZqDcUynd0IvvJh+M/kR+NpHWm/Tz7xE FshmLD9/mjJpNRJnUoKStVkcBCanfE8qRrk+cmp1k1vo2mqUyhPS2GlwPassCNGKwsHB LcNgnBhyUu/bstDogzmVEwBK88WiajJWcRy9I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=flAI48G4nSP7chsPm2/Uo8NdSHWTK4arCDjLkCmD34c=; b=Vu6vpFE7O69bpuGjxekS3RPzNP2C7ftp1blhjdBCP06lxuehuM+mJ5mKvfTfHRnOv7 FatLSvwwKfaq4T6C2YktI9euvB189IEse0tlEu6jB05CSBcX/bK41pofW1XQ+Ub2ZjWb x5eqUMIKa0Jt2nK4aSzFe/bq0t95QHeLbFJhL/ug/YmdrzkGECCD6vlIe7YOWKhWYJYU 9lE2myA5CEaXEdvwUzV9Zcy4Q9w2478BfHpfu/f/y1NUoSMwa6IXB7m29njpfLiKDeDr I5uhfuC233dTu38r+3VzGJGb8KEJt0JGcRGJ2DuTBI9YY26PqdJ2U80AFXAZ/C/dpMLJ cAwA== X-Gm-Message-State: AOUpUlELYH3/63YZh8uc87MsCJk8HIdd5eLnyzWWjkqFD09DmMr8WZiw bdvHJWy5FPev4YCzOg/5FiI7P9SJeo+I0QNNtaV/aw== X-Google-Smtp-Source: AAOMgpdiT7+UbP6sY98OeaQFdFlUB5iXV8/EjopW/AZc76FnHQu5387fXggmsmPT+vh04fPAR4HMci+7YYuW2W7dsM0= X-Received: by 2002:a6b:5208:: with SMTP id g8-v6mr5345916iob.60.1531922559966; Wed, 18 Jul 2018 07:02:39 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Wed, 18 Jul 2018 07:02:39 -0700 (PDT) In-Reply-To: <20180718125222.9047-1-lersek@redhat.com> References: <20180718125222.9047-1-lersek@redhat.com> From: Ard Biesheuvel Date: Wed, 18 Jul 2018 23:02:39 +0900 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Jordan Justen , Steven Shi Subject: Re: [PATCH] OvmfPkg/AcpiPlatformDxe: clean up libs and protos in "AcpiPlatformDxe.inf" X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 18 Jul 2018 14:02:41 -0000 Content-Type: text/plain; charset="UTF-8" On 18 July 2018 at 21:52, Laszlo Ersek wrote: > None of the source files referenced by "AcpiPlatformDxe.inf" #include > "MdePkg/Include/Library/DxeServicesLib.h" or use interfaces declared > therein, so drop DxeServicesLib from [LibraryClasses]. > > "AcpiPlatformDxe.inf" references "AcpiPlatform.c", which installs ACPI > tables built into the firmware image from under "OvmfPkg/AcpiTables/", in > case dynamically generated ACPI tables are not available from Xen or QEMU. > For this, the driver consumes gEfiFirmwareVolume2ProtocolGuid. Account for > that in [Protocols]. > > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Steven Shi > Reported-by: Steven Shi > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1014 > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > > Notes: > Repo: https://github.com/lersek/edk2.git > Branch: acpiplatform_redundant_tiano_1014 > > OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf > index edc192e03d73..8440e7b343d8 100644 > --- a/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf > +++ b/OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf > @@ -46,7 +46,6 @@ [Packages] > > [LibraryClasses] > UefiLib > - DxeServicesLib > PcdLib > BaseMemoryLib > DebugLib > @@ -62,6 +61,7 @@ [LibraryClasses] > > [Protocols] > gEfiAcpiTableProtocolGuid # PROTOCOL ALWAYS_CONSUMED > + gEfiFirmwareVolume2ProtocolGuid # PROTOCOL SOMETIMES_CONSUMED > gEfiPciIoProtocolGuid # PROTOCOL SOMETIMES_CONSUMED > > [Guids] > -- > 2.14.1.3.gb7cf6e02401b >