From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::d41; helo=mail-io1-xd41.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io1-xd41.google.com (mail-io1-xd41.google.com [IPv6:2607:f8b0:4864:20::d41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6B5F6211B6C3B for ; Thu, 17 Jan 2019 03:00:00 -0800 (PST) Received: by mail-io1-xd41.google.com with SMTP id c2so7411933iom.12 for ; Thu, 17 Jan 2019 03:00:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eHkp/nogTs6W+dSeVLdcdMcouTlhCSkNPHKF+waD3hE=; b=Rp/7k3nfQWA7u+ZuFt4rw0kL93jfju8S7k4ZEKUVbV33e2uLrWtyNIrza5kpGgu/dQ mIO7Xj0Mbdm/tNh4nrmfD2l8F17p0/IWW0Ar4fjQTefCtV4XxD4ztBbF/Kb4qXXgkXHr flHL8ABh9JcfMBMhqpytHRoy/9v5IA2hvrSv0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eHkp/nogTs6W+dSeVLdcdMcouTlhCSkNPHKF+waD3hE=; b=B3odB61XQbyWe6rwzyAoLTl9x9FfZrQLUOnF0Z14EvKKiaz7XEnG7lTU5t67Nktf65 nH/T1GU9HMJPHBAztBLhobNTBbeSuAxRVWWb7sIB1/gAuwELMRKeOkrZJgl6uZ1tf7Mz uCAYBIpzdgqa1I2A4q3fW4l9zWquOXzcZSRqIxOKyIDK/wpM/leb4OX/WsHMKIafhV4X 319FNXf9KJ9mMsj2sx7QIExn6a3wnDnwx0KBQAAj3Q3lugWOPgIQ3qmzYuPCF28WhXMq tbRGnsZnkiekZrsmG9KjRShtlymGQi1jt14QF3QN2/6IGPzGegLYm0g84uGtTGQqesVw bpCg== X-Gm-Message-State: AJcUuke7T/TsLNWZ0W8zIJmZMuzjLULvJYnMy7jXco+oY2iO+dBYQ3J1 lVI2V2nBshA29SDxuuekAhtd88qEgFD9ZrrfXvixOg== X-Google-Smtp-Source: ALg8bN7x+7+vgJ8OCQHFcaUocuoFgXa+NYfkyaZrOFDQE3Bj/uSuz7UkzFKX7UzEKuo1B4zLIlyMqPrKRhMdDAxinyE= X-Received: by 2002:a5e:c206:: with SMTP id v6mr7736320iop.60.1547722799212; Thu, 17 Jan 2019 02:59:59 -0800 (PST) MIME-Version: 1.0 References: <20190104144336.8941-1-ard.biesheuvel@linaro.org> <20190104144336.8941-2-ard.biesheuvel@linaro.org> <20190117095015.mtmoazzmvfrkvz6p@bivouac.eciton.net> In-Reply-To: <20190117095015.mtmoazzmvfrkvz6p@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 17 Jan 2019 11:59:46 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Masahisa Kojima Subject: Re: [PATCH edk2-platforms 1/7] Silicon/SynQuacer/Fip006Dxe: drop block I/O and disk I/O routines X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 11:00:00 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 17 Jan 2019 at 10:50, Leif Lindholm wrote: > > On Fri, Jan 04, 2019 at 03:43:30PM +0100, Ard Biesheuvel wrote: > > The FIP006 NOR flash driver contains implementations of the block I/O > > and disk I/O protocols, but never exposes them to other drivers (i.e., > > it never installs the protocol interfaces). So let's drop this code > > altogether: the NOR flash is for code and variables, not for arbitrary > > files. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > > Feel free to push this one in isolation - it's a useful improvement > anyway, may prevent someone from getting unfortunate ideas.... > Thanks - pushed as e48031fd75e6..944fbb62d684 > > --- > > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/Fip006Dxe.inf | 3 - > > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashBlockIoDxe.c | 138 ------------ > > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.c | 229 ++------------------ > > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashDxe.h | 51 +---- > > Silicon/Socionext/SynQuacer/Drivers/Fip006Dxe/NorFlashFvbDxe.c | 40 ++-- > > 5 files changed, 37 insertions(+), 424 deletions(-)