public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-01 <edk2-devel@lists.01.org>,
	Feng Tian <feng.tian@intel.com>,  Star Zeng <star.zeng@intel.com>,
	Laszlo Ersek <lersek@redhat.com>
Subject: Re: [PATCH 2/2] ArmVirtPkg: enable EBC interpreter for AArch64 QEMU
Date: Wed, 17 Aug 2016 15:47:41 +0200	[thread overview]
Message-ID: <CAKv+Gu9LzRZBCrj4=WzM8Y-wyD6c6Pre+j_m9i9BXmAXiyBUNQ@mail.gmail.com> (raw)
In-Reply-To: <1471441502-21873-3-git-send-email-leif.lindholm@linaro.org>

On 17 August 2016 at 15:45, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> Since we now have EBC support for AArch64, enable it by default
> on the QEMU platform.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  ArmVirtPkg/ArmVirtQemu.dsc           | 1 +
>  ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 5 +++++
>  2 files changed, 6 insertions(+)
>
> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc
> index 9f88786..fb851e7 100644
> --- a/ArmVirtPkg/ArmVirtQemu.dsc
> +++ b/ArmVirtPkg/ArmVirtQemu.dsc
> @@ -401,3 +401,4 @@ [Components.AARCH64]
>      <LibraryClasses>
>        NULL|ArmVirtPkg/Library/FdtPciPcdProducerLib/FdtPciPcdProducerLib.inf
>    }
> +  MdeModulePkg/Universal/EbcDxe/EbcDxe.inf

Please add it to ArmVirtPkg/ArmVirtQemuKernel.dsc as well:
ArmVirtQemuFvMain.fdf.inc is shared between them.

With that,

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> index ad7037f..0a5b899 100644
> --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc
> @@ -146,6 +146,11 @@ [FV.FvMain]
>    #
>    INF MdeModulePkg/Universal/Acpi/AcpiTableDxe/AcpiTableDxe.inf
>    INF OvmfPkg/AcpiPlatformDxe/QemuFwCfgAcpiPlatformDxe.inf
> +
> +  #
> +  # EBC support
> +  #
> +  INF MdeModulePkg/Universal/EbcDxe/EbcDxe.inf
>  !endif
>
>    #
> --
> 2.1.4
>


  reply	other threads:[~2016-08-17 13:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-17 13:45 [PATCH 0/2] Add EBC support for AArch64 Leif Lindholm
2016-08-17 13:45 ` [PATCH 1/2] MdeModulePkg/EbcDxe: Add AARCH64 EBC VM support Leif Lindholm
2016-08-17 13:46   ` Ard Biesheuvel
2016-08-19  3:12   ` Tian, Feng
2016-08-23  4:33     ` Jordan Justen
2016-08-23  4:57       ` Tian, Feng
2016-08-26 10:56         ` Leif Lindholm
2016-08-17 13:45 ` [PATCH 2/2] ArmVirtPkg: enable EBC interpreter for AArch64 QEMU Leif Lindholm
2016-08-17 13:47   ` Ard Biesheuvel [this message]
2016-08-17 13:55     ` Laszlo Ersek
2016-08-17 14:04       ` Ard Biesheuvel
2016-08-19  1:42         ` Laszlo Ersek
2016-08-17 14:04       ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu9LzRZBCrj4=WzM8Y-wyD6c6Pre+j_m9i9BXmAXiyBUNQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox