Re: [PATCH edk2-platforms v1 1/1] Silicon/SynQuacer: add OP-TEE based RNG driver

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On Tue, 18 Dec 2018 at 13:46, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
>
> On Tue, 18 Dec 2018 at 13:17, Sumit Garg <sumit.garg@linaro.org> wrote:
> >
> > Hi Ard,
> >
> > On Wed, 12 Dec 2018 at 11:05, Sumit Garg <sumit.garg@linaro.org> wrote:
> > >
> > > On Tue, 11 Dec 2018 at 21:37, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > >
> > > > On Tue, 11 Dec 2018 at 10:06, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > > >
> > > > > On Tue, 11 Dec 2018 at 10:04, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > > >
> > > > > > On Tue, 11 Dec 2018 at 13:56, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> > > > > > >
> > > > > > > On Tue, 11 Dec 2018 at 08:46, Sumit Garg <sumit.garg@linaro.org> wrote:
> > > > > > > >
> > > > > > > > This driver uses OpteeLib to interface with OP-TEE based RNG service
> > > > > > > > (pseudo trusted application) to implement EFI_RNG_PROTOCOL that is used
> > > > > > > > to seed kernel entropy pool.
> > > > > > > >
> > > > > > > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > > > > > > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1
> > > > > > > > Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
> > > > > > >
> > > > > > > Excellent! Happy to see this code going upstream.
> > > > > > >
> > > > > >
> > > > > > Thanks Ard.
> > > > > >
> > > > > > > This code looks fine to me, but I'd like to test it with an updated
> > > > > > > OP-TEE build first before I merge it.
> > > > > > >
> > > > > >
> > > > > > Agree, will wait for OP-TEE PR to be merged. BTW, if you need I could
> > > > > > share updated "fip_all_arm_tf.bin" using OP-TEE PR for testing.
> > > > > >
> > > > >
> > > > > Yes please, that would be useful.
> > > > >
> > > > >
> > > >
> > > > OK, I successfully tested this patch on my SynQuacer box. Very nice work!
> > > >
> > >
> > > Thanks Ard for testing this patch.
> > >
> > > > So this is ready to go in as soon as the OP-TEE side is merged as
> > > > well, so please keep me informed about that (and contribute a new
> > > > ARM-TF + OP-TEE build to edk2-non-osi)
> > >
> > > Sure will let you know about OP-TEE PR merge and yes will contribute a
> > > new ARM-TF + OP-TEE build to edk2-non-osi.
> > >
> >
> > OP-TEE PR [1] has been merged. Also I have sent a patch to contribute
> > new ARM-TF + OP-TEE build. Please have a look.
> >
> > [1] https://github.com/OP-TEE/optee_os/pull/2564
> >
>
> Wonderful! Thanks a lot.

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as c955b5129771..dc6b5ef8a6c2