From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::243; helo=mail-oi1-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-oi1-x243.google.com (mail-oi1-x243.google.com [IPv6:2607:f8b0:4864:20::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 22DD0211A4595 for ; Thu, 20 Dec 2018 02:44:00 -0800 (PST) Received: by mail-oi1-x243.google.com with SMTP id t204so1135724oie.7 for ; Thu, 20 Dec 2018 02:43:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8YDPak26cV7NvwaJhnsTQuanfTOhuKDRKNVRIaBSzCg=; b=M98OF8zFsH1StMtlD29PowAng75RUhlkUkL/5anhbdKR972WWqdLyjJ2KfiBgu7uMa 0w92zeRI+VwkR67NBtMr9yWfXSR4tLr7lD6NyNIsaxoFNlWsx9Vz+5vQ6pR2b2oQ/PRc PVGhlOEA0sPvH8gN6Kxhaa5b7lY14ZguzRWXI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8YDPak26cV7NvwaJhnsTQuanfTOhuKDRKNVRIaBSzCg=; b=Q91bcQ1C+aO4HlaxYnhd2nDg9rt2nZY1QMPmRDUz24pV4hLavk3kUHF6JNt2k/LYWy rPzhaJVvgPdI6LHs+UrvJhwMJGws2cztDre0+WbLXzWwPLlpP2yolYYLMc13ZGB8NdwS isOx9ecvvdcyj98RCUcXN0yfQdY4wbVR5uROkDhqon1wi6wsodPMB+sFLze3bz365B+o qWQxM8lRJOY5irWe7SmiNjFaJMa/CiCq2e2VdJjw3ZSm1QTdvVGEyV6Q8X3eKhfy8h3M 4JTUUsKgZGhUJlbjFZGbLTcZWLdfp2K/lHYmIRZFXDh/pi2SgOOwJe8L6Rt/uBQufTvZ ut0Q== X-Gm-Message-State: AA+aEWa5eijJSNgWWLYi5RFyGq0UMrt6zb5rHoZHkVyOxZn9/PqsXrWm 0SPQqO+bpHsAG7fo95B7sWVL88rX8Z/qVzQiqt48MQ== X-Google-Smtp-Source: AFSGD/W+F7qv9DkEF7kbEf2OXXj7LcwCbvEc2gK0eckI7QmGnbUT2fQY1b3K6PTtPx8ddSKeWtk6//8w1IHZ2ixeuag= X-Received: by 2002:aca:6b03:: with SMTP id g3mr1039366oic.101.1545302639188; Thu, 20 Dec 2018 02:43:59 -0800 (PST) MIME-Version: 1.0 References: <1544514341-3176-1-git-send-email-sumit.garg@linaro.org> In-Reply-To: From: Ard Biesheuvel Date: Thu, 20 Dec 2018 11:43:48 +0100 Message-ID: To: Sumit Garg Cc: "edk2-devel@lists.01.org" , Daniel Thompson , Leif Lindholm Subject: Re: [PATCH edk2-platforms v1 1/1] Silicon/SynQuacer: add OP-TEE based RNG driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Dec 2018 10:44:00 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 18 Dec 2018 at 13:46, Ard Biesheuvel wrote: > > On Tue, 18 Dec 2018 at 13:17, Sumit Garg wrote: > > > > Hi Ard, > > > > On Wed, 12 Dec 2018 at 11:05, Sumit Garg wrote: > > > > > > On Tue, 11 Dec 2018 at 21:37, Ard Biesheuvel wrote: > > > > > > > > On Tue, 11 Dec 2018 at 10:06, Ard Biesheuvel wrote: > > > > > > > > > > On Tue, 11 Dec 2018 at 10:04, Sumit Garg wrote: > > > > > > > > > > > > On Tue, 11 Dec 2018 at 13:56, Ard Biesheuvel wrote: > > > > > > > > > > > > > > On Tue, 11 Dec 2018 at 08:46, Sumit Garg wrote: > > > > > > > > > > > > > > > > This driver uses OpteeLib to interface with OP-TEE based RNG service > > > > > > > > (pseudo trusted application) to implement EFI_RNG_PROTOCOL that is used > > > > > > > > to seed kernel entropy pool. > > > > > > > > > > > > > > > > Cc: Ard Biesheuvel > > > > > > > > Cc: Leif Lindholm > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > > > > > Signed-off-by: Sumit Garg > > > > > > > > > > > > > > Excellent! Happy to see this code going upstream. > > > > > > > > > > > > > > > > > > > Thanks Ard. > > > > > > > > > > > > > This code looks fine to me, but I'd like to test it with an updated > > > > > > > OP-TEE build first before I merge it. > > > > > > > > > > > > > > > > > > > Agree, will wait for OP-TEE PR to be merged. BTW, if you need I could > > > > > > share updated "fip_all_arm_tf.bin" using OP-TEE PR for testing. > > > > > > > > > > > > > > > > Yes please, that would be useful. > > > > > > > > > > > > > > > > > > OK, I successfully tested this patch on my SynQuacer box. Very nice work! > > > > > > > > > > Thanks Ard for testing this patch. > > > > > > > So this is ready to go in as soon as the OP-TEE side is merged as > > > > well, so please keep me informed about that (and contribute a new > > > > ARM-TF + OP-TEE build to edk2-non-osi) > > > > > > Sure will let you know about OP-TEE PR merge and yes will contribute a > > > new ARM-TF + OP-TEE build to edk2-non-osi. > > > > > > > OP-TEE PR [1] has been merged. Also I have sent a patch to contribute > > new ARM-TF + OP-TEE build. Please have a look. > > > > [1] https://github.com/OP-TEE/optee_os/pull/2564 > > > > Wonderful! Thanks a lot. Reviewed-by: Ard Biesheuvel Pushed as c955b5129771..dc6b5ef8a6c2