From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
"Leif Lindholm" <leif.lindholm@linaro.org>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
"Nadav Haklai" <nadavh@marvell.com>,
"Jan Dąbroś" <jsd@semihalf.com>,
"Grzegorz Jaszczyk" <jaz@semihalf.com>,
"Kostya Porotchkin" <kostap@marvell.com>,
"Jeremy Linton" <jeremy.linton@arm.com>,
"Jici Gao" <Jici.Gao@arm.com>
Subject: Re: [platforms: PATCH] Marvell/Armada7k8k: Remove UefiDecompressLib
Date: Thu, 11 Apr 2019 21:31:16 -0700 [thread overview]
Message-ID: <CAKv+Gu9MsbJi9=nsTwNJ9kHxuf-Z9TM7dAGLPM2dHULX16uXdA@mail.gmail.com> (raw)
In-Reply-To: <1555025344-5874-1-git-send-email-mw@semihalf.com>
On Thu, 11 Apr 2019 at 16:30, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Recent changes in EDK2 moved UefiDecompressLib from the
> IntelFrameworkModulePkg, breaking the compilation of
> Armada platforms. It turned out it is not needed, so fix it by
> safely removing references to the problematic library.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Pushed as 11c98f35af40..dc31a7feb81a
Thanks!
> ---
> Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 1e2d248..8291582 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -203,13 +203,11 @@
> DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
>
> [LibraryClasses.common.UEFI_APPLICATION]
> - UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
> [LibraryClasses.common.UEFI_DRIVER]
> - UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
> ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
> PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
> MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> --
> 2.7.4
>
prev parent reply other threads:[~2019-04-12 4:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 23:29 [platforms: PATCH] Marvell/Armada7k8k: Remove UefiDecompressLib Marcin Wojtas
2019-04-12 4:31 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9MsbJi9=nsTwNJ9kHxuf-Z9TM7dAGLPM2dHULX16uXdA@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox