From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=DfMhjzzF;
 spf=pass (domain: linaro.org, ip: 209.85.166.195, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f195.google.com (mail-it1-f195.google.com [209.85.166.195])
 by groups.io with SMTP; Thu, 11 Apr 2019 21:31:27 -0700
Received: by mail-it1-f195.google.com with SMTP id u65so13442463itc.2
        for <devel@edk2.groups.io>; Thu, 11 Apr 2019 21:31:27 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=owhj+o84QgyHs8d8ymQpibMxXSmSNPmyAKI4HHIF6F4=;
        b=DfMhjzzFdywj5Ps1pMWFLm8mkNJhvXqhZs8f51AX4HkQAqXJ0T9MvNKJBhmbxcbA+p
         G8s8JSOjsb5N82QtuDfP/wiVqvOKuLMU4z4F0qpbD3p/ic1QTfbdIcqecywqx6tsUK8C
         k4aXQ6vkbQg+DXJ6y8yLrejGwTOu+p/y44Tby5eK4r9lgqS/EDOVyu4BWcL+wBcovNK7
         jadmG5DrlwKpzorcuOulZ7/UlhxjvxCaPEKtLEFQi6D7gLmG1l2LU0WQQjmDUlgID/6v
         BmZDxKuhgqDahwxw27pgNWaEbI5eLbua8CN9qK2MEbr62AdPHBuGFaJffNjMT24no7IG
         yWYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=owhj+o84QgyHs8d8ymQpibMxXSmSNPmyAKI4HHIF6F4=;
        b=NZdYF+UYDrI/I6dnyNaG4c3wVmhzbDzKyrLT3z2FyTvSYZ8v/Irvsgp3FyNXfkzRmf
         N8jevJq1+KHDDodC3lriIMzg013MvltcGKW5TXXqjoCOCMrCtKV2XxiimgMY909Eu5vk
         WVyy1makBTlFQov35iD3UoJ0TfhNBqVv6mLnOnP318DSi9xbT3DFyk17ab/PRrzvecXQ
         s1TI+cCJeRk0oAYNwRtY/fpdPsn5rLSE57voHS1kOFwp6FuwquRFyNTpCEk7Le1EP8hn
         UvOPhQPqv/nPw0Rhdp22gWiPnB97WEfcE/xfok2wVA+1pxCsBIye3FVll5a9bVOFHHCo
         pj6g==
X-Gm-Message-State: APjAAAWsHOjLzyIXwPZJw84Gysl6xz4hvrhMOIGZLcw53hkR2JxX5S7T
	sgv0Wi1A3hrEnHTyr3VZQx/IDBijvUs7qEY7YoU56w==
X-Google-Smtp-Source: APXvYqyk71kf5KagostKZEhOiLZZbBVzZ+4oNzcnhQeZ/NPNv4IIAiFwjL5zIGojp1/ypzKNYPQuWCylJzpty3fEmIs=
X-Received: by 2002:a05:660c:2c5:: with SMTP id j5mr11104637itd.154.1555043486860;
 Thu, 11 Apr 2019 21:31:26 -0700 (PDT)
MIME-Version: 1.0
References: <1555025344-5874-1-git-send-email-mw@semihalf.com>
In-Reply-To: <1555025344-5874-1-git-send-email-mw@semihalf.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Thu, 11 Apr 2019 21:31:16 -0700
Message-ID: <CAKv+Gu9MsbJi9=nsTwNJ9kHxuf-Z9TM7dAGLPM2dHULX16uXdA@mail.gmail.com>
Subject: Re: [platforms: PATCH] Marvell/Armada7k8k: Remove UefiDecompressLib
To: Marcin Wojtas <mw@semihalf.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif.lindholm@linaro.org>, 
	Ard Biesheuvel <ard.biesheuvel@linaro.org>, Nadav Haklai <nadavh@marvell.com>, 
	=?UTF-8?B?SmFuIETEhWJyb8Wb?= <jsd@semihalf.com>, 
	Grzegorz Jaszczyk <jaz@semihalf.com>, Kostya Porotchkin <kostap@marvell.com>, 
	Jeremy Linton <jeremy.linton@arm.com>, Jici Gao <Jici.Gao@arm.com>
Content-Type: text/plain; charset="UTF-8"

On Thu, 11 Apr 2019 at 16:30, Marcin Wojtas <mw@semihalf.com> wrote:
>
> Recent changes in EDK2 moved UefiDecompressLib from the
> IntelFrameworkModulePkg, breaking the compilation of
> Armada platforms. It turned out it is not needed, so fix it by
> safely removing references to the problematic library.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Marcin Wojtas <mw@semihalf.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Pushed as 11c98f35af40..dc31a7feb81a

Thanks!

> ---
>  Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> index 1e2d248..8291582 100644
> --- a/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> +++ b/Silicon/Marvell/Armada7k8k/Armada7k8k.dsc.inc
> @@ -203,13 +203,11 @@
>    DtPlatformDtbLoaderLib|EmbeddedPkg/Library/DxeDtPlatformDtbLoaderLibDefault/DxeDtPlatformDtbLoaderLibDefault.inf
>
>  [LibraryClasses.common.UEFI_APPLICATION]
> -  UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
>    PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
>    MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
>    HiiLib|MdeModulePkg/Library/UefiHiiLib/UefiHiiLib.inf
>
>  [LibraryClasses.common.UEFI_DRIVER]
> -  UefiDecompressLib|IntelFrameworkModulePkg/Library/BaseUefiTianoCustomDecompressLib/BaseUefiTianoCustomDecompressLib.inf
>    ExtractGuidedSectionLib|MdePkg/Library/DxeExtractGuidedSectionLib/DxeExtractGuidedSectionLib.inf
>    PerformanceLib|MdeModulePkg/Library/DxePerformanceLib/DxePerformanceLib.inf
>    MemoryAllocationLib|MdePkg/Library/UefiMemoryAllocationLib/UefiMemoryAllocationLib.inf
> --
> 2.7.4
>