From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=YZWPbFbt; spf=pass (domain: linaro.org, ip: 209.85.166.67, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-io1-f67.google.com (mail-io1-f67.google.com [209.85.166.67]) by groups.io with SMTP; Fri, 31 May 2019 02:12:23 -0700 Received: by mail-io1-f67.google.com with SMTP id u13so7600443iop.0 for ; Fri, 31 May 2019 02:12:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pwzUBK1ZhGE8p2xc5CDCSU5yamQbYZ6DCRglQ6Ev/bE=; b=YZWPbFbtG5cHT4zIMBWdjwIHu2QDyyexC86qZhuROL0wgSEOQgxirB8x13Q2GpP8tY y7SKLeO8JGDrG/6lW4cfL3sKQiaxYoJeL4A/K5dbzjJP+a8KKMGIGa+6oKyJdroUjP/L iXM2v4m6b+J75vSlA06GeYmGg3Ql7SKw+BBGH07bQf8SIUVNVDUA56TmPVeIWeZ7lP55 kdxmiVqKlwPoH1scmhSbOVp9zgdDmcCvAbLlrb5RIxPEuZ4mh7u6H7IxWEQOwWcRzChC Q6mrBdAOd0NQk1p+RJgMQ4rKRRUHiEuWnEa6YMqXTxh6vtK4OXOgsmc80Zg+8jcqEQ3H t4Fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pwzUBK1ZhGE8p2xc5CDCSU5yamQbYZ6DCRglQ6Ev/bE=; b=XY5AnT53kTrbRK0FFljyGMHYczf7n5d4beWrXoXEMj4C8l88Ga1ITOIHrr30tnU8Xy 4jSPcsS7zJ3lNHkC20emrVZhjJOqwzNkqwMKWm/SoaTQRmWrFNVTObZcYiV6STYXYEUq 62EetN8cKR5yyK7n7JOYajWA0XwAAO2yckhCmYSJzgz0TOhP1PRgFmB28jSBObKr8aff WDUtCnYdwFuSCTiCVzSQYw/FwEXmmaYKUee4h2mcR34GVrYshE3TRytmmkRyQq2waG0N PC5xJafsK7YUiWs1EyY9KRM+WV8Yhf1ixl9D8LFJKGUEScr5Rm5BqF+8Nbk9ZxB/r1rx X8Yw== X-Gm-Message-State: APjAAAVdcEt1io0731Y5FJWlPByhr0obHJBuvUCgOs+3qCD0dNfiXY6Y cNlNeHh4FNIPFLi+1miIXzNK8F+cRsfaSv533EcI6SmM2qroBQ== X-Google-Smtp-Source: APXvYqwnve10y/NgR9cqI+QZdYCyJT+gg0hX4AjNM1sJqDpb2bw5KUppYtKF+7ab6+dSiLWwnu6v94dXXaxrV6aX2fg= X-Received: by 2002:a5d:9d83:: with SMTP id 3mr5465504ion.65.1559293942143; Fri, 31 May 2019 02:12:22 -0700 (PDT) MIME-Version: 1.0 References: <20190529113723.23186-1-anthony.perard@citrix.com> In-Reply-To: <20190529113723.23186-1-anthony.perard@citrix.com> From: "Ard Biesheuvel" Date: Fri, 31 May 2019 11:12:09 +0200 Message-ID: Subject: Re: [edk2-devel] [PATCH 0/4] Define SERIAL_DXE_FILE_GUID only once To: edk2-devel-groups-io , Anthony PERARD Cc: Jian J Wang , Ray Ni , Star Zeng , Hao A Wu , Julien Grall , Leif Lindholm , Laszlo Ersek Content-Type: text/plain; charset="UTF-8" On Wed, 29 May 2019 at 13:37, Anthony PERARD wrote: > > The macro SERIAL_DXE_FILE_GUID is already been defined twice and the GUID is > been used once without defining the macro. This patch series define the macro > in MdeModulePkg where the SerialDxe is, and replace all other use by this new > one. > > Note that I haven't build/test those changes, but I have test the first patch > by applying a similar change to a patch series I'm working on. > > Patch series available in this git branch: > https://xenbits.xen.org/git-http/people/aperard/ovmf.git br.serial-dxe-guid-v1 > > Anthony PERARD (4): > MdeModulePkg: Add SERIAL_DXE_FILE_GUID > ArmVirtPkg/PlatformBootManagerLib: Use SERIAL_DXE_FILE_GUID from > MdeModulePkg > ArmPkg/PlatformBootManagerLib: Use SERIAL_DXE_FILE_GUID from > MdeModulePkg > UefiPayloadPkg/PlatformBootManagerLib: Use SERIAL_DXE_FILE_GUID from > MdeModulePkg > > MdeModulePkg/MdeModulePkg.dec | 3 +++ > MdeModulePkg/Include/Guid/SerialDxe.h | 19 +++++++++++++++++++ > .../PlatformBootManagerLib/PlatformBm.c | 6 +----- > .../PlatformBootManagerLib/PlatformBm.c | 6 +----- > .../PlatformBootManagerLib/PlatformConsole.c | 3 ++- > 5 files changed, 26 insertions(+), 11 deletions(-) > create mode 100644 MdeModulePkg/Include/Guid/SerialDxe.h > Hello Anthony, If the MdeModulePkg maintainers are ok with this, then I'm fine with it as well. I would like to suggest to include a patch that does diff --git a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf index 81066a26a278..761c2e6649de 100644 --- a/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf +++ b/MdeModulePkg/Universal/SerialDxe/SerialDxe.inf @@ -11,7 +11,7 @@ INF_VERSION = 0x00010005 BASE_NAME = SerialDxe MODULE_UNI_FILE = SerialDxe.uni - FILE_GUID = D3987D4B-971A-435F-8CAF-4967EB627241 + FILE_GUID = D3987D4B-971A-435F-8CAF-4967EB627241 # SERIAL_DXE_FILE_GUID MODULE_TYPE = DXE_DRIVER VERSION_STRING = 1.0 so that it is clear for future users that there is a symbolic GUID constant they can use.