From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 88F0921A00AC2 for ; Mon, 3 Jul 2017 10:30:14 -0700 (PDT) Received: by mail-it0-x22e.google.com with SMTP id m68so90966595ith.1 for ; Mon, 03 Jul 2017 10:31:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=OoCf8g9cR+lhPtDKBzSI6c4Wc/jOcUEQqyZjWMWiVZ0=; b=SoHRrG47y5qY5NClHuyidiiQrSWayutwy3S3dUg57eFPWw0V+7MPVflrsUeFaPA4dm uG36LW9SrFL869urO66qy9cERskA9HM3DN4JbHSAOL1O7Wl3hHMBd8y5a3aoAiA4ZG1c 95spdZNNdSzLeIETn6iNkErB4DdbLS1rchJ7c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=OoCf8g9cR+lhPtDKBzSI6c4Wc/jOcUEQqyZjWMWiVZ0=; b=uF8HpSP7xNgb5vCwPdE6EToRdFTMc9G7W47H/jpA9mhQzJ3YK1l1sfhQZqp+SjJAv+ n06ua+KB5epNyOLHf/eGZ+dKyQ/5FVV/Xvswr8/Oe7xhI3eRgf7dr4jzv02D+NO/z/Y/ 4xBNmG3046OURWGWDGIUDptVHM0DxOW6Tn42sfHbht6Qqmw0dPH959s9hvJFHdByfJEj 0N42WUWTvMwugiv5aLY+nL20AleADpUdkF3F+zgrAmwZ3WFf54RQIIFIioGlY0yX+KMR Oy8fxmM3Nrp5bLruGCYZAxXf9paTZ27DzVlqDT0y0421QFqDoVzfRgc+Su1wnFPa5aMR SR1Q== X-Gm-Message-State: AKS2vOxEDoAqpqiQIJtQX+MsfZpmvGEO45bKmEG91B61Z7ATf8lQXTQU l4e3Hky5cYgfNq1u2+vAr9ZMlENH2+Jv X-Received: by 10.36.67.9 with SMTP id s9mr29334182itb.6.1499103111243; Mon, 03 Jul 2017 10:31:51 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.134.134 with HTTP; Mon, 3 Jul 2017 10:31:50 -0700 (PDT) In-Reply-To: <446b5575-b2f8-52d0-a372-2b2c8990dc8b@redhat.com> References: <20170629083221.485184-1-ruiyu.ni@intel.com> <60ac3e5e-12b6-4bd5-6f7f-a7101b7c7edb@redhat.com> <20170703120943.GD26676@bivouac.eciton.net> <446b5575-b2f8-52d0-a372-2b2c8990dc8b@redhat.com> From: Ard Biesheuvel Date: Mon, 3 Jul 2017 18:31:50 +0100 Message-ID: To: Laszlo Ersek Cc: Leif Lindholm , Ruiyu Ni , "edk2-devel@lists.01.org" , Hao Wu , "Jordan Justen (Intel address)" , Andrew Fish Subject: Re: [PATCH 0/3] MdeModulePkg/ResetSystem: Implement ResetNotification protocol X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 03 Jul 2017 17:30:14 -0000 Content-Type: text/plain; charset="UTF-8" On 3 July 2017 at 18:30, Laszlo Ersek wrote: > On 07/03/17 14:09, Leif Lindholm wrote: >> On Sat, Jul 01, 2017 at 11:04:08PM +0200, Laszlo Ersek wrote: >>> Ard, Leif, >>> >>> On 06/29/17 10:32, Ruiyu Ni wrote: >>>> Ruiyu Ni (3): >>>> MdePkg: Add ResetNotification protocol definition >>>> MdeModulePkg/ResetSystem: Remove unnecessary global variable >>>> MdeModulePkg/ResetSystem: Implement ResetNotification protocol >>>> >>>> .../Universal/ResetSystemRuntimeDxe/ResetSystem.c | 146 +++++++++++++++++++-- >>>> .../Universal/ResetSystemRuntimeDxe/ResetSystem.h | 21 ++- >>>> .../ResetSystemRuntimeDxe.inf | 5 +- >>>> MdePkg/Include/Protocol/ResetNotification.h | 86 ++++++++++++ >>>> MdePkg/MdePkg.dec | 3 + >>>> 5 files changed, 247 insertions(+), 14 deletions(-) >>>> create mode 100644 MdePkg/Include/Protocol/ResetNotification.h >>>> >>> >>> I think we should >>> - either port this feature (patch 3/3) to EmbeddedPkg/ResetRuntimeDxe, >>> - or else rebase all platforms that consume EmbeddedPkg/ResetRuntimeDxe >>> to MdeModulePkg/Universal/ResetSystemRuntimeDxe, and delete >>> EmbeddedPkg/ResetRuntimeDxe from the tree. >>> >>> What do you guys think? >> >> I think deleting the EmbeddedPkg one, and making the current consumers >> implement ResetSystemLib instead of EfiResetSystemLib would be an >> improvement. > > Looks like you and Ard agree this is the best way forward. (I also > agree, I just wasn't sure if it would be your shared preference, due to > the conversion of dependent platforms possibly needing a lot of work.) > > Ard, do you want me to file a BZ for the ArmVirtPkg conversion? (I can't > volunteer to actually do the conversion right now; my plate is full.) > I already sent the patch a couple of hours ago, but if we need a BZ entry as well [for documentation purposes], please go ahead and file one.