From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::229; helo=mail-it0-x229.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 64F162222C227 for ; Sat, 27 Jan 2018 02:31:31 -0800 (PST) Received: by mail-it0-x229.google.com with SMTP id 68so4379483ite.4 for ; Sat, 27 Jan 2018 02:37:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=k5+j4+As2D0YwRzKAU06ns8oTjg26TUDxwwdHEyyvfI=; b=d7BFpje2MKJoZjgQolWTpogAaxL+ckGGfVJSSZxXE5NuoGODQXGrMPPAEsbiLUcWIG 0I62v27YLXziVN0m60hgGmKpN/avonl3vxGaCtHVvPfXz+KZjAKywuJEmOzauEcLmfQr /r8RBXUDgaqypvXfRUKsLdRYsNO0sOtlRkrTY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=k5+j4+As2D0YwRzKAU06ns8oTjg26TUDxwwdHEyyvfI=; b=l3xiBzKNQC6KGYF/Px8JDJCSMA/WIWQ2cx7G46eyReFazuCTptnz4CVVPI22O3kyEM fSUG04DmOTt4BOvBIokTWPdJcTvOQzrvejuaEy8lQF2rTCh+wE0hdkuka/A+Sia1G6by Rd+dkAD/hOdP6dxIf5oEKQBw5O3AC6htMPAuFgLew9ekwILVIq1sNvl9x1pPv7cPhMbL tscxMCove4t8bmftwDoXXuN5N9VdIRiOWWAYFX9ZVhSVPWCBLSPW+A3eT08/khjNtdoJ nHtmpvcfjr0pBu1DAdnOb4UaBRgDPhMnjWdOuC47bULxphS0DZhYHz6StXYnYDshhkt7 wsjw== X-Gm-Message-State: AKwxytcbBEXyBYWfwHErdS7VTgkXAqLsn/nTfNYr749iapmIgSDuJGa0 AF4KiVXxy8juxCrn3cHwvbhuyixdlfZmNHYryN98tQ== X-Google-Smtp-Source: AH8x2256Pqb/hfMHdv1ZZunqdZLeM95UARhNkYNs5y5AmbtchWLZWxhxjywWqXqdR3onM04Z8BM4XyevcTNGae9sig8= X-Received: by 10.36.228.200 with SMTP id o191mr1808339ith.143.1517049422474; Sat, 27 Jan 2018 02:37:02 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Sat, 27 Jan 2018 02:37:01 -0800 (PST) In-Reply-To: <2ced3021-fd0e-7551-c476-4468c915f82e@huawei.com> References: <1516287703-35516-1-git-send-email-huangming23@huawei.com> <1516287703-35516-14-git-send-email-huangming23@huawei.com> <20180123102320.7rloxdthhq2njbvu@bivouac.eciton.net> <2ced3021-fd0e-7551-c476-4468c915f82e@huawei.com> From: Ard Biesheuvel Date: Sat, 27 Jan 2018 10:37:01 +0000 Message-ID: To: "Huangming (Mark)" Cc: Leif Lindholm , Ming Huang , linaro-uefi , "edk2-devel@lists.01.org" , Graeme Gregory , guoheyi@huawei.com, wanghuiqiang , Jason Zhang , Mengfanrong , waip23@126.com Subject: Re: [PATCH edk2-platforms v1 13/14] Hisilicon/Library: Add OsBootLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 27 Jan 2018 10:31:32 -0000 Content-Type: text/plain; charset="UTF-8" On 27 January 2018 at 01:47, Huangming (Mark) wrote: > > > On 2018/1/23 18:23, Leif Lindholm wrote: >> On Thu, Jan 18, 2018 at 11:01:42PM +0800, Ming Huang wrote: >>> OsBootLib can create OS option after upgrade firmware. >> >> I will respond more strongly that Ard did: >> >> I have seen functionality like this implemented in publicly available >> systems - laptops, desktops. >> Without exception, they end up in bug reports saying "my system >> refuses to boot after installation/upgrade". >> Without exception, they add to existing negative perceptions of UEFI >> in general in certain market spaces. >> >> Presumably this is trying to address a real problem you have faced. >> Please bring this issue to the table for discussion, so that we can >> agree on an appropriate way of resolving it. >> >> Regardless, this code will not be included in 18.02. >> >> / >> Leif >> >> . >> > > The problem is that OS boot option is lost after upgrade firmware. Why is that? There is no need to clear the variable store if you upgrade the executable image. If you fix this issue, you don't need this patch. > It is inconvenient for using. OsBootLib can help this. > > OsBootLib retain the options installed by OS, and create OS boot option > after upgrade firmware if grub file is existed in EFI partition and in mUefiOsBootFiles, > and delete redundant options in the same GPT. >