From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::235; helo=mail-it0-x235.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id BCCDF225E964F for ; Tue, 20 Mar 2018 18:35:39 -0700 (PDT) Received: by mail-it0-x235.google.com with SMTP id k79-v6so4827305ita.2 for ; Tue, 20 Mar 2018 18:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=jF9JUfHl9HD/OJY8w/0vUfOR3BFGG+g5AOKrP7DfDUg=; b=UPNZe5e403utvfWup+ZyiBEOsMeb6HdSTuDVj60fuBWzoGVgrZRe63vBGSE0GzJeBg pBKudFxW3SOZPcHPYEe4MCreeEAGKe7W05uP5KENFQ3YJJsg76Osx6geCdd6z2g4W3lg xt4XvizK13Qsbt72Q2cRoehVddrE7kFSK5KOo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=jF9JUfHl9HD/OJY8w/0vUfOR3BFGG+g5AOKrP7DfDUg=; b=bf9g2FcwsD8blsFnbx/8/3cOTFYQviqbj5E0p2bLyc/+fQ2R4DXwnRrI11DY0nk6PH l595h/MCbaPyAB9OpEBehX9pcQDKCkLf7IGnFZZsal+NHSTXdHK/1fHoTJ1iCsxMX4re s2wSH0yngikohqAkX/VyUaa83W35FrlUiOnJFY/Uee22MsKGt+a3zJ230CY4xrhClQME rQxF+5F+6SRPlWsKUhM92RqCKia2RPlMQDbqtmsJLoPojB70XfcvYzvrStJngLS5CnL5 mMy6fUhMvzmLLJBTsvM9hmSHzrOeXrucJiS/rQtpUCbgQUhssui+TrP51+Dst4Pl+J0T MAHg== X-Gm-Message-State: AElRT7HLHgHlpSSZtIIhTWu+qZxArzZEDWzr1hnonWMTJU9uT23ny2g1 tIEnVAQLYs8GQYXKP3A3y0FtFl45ZPbM6AY3RVSMYgpL X-Google-Smtp-Source: AG47ELsZ+43xLvzi+uhFNn/cimsdXVFon32dEAtz0zPBeklyzU/3miu3fEiyXLosBezR/WcmfBFq7rY/zGHLU68vwyY= X-Received: by 2002:a24:d98d:: with SMTP id p135-v6mr2189580itg.106.1521596528745; Tue, 20 Mar 2018 18:42:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.187.67 with HTTP; Tue, 20 Mar 2018 18:42:08 -0700 (PDT) In-Reply-To: <20180308162602.28152-1-sami.mujawar@arm.com> References: <20180308162602.28152-1-sami.mujawar@arm.com> From: Ard Biesheuvel Date: Wed, 21 Mar 2018 09:42:08 +0800 Message-ID: To: Sami Mujawar Cc: "edk2-devel@lists.01.org" , Ruiyu Ni , Leif Lindholm , Stephanie.Hughes-Fitt@arm.com, "Yao, Jiewen" , "Carsey, Jaben" , nd Subject: Re: [PATCH v5] ShellPkg: Add acpiview tool to dump ACPI tables X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 01:35:40 -0000 Content-Type: text/plain; charset="UTF-8" On 9 March 2018 at 00:26, Sami Mujawar wrote: > This program is provided to allow examination of ACPI table contents > from the UEFI Shell. This can help with investigations, especially at > that stage where the tables are not enabling an OS to boot. > The program is not exhaustive, and only encapsulates detailed knowledge > of a limited number of table types. > > Default behaviour is to display the content of all tables installed. > 'Known' table types will be parsed and displayed with descriptions and > field values. Where appropriate a degree of consistency checking is > done and errors may be reported in the output. > Other table types will be displayed as an array of Hexadecimal bytes. > > To facilitate debugging, the -s and -d options can be used to generate a > binary file image of a table that can be copied elsewhere for > investigation using tools such as those provided by acpica.org. This is > especially relevant for AML type tables like DSDT and SSDT. > > The inspiration for this is the existing smbiosview Debug1 Shell > command. > > Many tables are not explicitly handled, in part because no examples are > available for our testing. > > The program is designed to be extended to new tables with minimal > effort, and contributions are invited. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > Signed-off-by: Evan Lloyd > Reviewed-by: Jaben Carsey Tested-by: Ard Biesheuvel Thanks for contributing this, it is really very useful. One nit: the MADT table is listed as 'APIC' which i think is incorrect, i.e,. we should refer to the tables by their official names rather than by the character sequences used as their signatures.