From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::12e; helo=mail-it1-x12e.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x12e.google.com (mail-it1-x12e.google.com [IPv6:2607:f8b0:4864:20::12e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AE70E21163247 for ; Sat, 13 Oct 2018 10:04:45 -0700 (PDT) Received: by mail-it1-x12e.google.com with SMTP id l191-v6so23185902ita.4 for ; Sat, 13 Oct 2018 10:04:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7O1xQZTTa2iVyWojAcISnynvprPyYA3eHzJCeORhYLU=; b=c1AoJPa3ld3f+gvHnlmp5zR/GN27DOpqheY3UZLlOUXfyGPauwt5OPDDDm6P8aIvYh LbWKBd8poHOw3GupvtTDD8g5qmT9YTXVHM70KNB47RKP9Xtf+ZQz0EVy8JZmT2JUIkTt aCRI8jMNl69xVC3UPIKknX3zsIWbBST1ZTEsI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7O1xQZTTa2iVyWojAcISnynvprPyYA3eHzJCeORhYLU=; b=E1rjquJKr4j3d8F/iKE9dg6Ljl5D3hFoBoAwUiSTVigYFklzskaDKJefEaOyJBF+fS mpeLOtB8KEqqHIHF/VkLrBEZUQhTQQM65JM6PaYdEL/JMdJXZPXy0UN2yPF0C5OsKFov T+QPFnWd20WYz4Fh1lrSR/dYPtiJINpbohrWiR3ha6p1K5fjhx6WEknCd2Ry5DLASvs6 Q5S6WxRgQQncHBmSBKjJPZz//JeCtSwZ76G/vHxTxOjPtlsyOYqDw78puJczmAHSkPGv 1sSZKhFJtHUkJCsTTENZ9Au4LpDolGPNHgxsduLFxi9+pEd4+zxqTNkBjxcoUSQbuiuO ZigA== X-Gm-Message-State: ABuFfogCtlXa6J+OzL0tJMa96yIdLHFM54d+QaOT60FHfoXvqcnghqnT AEIDD2MzH+TOAFhq1oHsAMAn0RTdh7XIRP8oTFfAkg== X-Google-Smtp-Source: ACcGV62lvgMfHqSb1PWJgNU6E6MAJxUYZKAsLuBbatSNXF2i6wDnKLXfozkanFvUnLJE/7gK2E4Wc81dh41I50p/UbQ= X-Received: by 2002:a02:5147:: with SMTP id s68-v6mr8090093jaa.62.1539450284452; Sat, 13 Oct 2018 10:04:44 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:5910:0:0:0:0:0 with HTTP; Sat, 13 Oct 2018 10:04:43 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E339A58@SHSMSX104.ccr.corp.intel.com> References: <1539448768-12816-1-git-send-email-yonghong.zhu@intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E339A58@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Sat, 13 Oct 2018 19:04:43 +0200 Message-ID: To: "Gao, Liming" Cc: "Zhu, Yonghong" , Andrew Fish , "edk2-devel@lists.01.org" Subject: Re: [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 17:04:45 -0000 Content-Type: text/plain; charset="UTF-8" On 13 October 2018 at 19:03, Gao, Liming wrote: > Ard: > Do you verify BaseTools with Python35 or Python36? > Python 3.5.3 (default, Sep 27 2018, 17:25:39) [GCC 6.3.0 20170516] on linux >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard Biesheuvel >> Sent: Sunday, October 14, 2018 12:52 AM >> To: Zhu, Yonghong ; Andrew Fish >> Cc: edk2-devel@lists.01.org >> Subject: Re: [edk2] [Patch] BaseTools: Remove the logic that check Python3 version larger than 3.6 >> >> On 13 October 2018 at 18:39, Yonghong Zhu wrote: >> > Remove the logic that the Python3 version must larger than 3.6. >> > We verified Python3 migration patches on version 3.6 and 3.7. >> > for other version we not verified it. >> > >> > Cc: Ard Biesheuvel >> > Cc: Leif Lindholm >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Yonghong Zhu >> >> I will note that this does not solve Andrew's problem, but nonetheless: >> >> Reviewed-by: Ard Biesheuvel >> Tested-by: Ard Biesheuvel >> >> > --- >> > BaseTools/toolsetup.bat | 7 ------- >> > edksetup.sh | 4 ++-- >> > 2 files changed, 2 insertions(+), 9 deletions(-) >> > >> > diff --git a/BaseTools/toolsetup.bat b/BaseTools/toolsetup.bat >> > index 0d4028d..d585431 100755 >> > --- a/BaseTools/toolsetup.bat >> > +++ b/BaseTools/toolsetup.bat >> > @@ -314,17 +314,10 @@ set PYTHON3=py -3 >> > echo. >> > echo !!! ERROR !!! %PYTHON3% not install. >> > echo. >> > goto end >> > ) >> > - FOR /F "TOKENS=1,2" %%i IN ('%PYTHON3% --version') DO set VERSION=%%j >> > - if /I "%VERSION%" LSS "3.6" ( >> > - echo. >> > - echo !!! ERROR !!! python version should greater than or equal to version 3.6. >> > - echo. >> > - goto end >> > - ) >> > >> > :check_freezer_path >> > @REM We have Python, now test for FreezePython application >> > if not defined PYTHON_FREEZER_PATH ( >> > echo. >> > diff --git a/edksetup.sh b/edksetup.sh >> > index d4e577e..84b3e63 100755 >> > --- a/edksetup.sh >> > +++ b/edksetup.sh >> > @@ -129,13 +129,13 @@ function SetupPython3() >> > if [ "$ret" -eq 1 ]; then >> > origin_version=$python_version >> > export PYTHON3=$python >> > fi >> > done >> > - if [ -z "$origin_version" ] || [ `echo "$origin_version < 3.6" |bc` -eq 1 ]; then >> > + if [ -z "$origin_version" ]; then >> > echo >> > - echo ERROR!!!, python version should greater than or equal to version 3.6. >> > + echo ERROR!!!, Please install a Python 3 Tool. >> > echo >> > return 1 >> > fi >> > >> > >> > -- >> > 2.6.1.windows.1 >> > >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel