From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by mx.groups.io with SMTP id smtpd.web09.1559.1579040164964626336 for ; Tue, 14 Jan 2020 14:16:05 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=LsXPsghO; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f68.google.com with SMTP id g17so13795027wro.2 for ; Tue, 14 Jan 2020 14:16:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=WcC8rfsvo7F9C6oJNBKSZK+DnecaVCi4SnSOu7TabAE=; b=LsXPsghOf1gzIdyHBcpbEv0DZilv5OfktLOuxLqK/kivTl2xPyHde+9RvKB4t6GjUp 8NILxFKTuv4qtZR9q6aA7IuBTV4DDUu5KNNfK+w6IqRBSbf51zmM25MFSnSj5jMc+m6s jduzUmrt3BnW6I4vaK3zaADPLvOy9/Nuc462LV5hMXSP0eixUwY7UkrVMDlJoHorynJC Wu80FRUTMwneF8u59OFWI4a8T/8VlIP4MLJjZ1z7K5myMPPDofTLOnzUKhNK3UYuCcUu YcDY8UCMgiRFC6eUY+IWhdc1YGgT7AFS9vsH7MbnAiF0gk72XOr5s46L4nogff8KT5i9 kmvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=WcC8rfsvo7F9C6oJNBKSZK+DnecaVCi4SnSOu7TabAE=; b=Hp698fWDMW0wb3HsCsQCqD6+XXafqT4rArx5SAL5fKcHIrqeMOBtHcsfIURPLlqfyn kEjm5ris9dDyNbfUzYJV7Bs6m/GWX1YEKx9UpLct8ACpnDSVUd8KfsCQT0skotN3c8Ok PzAODArt4kPqSoIBJNyaf22PX7lWKUceBZATnsqyJ401e9VJxvRb1u9dDSQ5juL8R0rN q4R/gq1q3perSSYqy4YcTAHhp2ewLfbqMkYcRVbGpkxvxozJr2dGmu83dSiPD+VQdVtV yX/sMC0IsYsIrCpQyUUJmFW5GsGg1XmzP5ERl8vHyB01lTaeMaO8W74p5TT9fMlS34cT GzXA== X-Gm-Message-State: APjAAAXR34IjJcMeKF19yzEUA9k8tALziNWkAtrplzBkRp2XWbJZ2qYo YdmNfNnIqlCaN3WaYcGmwbG8Fu69WSq2UYtjeVivFW2Tmpg= X-Google-Smtp-Source: APXvYqy3lDCEttBa6KfK6KXqel/eNpPGVP+Bg1C0aEu/i916i3j7XE6biEZ0B1kTaOjq3tS/OUaqEdnqSbOPcn+JeT8= X-Received: by 2002:a5d:43c7:: with SMTP id v7mr26070851wrr.32.1579040163000; Tue, 14 Jan 2020 14:16:03 -0800 (PST) MIME-Version: 1.0 References: <20200107092215.3271-1-ard.biesheuvel@linaro.org> In-Reply-To: From: "Ard Biesheuvel" Date: Tue, 14 Jan 2020 23:15:51 +0100 Message-ID: Subject: Re: [PATCH 0/2] some ARM fixes To: edk2-devel-groups-io , leif@nuviainc.com Content-Type: text/plain; charset="UTF-8" On Tue, 14 Jan 2020 at 17:43, Ard Biesheuvel wrote: > > On Tue, 7 Jan 2020 at 10:22, Ard Biesheuvel wrote: > > > > Some preparatory fixes for TPM measured boot on ARM systems. > > > > Patch #1 removes EnterS3WithImmediateWake() with the associated support > > code from ArmSmcPsciResetSystemLib. EnterS3WithImmediateWake () is no > > longer being called anywhere, and will be removed from ResetSystemLib, > > and the support code dependencies on DXE facilities are preventing this > > library from being used in the PEI phase, which is needed for TPM support. > > > > Patch #2 adds the missing call to enable VFP on PrePeiCore based platforms. > > This is causing TPM crypto code to blow up. > > > > Ard Biesheuvel (2): > > ArmPkg/ArmSmcPsciResetSystemLib: remove EnterS3WithImmediateWake () > > ArmPlatformPkg/PrePeiCore: enable VFP at startup > > > > Ping? > Merged, thanks. > > > ArmPkg/ArmPkg.dec | 4 -- > > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf | 17 ----- > > ArmPlatformPkg/PrePeiCore/PrePeiCoreMPCore.inf | 1 + > > ArmPlatformPkg/PrePeiCore/PrePeiCoreUniCore.inf | 1 + > > ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.c | 66 +------------------- > > ArmPlatformPkg/PrePeiCore/PrePeiCore.c | 5 ++ > > ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S | 24 ------- > > ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm | 29 --------- > > ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S | 23 ------- > > ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm | 28 --------- > > 10 files changed, 9 insertions(+), 189 deletions(-) > > delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.S > > delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/AArch64/Reset.asm > > delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.S > > delete mode 100644 ArmPkg/Library/ArmSmcPsciResetSystemLib/Arm/Reset.asm > > > > -- > > 2.20.1 > >