Re: [PATCH] Pkg-Module: ArmPkg Fix Mmu Initialization Problem.

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 26 September 2016 at 08:36, Kurt Kennett <Kurt.Kennett@microsoft.com> wrote:
> During Mmu initialization in the CpuDxe, for a page table any bits set in
> the 'NextSectionAttributes' are garbage and were set from bits that are
> actually part of the pagetable address.  We clear it out to zero so that the
> SyncCacheConfigPage will use the page attributes instead of trying to
> convert the (bogus) section attributes into page attributes
>
>
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
>
>
> Signed-off-by: Kurt Kennett <kurt.kennett@microsoft.com>
>

Hello Kurt,

This is looking a lot better, but you're not quite there yet.

- please replace the 'Pkg-Module' in the subject with the actual
package and module that you are modifying.
- line wrap the commit log
- send using plain text

It may look like we're nitpicking here, but having to manually fix up
your patches is prone to errors. Patches on the list should be
presented in a way that allows us to run 'git am' on them (*) and not
tweak the contents for them to apply

(*) Tianocore does actually require some fairly mechanical line ending
changes to patches taken from the list, unfortunately

-- 
Ard.