From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22d.google.com (mail-io0-x22d.google.com [IPv6:2607:f8b0:4001:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1DFE41A1DF3 for ; Mon, 26 Sep 2016 10:04:12 -0700 (PDT) Received: by mail-io0-x22d.google.com with SMTP id e66so99191555iod.1 for ; Mon, 26 Sep 2016 10:04:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=MSpvhjWAXqqHzuprx+TjEVpoZ2v0r0CIb2xgso88Jdc=; b=NdkKBb5KtWvxuhIgl2oPPuLm9fOzb5q/Em5DyIhJh/65i1TCpFslZVQKg823hhXHdg 1Xdcmsg4TOKGpJ0+Y4DEhhL4vPo1HYq7Xm0ewcnVmS3T5eKoQNgufsA3EhN/bfcZOY16 u/39oZdUpKhOI6m79rKCphQf8wJiTkbERFCps= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=MSpvhjWAXqqHzuprx+TjEVpoZ2v0r0CIb2xgso88Jdc=; b=Ax9VCLbpJYcDKbFQbG6BK30kLg+EmhlGIFBVw15gJVRZMXgkeBw56ikpd5/f/CKUYY hJIL3IdHcpvRTqTfvwq5FDbermVUXX5Eo+kitJLuBc1UYSDc3QAE8Gz1u14TmAf8mcOW X9osWwm8HPC+yOgvFH5KRUUIPNCVo7qdvxUuoDvb5nfzOL4KlDue9M9GOo91FXFDxV/P sv23iu6LTbfelIoZ0jESl1cDt0gO04hHRj51MIpk8z7EUXU9uQbqdpErPoa9VB7y4ek8 A2+OiE2iYU/JN07I1XdAvZQ0igOazW7Rfuhq+mtOabuSixeO2DuCAQwcGUNVSupkPk+H pMFQ== X-Gm-Message-State: AE9vXwMJ4MwRkHT3c3oHRZ9x80xzWHQpH0cRAh8QRGmYkOU77v77q+LrRDx77bccYHUsAtm8gtbJhsjgJ+JlV6Z1 X-Received: by 10.107.133.17 with SMTP id h17mr28723689iod.148.1474909451207; Mon, 26 Sep 2016 10:04:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Mon, 26 Sep 2016 10:04:10 -0700 (PDT) In-Reply-To: References: From: Ard Biesheuvel Date: Mon, 26 Sep 2016 10:04:10 -0700 Message-ID: To: Kurt Kennett Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH] Pkg-Module: ArmPkg Fix Mmu Initialization Problem. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 26 Sep 2016 17:04:12 -0000 Content-Type: text/plain; charset=UTF-8 On 26 September 2016 at 08:36, Kurt Kennett wrote: > During Mmu initialization in the CpuDxe, for a page table any bits set in > the 'NextSectionAttributes' are garbage and were set from bits that are > actually part of the pagetable address. We clear it out to zero so that the > SyncCacheConfigPage will use the page attributes instead of trying to > convert the (bogus) section attributes into page attributes > > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > > > Signed-off-by: Kurt Kennett > Hello Kurt, This is looking a lot better, but you're not quite there yet. - please replace the 'Pkg-Module' in the subject with the actual package and module that you are modifying. - line wrap the commit log - send using plain text It may look like we're nitpicking here, but having to manually fix up your patches is prone to errors. Patches on the list should be presented in a way that allows us to run 'git am' on them (*) and not tweak the contents for them to apply (*) Tianocore does actually require some fairly mechanical line ending changes to patches taken from the list, unfortunately -- Ard.