From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Jun Nie <jun.nie@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Evan Lloyd <evan.lloyd@arm.com>,
Alexei Fedorov <Alexei.Fedorov@arm.com>,
Shawn Guo <shawn.guo@linaro.org>,
Jason Liu <jason.liu@linaro.org>
Subject: Re: [PATCH v2] ArmPlatformPkg: Support different PL011 reg offset
Date: Thu, 6 Jul 2017 15:56:36 +0100 [thread overview]
Message-ID: <CAKv+Gu9Qn6+xWp83cKurc7CkWrZxA+yxF7A=Yg+fVYkaFK+wbw@mail.gmail.com> (raw)
In-Reply-To: <CABymUCNcWxg43DO4Yj36U46_djkuwr=dWs8om483Kw=XMMVUxQ@mail.gmail.com>
On 6 July 2017 at 15:54, Jun Nie <jun.nie@linaro.org> wrote:
> 2017-07-06 0:36 GMT+08:00 Leif Lindholm <leif.lindholm@linaro.org>:
>> On Tue, Jul 04, 2017 at 11:43:38PM +0800, Jun Nie wrote:
>>> ZTE/SanChip version pl011 has different reg offset and bit offset
>>> for some registers.
>>>
>>> Contributed-under: TianoCore Contribution Agreement 1.0
>>> Signed-off-by: Jun Nie <jun.nie@linaro.org>
>>> ---
>>> ArmPlatformPkg/ArmPlatformPkg.dec | 1 +
>>> ArmPlatformPkg/Drivers/PL011Uart/PL011Uart.inf | 1 +
>>> ArmPlatformPkg/Include/Drivers/PL011Uart.h | 29 ++++++++++++++++++++++++++
>>> 3 files changed, 31 insertions(+)
>>>
>>> diff --git a/ArmPlatformPkg/ArmPlatformPkg.dec b/ArmPlatformPkg/ArmPlatformPkg.dec
>>> index d756fd2..3dd613c 100644
>>> --- a/ArmPlatformPkg/ArmPlatformPkg.dec
>>> +++ b/ArmPlatformPkg/ArmPlatformPkg.dec
>>> @@ -97,6 +97,7 @@
>>> gArmPlatformTokenSpaceGuid.PL011UartInteger|0|UINT32|0x00000020
>>> gArmPlatformTokenSpaceGuid.PL011UartFractional|0|UINT32|0x0000002D
>>> gArmPlatformTokenSpaceGuid.PL011UartInterrupt|0x00000000|UINT32|0x0000002F
>>> + gArmPlatformTokenSpaceGuid.PL011UartZxRegOffset|0|UINT8|0
>>
>> I'm basically OK with this patch, but if we have multiple variants of
>> this, as the Linux driver suggests, I think we're looking at something
>> more like PL011UartRegOffsetVariant, with a numerical value for each
>> special flavour.
>>
>>>
>>> ## PL011 Serial Debug UART
>>> gArmPlatformTokenSpaceGuid.PcdSerialDbgRegisterBase|0x00000000|UINT64|0x00000030
>>> diff --git a/ArmPlatformPkg/Drivers/PL011Uart/PL011Uart.inf b/ArmPlatformPkg/Drivers/PL011Uart/PL011Uart.inf
>>> index 0154f3b..257fbc7 100644
>>> --- a/ArmPlatformPkg/Drivers/PL011Uart/PL011Uart.inf
>>> +++ b/ArmPlatformPkg/Drivers/PL011Uart/PL011Uart.inf
>>> @@ -39,3 +39,4 @@
>>>
>>> gArmPlatformTokenSpaceGuid.PL011UartInteger
>>> gArmPlatformTokenSpaceGuid.PL011UartFractional
>>> + gArmPlatformTokenSpaceGuid.PL011UartZxRegOffset
>>> diff --git a/ArmPlatformPkg/Include/Drivers/PL011Uart.h b/ArmPlatformPkg/Include/Drivers/PL011Uart.h
>>> index d5e88e8..09d548b 100644
>>> --- a/ArmPlatformPkg/Include/Drivers/PL011Uart.h
>>> +++ b/ArmPlatformPkg/Include/Drivers/PL011Uart.h
>>> @@ -19,6 +19,7 @@
>>> #include <Protocol/SerialIo.h>
>>>
>>> // PL011 Registers
>>> +#if !FixedPcdGet8 (PL011UartZxRegOffset)
>>
>> And as such, more a test like...
>> #if FixedPcdGet8 (PL011UartRegOffsetVariant) == PL011_VARIANT_ZTE
>
> Yes, it is more generic. Which header is proper file to add value
> definition of PL011_VARIANT_ZTE that can be included by platform.dsc?
>
Please look at
gEfiMdePkgTokenSpaceGuid.PcdDefaultTerminalType
for an example. It is fine to have the C level #defines in PL011Uart.h
prev parent reply other threads:[~2017-07-06 14:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-04 15:43 [PATCH v2] ArmPlatformPkg: Support different PL011 reg offset Jun Nie
2017-07-05 16:36 ` Leif Lindholm
2017-07-06 14:54 ` Jun Nie
2017-07-06 14:56 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu9Qn6+xWp83cKurc7CkWrZxA+yxF7A=Yg+fVYkaFK+wbw@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox