Re: [PATCH v2 2/3] ShellPkg/tftp: Convert from NULL class library to Dynamic Command

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 27 November 2017 at 05:55, Ruiyu Ni <ruiyu.ni@intel.com> wrote:
> UEFI Shell spec defines Shell Dynamic Command protocol which is just
> for the purpose to extend internal command.
> So tftp command is changed from NULL class library to be a driver
> producing DynamicCommand protocol.
>
> The guideline is:
> 1. Only use NULL class library for Shell spec defined commands.
> 2. New commands can be provided as not only a standalone application
>    but also a dynamic command. So it can be used either as an
>    internal command, but also as a standalone application.
>
> TftpApp.inf is to provide a standalone application.
> TftpDynamicCommand.inf is to provide a standalone driver producing
> Dynamic Command protocol.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ruiyu Ni <ruiyu.ni@intel.com>
> Cc: Jaben Carsey <jaben.carsey@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  .../TftpDynamicCommand}/Tftp.c                     |  92 +++++++++++----
>  .../TftpDynamicCommand/Tftp.h}                     |  40 +++++--
>  .../TftpDynamicCommand/Tftp.uni}                   |   0
>  .../DynamicCommand/TftpDynamicCommand/TftpApp.c    |  54 +++++++++
>  .../TftpDynamicCommand/TftpApp.inf}                |  34 +++---
>  .../TftpDynamicCommand/TftpDynamicCommand.c        | 131 +++++++++++++++++++++
>  .../TftpDynamicCommand/TftpDynamicCommand.inf}     |  39 +++---
>  .../UefiShellTftpCommandLib.c                      |  97 ---------------
>  ShellPkg/ShellPkg.dsc                              |  11 +-
>  9 files changed, 325 insertions(+), 173 deletions(-)

Please make sure that you fix platforms that use .inf files when renaming them.
The ArmVirtQemu build is currently broken due to this patch.