From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F29792034A78F for ; Mon, 27 Nov 2017 23:30:31 -0800 (PST) Received: by mail-it0-x243.google.com with SMTP id n134so24481798itg.1 for ; Mon, 27 Nov 2017 23:34:54 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6Sk22FPIU0KeK8EDxjprn+tmkZbucwl6/axB0YKCoHM=; b=LqHVeV5xypVA53K5kkOUXnsZjqd9ZDneFCfqk8gjDakNO9iO548qcLIIQkE1bqW77m zkYh8XasxBCgwmA1mDE9LrCPldNbxKp2cUDrrwMN7vxmFM7BRYfjR6gZrtYA3zjVDzd/ /8YNsQzylUQSnfW/x9uxEEZP/8r9ZKchHrcB4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6Sk22FPIU0KeK8EDxjprn+tmkZbucwl6/axB0YKCoHM=; b=QNcPAvT1uoGuIhMHi8HvIUI+FSfnPO2MVrpz8i4IyeoNwy4nCbWNN7T9HTIj9yoRRv D3zOzvJniuKOqtX+yw2eihfS9CVSed+KJsXaIFHKXZrrvrHb4b2tInARS0+2hotR6qL4 yHhndzjepo2ThWfImbf8tt/lxe5d15pomDLd+9qgMzH/JBw5vm6RUXObtq09nDreLcKF cwtSEl6e+IEMIVb2Jyx5yI24XmYcelP4LRLrNgWJS7SlS4WeEFlS4AKNjW1f+dXDq301 2jm4WR9GPwJE7qy15jrAxOTDoAW7fTza4e4d8NGg/KDIiPydBc0r6IMQIEZLtDzBlgoc zvIA== X-Gm-Message-State: AJaThX5G+f69NH/nhPZHiWRjwvB2oZ/vR7qldacm69EFuJEVxxmwLEab 6Op6IOOCjYBZ5RBv0i7AJLrD6Z7fDPDYppKRGhlaxg== X-Google-Smtp-Source: AGs4zMbjqUEXEE4ghdejxW35lTFH7oasAzOLLItjGnfbXHYVVib9OlLKkdJLybHJ/V0paYkfmQHxwrSJfP3NZ5zFyGk= X-Received: by 10.36.31.212 with SMTP id d203mr1226417itd.48.1511854493774; Mon, 27 Nov 2017 23:34:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.16 with HTTP; Mon, 27 Nov 2017 23:34:53 -0800 (PST) In-Reply-To: <20171127055532.320556-3-ruiyu.ni@intel.com> References: <20171127055532.320556-1-ruiyu.ni@intel.com> <20171127055532.320556-3-ruiyu.ni@intel.com> From: Ard Biesheuvel Date: Tue, 28 Nov 2017 07:34:53 +0000 Message-ID: To: Ruiyu Ni Cc: "edk2-devel@lists.01.org" , Jaben Carsey , Michael D Kinney Subject: Re: [PATCH v2 2/3] ShellPkg/tftp: Convert from NULL class library to Dynamic Command X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 28 Nov 2017 07:30:32 -0000 Content-Type: text/plain; charset="UTF-8" On 27 November 2017 at 05:55, Ruiyu Ni wrote: > UEFI Shell spec defines Shell Dynamic Command protocol which is just > for the purpose to extend internal command. > So tftp command is changed from NULL class library to be a driver > producing DynamicCommand protocol. > > The guideline is: > 1. Only use NULL class library for Shell spec defined commands. > 2. New commands can be provided as not only a standalone application > but also a dynamic command. So it can be used either as an > internal command, but also as a standalone application. > > TftpApp.inf is to provide a standalone application. > TftpDynamicCommand.inf is to provide a standalone driver producing > Dynamic Command protocol. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ruiyu Ni > Cc: Jaben Carsey > Cc: Michael D Kinney > --- > .../TftpDynamicCommand}/Tftp.c | 92 +++++++++++---- > .../TftpDynamicCommand/Tftp.h} | 40 +++++-- > .../TftpDynamicCommand/Tftp.uni} | 0 > .../DynamicCommand/TftpDynamicCommand/TftpApp.c | 54 +++++++++ > .../TftpDynamicCommand/TftpApp.inf} | 34 +++--- > .../TftpDynamicCommand/TftpDynamicCommand.c | 131 +++++++++++++++++++++ > .../TftpDynamicCommand/TftpDynamicCommand.inf} | 39 +++--- > .../UefiShellTftpCommandLib.c | 97 --------------- > ShellPkg/ShellPkg.dsc | 11 +- > 9 files changed, 325 insertions(+), 173 deletions(-) Please make sure that you fix platforms that use .inf files when renaming them. The ArmVirtQemu build is currently broken due to this patch.