From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 5673E211AEA42 for ; Thu, 10 Jan 2019 08:23:36 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id a6so17060542itl.4 for ; Thu, 10 Jan 2019 08:23:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=E5WKKidyeksWRp5pd536DrlZu/fLmF0+LgYDtURHE3w=; b=dx/xuKgcD4Jh1YnRJBu/mKEcj2yeXx2D9mU3w3y7z6Xor15xsZdGsRI3ihQ71O1UsN SanPwdXb7BWAOoHJAVG2KKa5Y2WwpVaCz2nCNj7GnpoCjf7s1xy/b5kGXMrVeqRBcLqM 6w32B/m74bTriuRZSudpCHw+o9H4NO6W/kHqs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=E5WKKidyeksWRp5pd536DrlZu/fLmF0+LgYDtURHE3w=; b=WN5FWboO26QuBC7CKWmeinjyVL9t3eEPzWzffvwXavYIdvp/tmrlaVDW3RKkz1+OPT FY44NluzY+2E8BQdEqq7HJHXxeKl+c+ycHiwNiwYfTJvnQSq6gLu3wtdWEnCIhHkxphl A1WR6+qWzOTbKi+yLv7X6QbrZfhbd4g537efXdtEHO5dCnJncdI1heFW+NAP6R7ZmbCm WZY/EQ0kB3+pCl1ySnrqlx9pbh71OXTi0LLEcfD3t1F4GNDwJqyh5S3Xei2duooOnHoW Q3Xe25pRqithgdy/ohMBqu9iZSgx72Lj/Vk0anUSvvS3QwEf8wmNX9KfnUalHY38v3sJ 1sWA== X-Gm-Message-State: AJcUukdX+O1eGcA4+DPfrzrLbQ1KxXTXq0J8xh46t77jQPt2fPAf6AE3 v6KKAXT2FagCEb/6Wt7mUjn8HiZfvggC9PrbdXrOWA== X-Google-Smtp-Source: ALg8bN5aQqKtIrMh722s+nTrdM9kJBiq1fFxvMWTJvwZENKf8v/xpdnWuD2c78EJnHUNtU1haDl/TPAp5E++6sY9hXY= X-Received: by 2002:a24:edc4:: with SMTP id r187mr8373203ith.158.1547137414556; Thu, 10 Jan 2019 08:23:34 -0800 (PST) MIME-Version: 1.0 References: <20190103182825.32231-1-ard.biesheuvel@linaro.org> <20190103182825.32231-6-ard.biesheuvel@linaro.org> <4a353237-1191-a831-1b6e-e981b7c59a7d@intel.com> <539a4ec0-eb09-588b-2a24-4b1f450f587b@intel.com> <91581880-e3ef-31d6-40eb-1d52f5f0cdc1@redhat.com> In-Reply-To: <91581880-e3ef-31d6-40eb-1d52f5f0cdc1@redhat.com> From: Ard Biesheuvel Date: Thu, 10 Jan 2019 17:23:24 +0100 Message-ID: To: Laszlo Ersek Cc: "Zeng, Star" , Hao Wu , Michael D Kinney , "edk2-devel@lists.01.org" , Liming Gao Subject: Re: [PATCH 4/6] MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 10 Jan 2019 16:23:36 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 10 Jan 2019 at 14:03, Laszlo Ersek wrote: > > On 01/10/19 08:59, Zeng, Star wrote: > > On 2019/1/10 15:33, Ard Biesheuvel wrote: > >> On Thu, 10 Jan 2019 at 08:30, Zeng, Star wrote: > >>> > >>> Hi Ard, > >>> > >>> Another minor feedback. > >>> > >>> On 2019/1/10 14:47, Zeng, Star wrote: > >>>> Hi Ard, > >>>> > >>>> Some minor feedback added inline. > >>>> > >>>> On 2019/1/4 2:28, Ard Biesheuvel wrote: > >>>>> Implement a new version of the fault tolerant write driver that can > >>>>> be used in the context of a standalone MM implementation. > >>>>> > >>>>> Contributed-under: TianoCore Contribution Agreement 1.1 > >>>>> Signed-off-by: Ard Biesheuvel > >>>>> --- > >>>>> > >>>>> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c > >>>>> > >>>>> | 70 +++++++++++++++ > >>>>> > >>>>> MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.inf > >>>>> > >>>>> | 90 ++++++++++++++++++++ > >>>>> 2 files changed, 160 insertions(+) > >>> > >>> Please add it into MdeModulePkg.dsc for package build verification. > >>> > >> > >> Hello Star, > >> > >> Thanks for all the feedback. I will respond in more detail later. > >> > >> However, to the point raised here: it is not possible to add these > >> drivers to MdeModulePkg.dsc unless we add a dummy implementation of > >> StandaloneMmDriverEntryPoint to MdeModulePkg. Do you think we should > >> do that? > > > > Oh, good information. > > To have full code building coverage for the package, personally I think > > we can move StandaloneMmDriverEntryPoint library class and instance into > > MdePkg, and even the MmServicesTableLib for MM_STANDALONE, they should > > be generic enough. > > > > I do not want to block this patch set because of this. So let's discuss > > this in parallel as separated topic. > > > > Mike, Liming, Laszlo, Jian and Hao,\ > > What's your opinion? > > It should be possible to build all library instances in a central > Package (well, all Packages really), using the Package's DSC file. To my > understanding, libraries built like this are not expected to be used in > actual (shipped) drivers / applications, nor is their indiscriminate > distribution (as LIBs) expected. For example, shipping a BaseXxxLibNull > library instance in binary form seems quite useless. > > With that in mind, I think a Null instance for the entry point in > question makes sense, under MdeModulePkg. > I will look into this a bit deeper next week. I think it makes sense for the core PI architected pieces to all live in MdePkg rather than StandaloneMmPkg. For instance, MmServicesTableLib for standalone MM should live there, MmEntryPoint should live there (and have traditional and standalone MM implementation) and perhaps some other core pieces as well. This may be a slippery slope, so I will dedicate some time to look into this carefully, at least with the goal to make the FaultTolerantWrite and Variable driver buildable from within MdeModulePkg.