From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::143; helo=mail-it1-x143.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x143.google.com (mail-it1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1A766211ACED1 for ; Wed, 2 Jan 2019 06:23:18 -0800 (PST) Received: by mail-it1-x143.google.com with SMTP id m62so41028621ith.5 for ; Wed, 02 Jan 2019 06:23:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=VHWhmnguhj+d0+AXbiaHOayj2xPY+TDk9oBhki1y+94=; b=LlL+Hg6QjSNSuf6QiPruZMccCTG+B6iY5sNVFAKwg6IePWPkmskrt06Ml/7+JdK9V4 zAfHUSgDZGQ1yPvoYSSe9gcboOxZrjhTVjC/3qNMW+VvB7OIyx6CQ5IkiB3ZCXi5G0XK VKcKtIEkYh8HcgTLwrZ77p+FW+JtuaAR5fCLg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=VHWhmnguhj+d0+AXbiaHOayj2xPY+TDk9oBhki1y+94=; b=LUdklA5sgvyUNH3COT5TVfZ6ivkpgbw9ghwzrZsFIQSRHzt4Md6zcRtBGtKzHm+RNw MSj6BQUPudz71f5L/C4F8HidLmbFq7WvX1RYKbjppPGtV3+7BEOEUSfbpuJBNAO8RBtm pTDXl3nxv6Ta/tvJ/Cjn8MO8TpLAnG1TFjjvJ9uMd55VpCGPF+CVtrUTfHZiVGTfHx51 i/BCK7mRy5DlW2HFk84Qr5RukJbSGt9DatBXt8dpmU68jo6jxcns5c3y+8oqwZkYA7rI jkdD9t/x7SAdpBWmJQpHZcqahRaQYebxQ0q4AVYt21I4z29JoMQQH0TEw7C50GbUN9D8 MAxg== X-Gm-Message-State: AA+aEWb6QIez6Ax8XLIZEYQJHDLUww+EMrFN1JHoNB92FRYK3G32LKXx aBwJQCjyaIyTPxtFyMYbZ2gd2Vm6yvHvuvhktZNZxkYze6g= X-Google-Smtp-Source: AFSGD/Um91yJsphZdv6lvMwdOBODMl0NOEfAJJx52hrYrEh1yjcItSuqJXv6ckadqcfApIBWIT7JMSoXRkNEKGkdfvE= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr29228538itk.71.1546438997696; Wed, 02 Jan 2019 06:23:17 -0800 (PST) MIME-Version: 1.0 References: <1544789607-11316-1-git-send-email-jagadeesh.ujja@arm.com> <1544789607-11316-11-git-send-email-jagadeesh.ujja@arm.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3A021C@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3A021C@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 2 Jan 2019 15:23:05 +0100 Message-ID: To: "Gao, Liming" Cc: Jagadeesh Ujja , "edk2-devel@lists.01.org" , "Zhang, Chao B" Subject: Re: [PATCH 10/13] MdeModulePkg/VarCheckLib: allow MM_STANDALONE drivers to use this library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Jan 2019 14:23:19 -0000 X-List-Received-Date: Wed, 02 Jan 2019 14:23:19 -0000 X-List-Received-Date: Wed, 02 Jan 2019 14:23:19 -0000 X-List-Received-Date: Wed, 02 Jan 2019 14:23:19 -0000 X-List-Received-Date: Wed, 02 Jan 2019 14:23:19 -0000 X-List-Received-Date: Wed, 02 Jan 2019 14:23:19 -0000 X-List-Received-Date: Wed, 02 Jan 2019 14:23:19 -0000 X-List-Received-Date: Wed, 02 Jan 2019 14:23:19 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, 2 Jan 2019 at 14:23, Gao, Liming wrote: > > Ard: > Why need to change module type? The non-base type library can support m= ore than one module types, such as MdeModulePkg\Library\PeiDxeDebugLibRepor= tStatusCode\PeiDxeDebugLibReportStatusCode.inf. Only if this library has co= nstructor and needs to support cross module type, it must be set to BASE. F= or other case, its module type can be kept as-is. I clarify this rule in ht= tps://lists.01.org/pipermail/edk2-devel/2018-December/033523.html. > Currently, standalone MM on AArch64 requires strict alignment, and we only build SEC, PEI_CORE, PEIM and BASE modules with strict alignment. In general, I think it makes sense to default to BASE type for all libraries unless there is a need to using something else, i.e, when the library has a constructor that needs to ImageHandle and/or SystemTable arguments.