Re: [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 25 May 2018 at 08:15, Michael D Kinney <michael.d.kinney@intel.com> wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=801
>
> Based on content from:
>
> https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressGraphicsLib
> https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressTextLib
>
> Updates for V3
> ==============
> * Add Version field to EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL
> * Break up patch series into 4 smaller patch series to handle dependencies
>   between the edk2 repository and the edk2-platforms repository.
>   + Patch series for edk2 repo that adds DisplayUpdateProgressLib class and
>     instances.  Defines the EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL.
>     Adds PerformFlashWriteWithProgress() API to the PlatformFlashAccessLib.
>   + Patch series for platforms in edk2-platforms that use capsules to add the
>     DisplayUpdateProgressLib mapping to the DSC files and add the
>     PerformFlashWriteWithProgress() API implementation to the
>     PlatformFlashAccessLib implementations.
>   + Patch series for platforms in edk2 that use capsules to add the
>     DisplayUpdateProgressLib mapping to the DSC files and add the
>     PerformFlashWriteWithProgress() API implementation to the
>     PlatformFlashAccessLib implementations.
>   + Patch for edk2 that adds the use of the DisplayUpateProgressLib and the
>     PerformFlashWriteWithProgress() API .
>
> Updates for V2
> ==============
> * Change DisplayUpdateProgressGraphicsLib to DisplayUpdateProgressLibGraphics
> * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText
> * Clarify that color in Firmware Management Progress Protocol is the foreground color
> * Add missing parameters to PerformFlashWriteWithProgress() function header.
> * Update PerformFlashWriteWithProgress() function header describing the use of
>   the start and end percentage values.
> * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call Progress() for
>   the end precentage.
> * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call Progress()
>   for the end precentage.
>
> Add DisplayUpdateProgressLib class along implementations for both graphical
> (Graphics Output Protocol based) and text (Simple Text Output Protocol based)
> consoles.  Also add the EDK II Firmware Management Progress Protocol that is an
> optional protocol that provides the progress bar color and a watchdog timeout
> value thaty can be used when a firmware image is updated in a firmware device.
>
> * Add progress support to DxeCapsuleLibFmp
> * Add progress support to SystemFirmwareUpdateDxe
> * Add progress support to PlatformFlashAccessLib class and instances.
> * Reduce Print() calls during a firmware update.
>
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: David Wei <david.wei@intel.com>
> Cc: Mang Guo <mang.guo@intel.com>
> Cc: Kelly Steele <kelly.steele@intel.com>
>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.1
>
> Michael D Kinney (3):
>   MdeModulePkg: Add DisplayUpdateProgressLib class
>   MdeModulePkg: Add DisplayUpdateProgressLib instances
>   SignedCapsulePkg/PlatformFlashAccessLib: Add progress API
>

This message says 0/3, but there appear to be 4 patches in the series???


>  .../Include/Library/DisplayUpdateProgressLib.h     |  65 +++
>  .../Include/Protocol/FirmwareManagementProgress.h  |  55 +++
>  .../DisplayUpdateProgressLibGraphics.c             | 475 +++++++++++++++++++++
>  .../DisplayUpdateProgressLibGraphics.inf           |  60 +++
>  .../DisplayUpdateProgressLibGraphics.uni           |  18 +
>  .../DisplayUpdateProgressLibText.c                 | 174 ++++++++
>  .../DisplayUpdateProgressLibText.inf               |  53 +++
>  .../DisplayUpdateProgressLibText.uni               |  18 +
>  MdeModulePkg/MdeModulePkg.dec                      |  11 +
>  MdeModulePkg/MdeModulePkg.dsc                      |   3 +
>  .../Include/Library/PlatformFlashAccessLib.h       |  49 ++-
>  .../PlatformFlashAccessLibNull.c                   |  70 ++-
>  12 files changed, 1042 insertions(+), 9 deletions(-)
>  create mode 100644 MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h
>  create mode 100644 MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h
>  create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c
>  create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf
>  create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.uni
>  create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c
>  create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.inf
>  create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.uni
>
> --
> 2.14.2.windows.3
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel