From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::236; helo=mail-it0-x236.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x236.google.com (mail-it0-x236.google.com [IPv6:2607:f8b0:4001:c0b::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E4505209603C5 for ; Tue, 29 May 2018 02:51:11 -0700 (PDT) Received: by mail-it0-x236.google.com with SMTP id c5-v6so28571657itj.1 for ; Tue, 29 May 2018 02:51:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=BgnwFTIC9t7rF04vbtJ/cDjsu2O3L2PDl3dXHUL8B8Q=; b=RL8YbrctgxhU6sIfjopz+VKYWp8VNH39vpuMz+RV4m9LJP9LYt5oUu6oO3LYwzTv5u xmLQnVKWtTHQycS9pIaXHtEhz1S0ykeu+OKygjvwJSHnsUsIVFCv45f7gszOjMbDxNm3 q4jRLxQx4QbJvFvlr8rFLkjw90My/riDffiko= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=BgnwFTIC9t7rF04vbtJ/cDjsu2O3L2PDl3dXHUL8B8Q=; b=Q73lBGVAA3IN3A8ED4hUp6izrQ6VNz1tjt2ygDs2wPi1TpZfbFGTZxFqY1kemSgqhc pTDEQ94PyBJCWlbWupNvnDHfzCYLsCl3/Fa57ANAFO90uyRjBZTIo8AEq/xKKkvG+a/G UhIYKmR9MAhzPqCgXiih3NwPmhurlM1nifBG9v7WnStY5SpIPYq1uJvfLG6vRwfT+TnA HsgSvMBTMs6RH78slxu/VHHGP5Sqs9uaOVb+11G9lKIiydagt23mXGf4hVJNKYQjoc00 RvVOdJeExoLwZoZl3aaJ34ws8hvreTu0QS97dKsMUKEb99kAYOREtmdU1ZZue8vWGmFs Kvqw== X-Gm-Message-State: ALKqPwdNGV+oMFBouANSW9o1qkeWf4tbOjS2bsKhEwn38hWRILKM2tdJ qAJK3tBilneUv6Y3CWkE8eNJyyeiSMa/JUJhL4cZ8g== X-Google-Smtp-Source: ADUXVKJ0Hyg6Fmc8u0ahakLaHzDL9o1CvSI25T5OgQO1yyBgy7s8jyWAH2af/dkvrNh4faMfyG6KFWiP3bmhHOWdH20= X-Received: by 2002:a24:e105:: with SMTP id n5-v6mr13706134ith.68.1527587470476; Tue, 29 May 2018 02:51:10 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Tue, 29 May 2018 02:51:10 -0700 (PDT) In-Reply-To: <20180525061552.19840-1-michael.d.kinney@intel.com> References: <20180525061552.19840-1-michael.d.kinney@intel.com> From: Ard Biesheuvel Date: Tue, 29 May 2018 11:51:10 +0200 Message-ID: To: Michael D Kinney Cc: "edk2-devel@lists.01.org" , Eric Dong , Jiewen Yao , Star Zeng , David Wei Subject: Re: [Patch v3 0/3] Add DisplayUpdateProgressLib for capsules X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 May 2018 09:51:12 -0000 Content-Type: text/plain; charset="UTF-8" On 25 May 2018 at 08:15, Michael D Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=801 > > Based on content from: > > https://github.com/Microsoft/MS_UEFI/blob/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Include/Library/DisplayUpdateProgressLib.h > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressGraphicsLib > https://github.com/Microsoft/MS_UEFI/tree/share/MsCapsuleSupport/MsCapsuleUpdatePkg/Library/DisplayUpdateProgressTextLib > > Updates for V3 > ============== > * Add Version field to EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL > * Break up patch series into 4 smaller patch series to handle dependencies > between the edk2 repository and the edk2-platforms repository. > + Patch series for edk2 repo that adds DisplayUpdateProgressLib class and > instances. Defines the EDKII_FIRMWARE_MANAGEMENT_PROGRESS_PROTOCOL. > Adds PerformFlashWriteWithProgress() API to the PlatformFlashAccessLib. > + Patch series for platforms in edk2-platforms that use capsules to add the > DisplayUpdateProgressLib mapping to the DSC files and add the > PerformFlashWriteWithProgress() API implementation to the > PlatformFlashAccessLib implementations. > + Patch series for platforms in edk2 that use capsules to add the > DisplayUpdateProgressLib mapping to the DSC files and add the > PerformFlashWriteWithProgress() API implementation to the > PlatformFlashAccessLib implementations. > + Patch for edk2 that adds the use of the DisplayUpateProgressLib and the > PerformFlashWriteWithProgress() API . > > Updates for V2 > ============== > * Change DisplayUpdateProgressGraphicsLib to DisplayUpdateProgressLibGraphics > * Change DisplayUpdateProgressTextLib to DisplayUpdateProgressLibText > * Clarify that color in Firmware Management Progress Protocol is the foreground color > * Add missing parameters to PerformFlashWriteWithProgress() function header. > * Update PerformFlashWriteWithProgress() function header describing the use of > the start and end percentage values. > * Update QuarkPlatformPkg PerformFlashWriteWithProgress() to call Progress() for > the end precentage. > * Update Vlv2Tbl2DevicePkg PerformFlashWriteWithProgress() to call Progress() > for the end precentage. > > Add DisplayUpdateProgressLib class along implementations for both graphical > (Graphics Output Protocol based) and text (Simple Text Output Protocol based) > consoles. Also add the EDK II Firmware Management Progress Protocol that is an > optional protocol that provides the progress bar color and a watchdog timeout > value thaty can be used when a firmware image is updated in a firmware device. > > * Add progress support to DxeCapsuleLibFmp > * Add progress support to SystemFirmwareUpdateDxe > * Add progress support to PlatformFlashAccessLib class and instances. > * Reduce Print() calls during a firmware update. > > Cc: Sean Brogan > Cc: Star Zeng > Cc: Eric Dong > Cc: Jiewen Yao > Cc: David Wei > Cc: Mang Guo > Cc: Kelly Steele > > Signed-off-by: Michael D Kinney > Contributed-under: TianoCore Contribution Agreement 1.1 > > Michael D Kinney (3): > MdeModulePkg: Add DisplayUpdateProgressLib class > MdeModulePkg: Add DisplayUpdateProgressLib instances > SignedCapsulePkg/PlatformFlashAccessLib: Add progress API > This message says 0/3, but there appear to be 4 patches in the series??? > .../Include/Library/DisplayUpdateProgressLib.h | 65 +++ > .../Include/Protocol/FirmwareManagementProgress.h | 55 +++ > .../DisplayUpdateProgressLibGraphics.c | 475 +++++++++++++++++++++ > .../DisplayUpdateProgressLibGraphics.inf | 60 +++ > .../DisplayUpdateProgressLibGraphics.uni | 18 + > .../DisplayUpdateProgressLibText.c | 174 ++++++++ > .../DisplayUpdateProgressLibText.inf | 53 +++ > .../DisplayUpdateProgressLibText.uni | 18 + > MdeModulePkg/MdeModulePkg.dec | 11 + > MdeModulePkg/MdeModulePkg.dsc | 3 + > .../Include/Library/PlatformFlashAccessLib.h | 49 ++- > .../PlatformFlashAccessLibNull.c | 70 ++- > 12 files changed, 1042 insertions(+), 9 deletions(-) > create mode 100644 MdeModulePkg/Include/Library/DisplayUpdateProgressLib.h > create mode 100644 MdeModulePkg/Include/Protocol/FirmwareManagementProgress.h > create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c > create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.inf > create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.uni > create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.c > create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.inf > create mode 100644 MdeModulePkg/Library/DisplayUpdateProgressLibText/DisplayUpdateProgressLibText.uni > > -- > 2.14.2.windows.3 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel