From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=NCiDynJm;
 spf=pass (domain: linaro.org, ip: 209.85.166.196, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-it1-f196.google.com (mail-it1-f196.google.com [209.85.166.196])
 by groups.io with SMTP; Fri, 17 May 2019 08:25:43 -0700
Received: by mail-it1-f196.google.com with SMTP id m140so12647611itg.2
        for <devel@edk2.groups.io>; Fri, 17 May 2019 08:25:43 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=/Ofrs9QSaxSrZMQk7ajQ4yAai7xDu00RTaNYqfOEwhU=;
        b=NCiDynJmXW4qK95TYlMiYb1lmX5Rme7uXGfbE/A5CDuUWu/cCTKk8h5QXbMxqT/eGY
         /BqsZoiGf5easMxyK0r4fF6h5SR5adWAukmbuO8+2MxWzKSls0vEnUfniOsihZLTWfyp
         fbs6q3y3vjpYL7USd61/TK8LUgfYc7LitiSikzRbrUT8hIfWaFmuxudGKUslY70iXIUE
         WoDH2O+rNJzrNH93f7dPfAoiwFpuu7mCZqDQFJMD3mtQlwYOQGccV2IpheimCjnUVWT+
         tnGZtIp4WSaUHAvkyEy1wmpiRFIoyx3L8ReI4sex7NUT+aJQGy6CmfKsVsv6yn4npWlV
         SNYg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=/Ofrs9QSaxSrZMQk7ajQ4yAai7xDu00RTaNYqfOEwhU=;
        b=X3Rc+4cuOOQXHGjfKJ0syRl1W0v9hXZwN8V7nOG0JVUebMrs6qcZCjPuZtQHXmA9MR
         iWSPE4gWkf7q5LbB223FStpc26LJe2FW8xpTzsDrEdzmPXaFTjXHOmc9WjX5T7q7Ybb9
         hTt9q+Tlw+ctNcYGt+LMXrvgh4NmEJOtTiLuihpdr2tN6N1N2bYgrEentfOBOAZRAaMH
         P2I2TIdMY0zv0hOwG+pM2GYBJLfATFc6DbFf63XaxUEBQsEqApNG/yvdqfA/TGQNLlJY
         jsFYDIOcfK6L53vDpgHc82mAF2+99YWTsXmcEQIIWmQ245tzzuB8JdGXgle47ZLai76c
         qsaA==
X-Gm-Message-State: APjAAAUgptghvvH4xji/Jp3FsriJTTmvPhBBaajjzKugv4YLBmpuWo9w
	JpmxAJLJFcgLSWeATvKpQr9dzTYiUqTN+mY3qHMvF03VWJVqAQ==
X-Google-Smtp-Source: APXvYqxc8u1eIpP6BZ0hwpMFT+pkOyAT2h7da9zTXmP7aUppyXXpT0wuEIs/j7LdMZHa5BrEsnnZv4nNvo63WkI1FyM=
X-Received: by 2002:a24:d00e:: with SMTP id m14mr17078897itg.153.1558106743045;
 Fri, 17 May 2019 08:25:43 -0700 (PDT)
MIME-Version: 1.0
References: <20190514020831.7728-1-hao.a.wu@intel.com> <20190514020831.7728-4-hao.a.wu@intel.com>
 <20190514151331.x23zejy35rkmkjzk@bivouac.eciton.net>
In-Reply-To: <20190514151331.x23zejy35rkmkjzk@bivouac.eciton.net>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 17 May 2019 17:25:31 +0200
Message-ID: <CAKv+Gu9SgrxTsEk8__xw_8Q2ybx8QmEd-xrw6vhCCdWijKWqFg@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH 2/2] Platform/BeagleBoard: Drop the consume of PcdShellFile
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, "Wu, Hao A" <hao.a.wu@intel.com>, 
	Michael D Kinney <michael.d.kinney@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 14 May 2019 at 17:13, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Tue, May 14, 2019 at 10:08:16AM +0800, Wu, Hao A wrote:
> > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1800
> >
> > There is no module in the platform that will use
> > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile. This commit will
> > drop the consume of this PCD.
> >
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Signed-off-by: Hao A Wu <hao.a.wu@intel.com>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

>
> > ---
> >  Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc | 3 ---
> >  1 file changed, 3 deletions(-)
> >
> > diff --git a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > index 8e8bb833ea..043204ce4f 100644
> > --- a/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > +++ b/Platform/BeagleBoard/BeagleBoardPkg/BeagleBoardPkg.dsc
> > @@ -334,9 +334,6 @@
> >
> >    gEfiMdePkgTokenSpaceGuid.PcdPlatformBootTimeOut|10
> >
> > -  # GUID of the UEFI Shell
> > -  gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdShellFile|{ 0x83, 0xA5, 0x04, 0x7C, 0x3E, 0x9E, 0x1C, 0x4F, 0xAD, 0x65, 0xE0, 0x52, 0x68, 0xD0, 0xB4, 0xD1 }
> > -
> >    # GUID of the UI app
> >    gEfiMdeModulePkgTokenSpaceGuid.PcdBootManagerMenuFile|{ 0x21, 0xaa, 0x2c, 0x46, 0x14, 0x76, 0x03, 0x45, 0x83, 0x6e, 0x8a, 0xb6, 0xf4, 0x66, 0x23, 0x31 }
> >
> > --
> > 2.12.0.windows.1
> >
> >
> > 
> >