From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=I3Wtssjb; spf=pass (domain: linaro.org, ip: 209.85.166.194, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f194.google.com (mail-it1-f194.google.com [209.85.166.194]) by groups.io with SMTP; Thu, 25 Apr 2019 04:04:36 -0700 Received: by mail-it1-f194.google.com with SMTP id z17so1783209itc.1 for ; Thu, 25 Apr 2019 04:04:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5dUgAoBsRhWgOVKLPjcwNx/vB2q6NbQU/BPWJhEPwoY=; b=I3WtssjbE2FkvKxCzbTC2gUtsUdN+v0AauVxOkcHedxQ1H/jAqE6FkbHzVo524hWeX 0kjC3g4qfYHnbVCZC3K9AYb+KuqjlcI1EUepn66bcFS4EkbZsjizEhSE4ELV2bUd6jGq ujXvODo118RozWJ1nq+L/TXQfdg5eAE7m5Xm86Q88kH/TgcWrKIaCoDqwbOSkFcShiW2 qoi0KIwUxXPjkHgZvCxn1qiugQY9b0rRTD3hqIaW8oAWlhZuHsMo+aLKi7756woUX+cl V1yv2o6UL1F1woIiYYsJilWOJQk/z+XlS/ApNf6CD02d+f8RAB9BosCfA9LdYu0nG8/P GKxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5dUgAoBsRhWgOVKLPjcwNx/vB2q6NbQU/BPWJhEPwoY=; b=h/EjQ/eor13/8zrfkcj3lGHPPFOyZ+aAapgitSs6V2bgmdrykyV1J80mXK4ENsXhPp 0ZFdhAWRASBR0Ix+7DBynjJ6kysfitfdc8nsrAlBRmAe256cIHlCrf/UGhdnESu1Pmw+ lz5qeWtn8b1vpfkVH/apmw3PPORY64J1Slhdr4+qknTsExmSGWLOlepM9+puUp7XhFYX mWSCXWiz2KV6aHMCkDotY4cH2iUIhIYlDuNrEzvDSVxmcDVC/SFw+2bCV45jUFS1zcZ5 TU0zSvouHgNpB+nSZVqPCBs99dJG61FY1ZMx94YHn/2E9dDwcGOPXv2wxXctSmr6Z7Uy FFQw== X-Gm-Message-State: APjAAAXG72bwPiUfRjrZZrG7fXnP/VvAy9FjPlNgt2zfx890mvEo9+8H vUC1vtVqmS6M2ZFW8OfcFp76Fw6drsv0maz9TLr2Xw== X-Google-Smtp-Source: APXvYqx7/ht48HQCHr30K+CbTlsKtGNPmQjn31rFVfeXmg+fLogy/9PB7671/px7rBeN5UngtquWWnYOihzkKJjU6PI= X-Received: by 2002:a24:59c1:: with SMTP id p184mr3531875itb.158.1556190275933; Thu, 25 Apr 2019 04:04:35 -0700 (PDT) MIME-Version: 1.0 References: <1556183880-5889-1-git-send-email-mw@semihalf.com> In-Reply-To: <1556183880-5889-1-git-send-email-mw@semihalf.com> From: "Ard Biesheuvel" Date: Thu, 25 Apr 2019 13:04:24 +0200 Message-ID: Subject: Re: [PATCH] EmbeddedPkg: Allow DXE_DRIVER to depend on NvVarStoreFormattedLib To: Marcin Wojtas Cc: edk2-devel-groups-io , Leif Lindholm , =?UTF-8?B?SmFuIETEhWJyb8Wb?= , Grzegorz Jaszczyk , Kostya Porotchkin , Jici Gao , "Tian, Feng" , "Kinney, Michael D" , "Gao, Liming" , Laszlo Ersek Content-Type: text/plain; charset="UTF-8" On Thu, 25 Apr 2019 at 11:18, Marcin Wojtas wrote: > > Some modules (such as FaultTolerantWriteDxe) use the FlashNvStorage > PCDs (PcdFlashNvStorageFtw*). In case the flash contents are not > mapped in memory, the module loading order of the FVB driver > may become important. > > To handle above, this patch allows to hook the dependency of > desired DXE_DRIVER type module in the .DSC file via > NvVarStoreFormattedLib NULL resolution. > > Contributed-under: TianoCore Contribution Agreement 1.1 This line is no longer required, so you can drop it in the future. Note that the licensing terms have changed accordingly: by contributing patches under the new license terms, you are basically granting the same IP rights you were granting before by adhering to the TianoCore Contribution Agreement, so nothing has really changed. However, it is your *own* responsibility to confirm that I am not misrepresenting anything here, so please check the repository for the license changes. > Signed-off-by: Marcin Wojtas Reviewed-by: Ard Biesheuvel Pushed as b9d4847ec258..20029ca22baa Thanks, > --- > EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > index fefc311..98a0049 100644 > --- a/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > +++ b/EmbeddedPkg/Library/NvVarStoreFormattedLib/NvVarStoreFormattedLib.inf > @@ -39,8 +39,8 @@ > # > # The matching DEPEX section below will generate the EFI_SECTION_PEI_DEPEX, > # EFI_SECTION_DXE_DEPEX or EFI_SECTION_MM_DEPEX leaf section for the PEIM > -# (EFI_FV_FILETYPE_PEIM), DXE_RUNTIME_DRIVER (EFI_FV_FILETYPE_DRIVER), or > +# (EFI_FV_FILETYPE_PEIM), DXE_RUNTIME_DRIVER/DXE_DRIVER (EFI_FV_FILETYPE_DRIVER), or > # DXE_SMM_DRIVER (EFI_FV_FILETYPE_MM) module, respectively. > # > -[Depex.common.PEIM, Depex.common.DXE_RUNTIME_DRIVER, Depex.common.DXE_SMM_DRIVER] > +[Depex.common.PEIM, Depex.common.DXE_RUNTIME_DRIVER, Depex.common.DXE_DRIVER, Depex.common.DXE_SMM_DRIVER] > gEdkiiNvVarStoreFormattedGuid > -- > 2.7.4 >