From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A8B7C21A134B9 for ; Fri, 19 May 2017 05:49:15 -0700 (PDT) Received: by mail-it0-x229.google.com with SMTP id g126so45737910ith.0 for ; Fri, 19 May 2017 05:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=/UmvOCaTVcDmUOg9X2lyb4hlwAfZ+EA5i+aKMP0Ow6o=; b=ZgPEIdH5cxhVvfCEv9gWTuhGnfrr+jDe6vEv9KYY/QFeFcy1RopP+wCzU/wFcYsVAX MUaL7rWF7AbE61eyTagjZy/rlRvg3UwZOO6pGCgSOLVtErvjcnE6q4GQMvtVt7dRXzTT q/Y05OlPNvK2Q4UgM8qQDi8FNo5GqcHMJ32OQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=/UmvOCaTVcDmUOg9X2lyb4hlwAfZ+EA5i+aKMP0Ow6o=; b=QQcwSa3SW3eHr2d/4eT/bF9+zqGCbQq0lDqFIhGRrPSMEpENsIyKOX9oC+UMdZdkxk WNc98YuBuFSHIXmuHj88DPZXEBKLP/qK4kCmXBwnOqa+MIq1Y01RPhMOvdCd3pX0XBii 8/uhrm1ss+cFqBDGbpY4q/Vr1i2wWV08F7XHKVCxfwlfXenNgDNrgQPlFdKYmVN7XNsr QxzxHy57ClE+IhZsZ/p5XutwqR4w3cesder8ztERY8eIWjeBU8BXUegLwgbZp47fYFW+ htrU0aHbUxN1rB3sbS/AiylKWpLN0Ntr7+nxRXQKAboxZkNKEj1C5imA5Kfn15ygyQHC Z2Ug== X-Gm-Message-State: AODbwcCNHS6jbNfwU7DnNUnWuiYRbtxxhvpNhcRuSZC4H7h0SNkBDe/F y8O68PWMXyhKHLheHyWFnN7/lruf9nd2 X-Received: by 10.36.61.211 with SMTP id n202mr7677541itn.98.1495198154948; Fri, 19 May 2017 05:49:14 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.164.24 with HTTP; Fri, 19 May 2017 05:49:14 -0700 (PDT) In-Reply-To: <1495176736-28376-2-git-send-email-michael.d.kinney@intel.com> References: <1495176736-28376-1-git-send-email-michael.d.kinney@intel.com> <1495176736-28376-2-git-send-email-michael.d.kinney@intel.com> From: Ard Biesheuvel Date: Fri, 19 May 2017 13:49:14 +0100 Message-ID: To: Michael Kinney Cc: "edk2-devel@lists.01.org" , Andrew Fish , Liming Gao Subject: Re: [Patch 1/2] BaseTools: Add -D NO_MSABI_VARGS to X64 XCODE5 CC_FLAGS X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 May 2017 12:49:15 -0000 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On 19 May 2017 at 07:52, Michael Kinney wrote: > https://bugzilla.tianocore.org/show_bug.cgi?id=3D561 > > Update BaseTools/Conf/tools_def.template to add the define > > -D NO_MSABI_VAARGS > > To CC_FLAGS for X64 XCODE5 builds. > > The llvm/clang compiler used in XCODE5 builds supports the > _ms_ versions of the vararg builtins, but the compiler > generates build errors. > > The recommendation from the XCODE5 experts is to never use > the _ms_ version of the vararg builtins. The define > NO_MSABI_VARARGS is already supported in MdePkg/Include/Base.h > and forces the use the standard vararg builtins. > Are such builds compliant with the UEFI spec? > Cc: Andrew Fish > Cc: Liming Gao > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael D Kinney > --- > BaseTools/Conf/tools_def.template | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def= .template > index 427ef1b..ed9e834 100755 > --- a/BaseTools/Conf/tools_def.template > +++ b/BaseTools/Conf/tools_def.template > @@ -7494,9 +7494,9 @@ RELEASE_XCODE5_X64_ASM_FLAGS =3D -arch x86_64 > *_XCODE5_*_VFRPP_FLAGS =3D -x c -E -P -DVFRCOMPILE -include $(DEST_= DIR_DEBUG)/$(MODULE_NAME)StrDefs.h > > > - DEBUG_XCODE5_X64_CC_FLAGS =3D -target x86_64-pc-win32-macho -c -g -O= s -Wall -Werror -Wextra -include AutoGen.h -funsigned-char -fno-ms-ex= tensions -fno-stack-protector -fno-builtin -fshort-wchar -mno-implicit-floa= t -mms-bitfields -Wno-unused-parameter -Wno-missing-braces -Wno-missing-fie= ld-initializers -Wno-tautological-compare -Wno-sign-compare -ftrap-function= =3Dundefined_behavior_has_been_optimized_away_by_clang $(PLATFORM_FLAGS) > - NOOPT_XCODE5_X64_CC_FLAGS =3D -target x86_64-pc-win32-macho -c -g -O= 0 -Wall -Werror -Wextra -include AutoGen.h -funsigned-char -fno-ms-ex= tensions -fno-stack-protector -fno-builtin -fshort-wchar -mno-implicit-floa= t -mms-bitfields -Wno-unused-parameter -Wno-missing-braces -Wno-missing-fie= ld-initializers -Wno-tautological-compare -Wno-sign-compare -ftrap-function= =3Dundefined_behavior_has_been_optimized_away_by_clang $(PLATFORM_FLAGS) > -RELEASE_XCODE5_X64_CC_FLAGS =3D -target x86_64-pc-win32-macho -c -O= s -Wall -Werror -Wextra -include AutoGen.h -funsigned-char -fno-ms-ex= tensions -fno-stack-protector -fno-builtin -fshort-wchar -mno-implicit-floa= t -mms-bitfields -Wno-unused-parameter -Wno-missing-braces -Wno-missing-fie= ld-initializers -Wno-tautological-compare -Wno-sign-compare -ftrap-function= =3Dundefined_behavior_has_been_optimized_away_by_clang $(PLATFORM_FLAGS) > + DEBUG_XCODE5_X64_CC_FLAGS =3D -target x86_64-pc-win32-macho -c -g -O= s -Wall -Werror -Wextra -include AutoGen.h -funsigned-char -fno-ms-ex= tensions -fno-stack-protector -fno-builtin -fshort-wchar -mno-implicit-floa= t -mms-bitfields -Wno-unused-parameter -Wno-missing-braces -Wno-missing-fie= ld-initializers -Wno-tautological-compare -Wno-sign-compare -ftrap-function= =3Dundefined_behavior_has_been_optimized_away_by_clang -D NO_MSABI_VA_FUNCS= $(PLATFORM_FLAGS) > + NOOPT_XCODE5_X64_CC_FLAGS =3D -target x86_64-pc-win32-macho -c -g -O= 0 -Wall -Werror -Wextra -include AutoGen.h -funsigned-char -fno-ms-ex= tensions -fno-stack-protector -fno-builtin -fshort-wchar -mno-implicit-floa= t -mms-bitfields -Wno-unused-parameter -Wno-missing-braces -Wno-missing-fie= ld-initializers -Wno-tautological-compare -Wno-sign-compare -ftrap-function= =3Dundefined_behavior_has_been_optimized_away_by_clang -D NO_MSABI_VA_FUNCS= $(PLATFORM_FLAGS) > +RELEASE_XCODE5_X64_CC_FLAGS =3D -target x86_64-pc-win32-macho -c -O= s -Wall -Werror -Wextra -include AutoGen.h -funsigned-char -fno-ms-ex= tensions -fno-stack-protector -fno-builtin -fshort-wchar -mno-implicit-floa= t -mms-bitfields -Wno-unused-parameter -Wno-missing-braces -Wno-missing-fie= ld-initializers -Wno-tautological-compare -Wno-sign-compare -ftrap-function= =3Dundefined_behavior_has_been_optimized_away_by_clang -D NO_MSABI_VA_FUNCS= $(PLATFORM_FLAGS) > > *_XCODE5_*_ASLCC_FLAGS =3D -x c -save-temps -g -O0 -fshort-wchar -f= no-strict-aliasing -Wall -Werror -Wno-missing-braces -c -include AutoGen.h > *_XCODE5_*_ASLDLINK_FLAGS =3D -e _ReferenceAcpiTable -preload -segalig= n 0x20 -pie -seg1addr 0x240 -read_only_relocs suppress -map $(DEST_DIR_DEB= UG)/$(BASE_NAME).map > -- > 2.6.3.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel