From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id CDF031A20AE for ; Fri, 23 Sep 2016 00:57:39 -0700 (PDT) Received: by mail-io0-x229.google.com with SMTP id m79so110934082ioo.3 for ; Fri, 23 Sep 2016 00:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G+BLVphRBEsvryf9GI5r7JGv85rDSHlCTmftcsYYIAA=; b=G6VQG0IjThrdm/d9sfzNssA/TsvQT2J8n12wwOeAHm57lSDp3PduMXnqOyVUpVMXkP Ng82m7jLdVqsXcCTyQy+DWYTJh0ZZq1UflTpUN3vKn16Y52ocrpILFNlsRgYzb9eddHf FbPxRvzwgts5Jl0E/047zrvJgTh77RJjfl1uw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G+BLVphRBEsvryf9GI5r7JGv85rDSHlCTmftcsYYIAA=; b=HDh01DpAfciywxgPA8FOHeiefh3vvJiM1enoq7D4IKw41OiSmNWHXwKnNfNgyXvgr2 P8CXfigHZ+C5foenCz/wyJu+4sQKqtLXXdsnUp7IyD6BWx5WhXCIEKlq5Et+xc4LXUES DE8uVXu+AUsLYHJUrlVl0UwahK+9PVpaHWPz892BUk5rIrQZrRQ8azE5pnmbfQ/fa/Mi MhOLPaoyraJQYG2PTGyuilhKCaVO6bihlySt/Xh9Me/bSOM/QXU1xVyD3EPUTISH8Igb SiV4U2aCPREcQk+4XUhvjyYTexBzMtYPW5MhuknOGpMeBI+j7lK+/pvJREwjF0Z84+d0 frWw== X-Gm-Message-State: AA6/9RmEAKLy7iMNzvyZ/cbvRq705A0o37GTgu6Zl8YSaCStOSBEDRVAi2Uj9+2ZSolPCVYNWlvWYt0qQH53nrD4 X-Received: by 10.107.35.209 with SMTP id j200mr7443457ioj.26.1474617459079; Fri, 23 Sep 2016 00:57:39 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Fri, 23 Sep 2016 00:57:38 -0700 (PDT) In-Reply-To: <1474583581-41663-2-git-send-email-daniil.egranov@arm.com> References: <1474583581-41663-1-git-send-email-daniil.egranov@arm.com> <1474583581-41663-2-git-send-email-daniil.egranov@arm.com> From: Ard Biesheuvel Date: Fri, 23 Sep 2016 08:57:38 +0100 Message-ID: To: Daniil Egranov Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH 1/2] ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe: Remove calls to ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 23 Sep 2016 07:57:40 -0000 Content-Type: text/plain; charset=UTF-8 Hi Daniil, On 22 September 2016 at 23:33, Daniil Egranov wrote: > The PCI on Juno is DMA coherent, which means it should not be > using ArmDmaLib for PCI DMA. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Daniil Egranov > --- > ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf > index de28c80..597154c 100644 > --- a/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf > +++ b/ArmPlatformPkg/ArmJunoPkg/Drivers/PciHostBridgeDxe/PciHostBridgeDxe.inf > @@ -36,7 +36,7 @@ > MemoryAllocationLib > DxeServicesTableLib > CacheMaintenanceLib > - DmaLib > + NullDmaLib > This is wrong. The module .inf lists library *classes* and the platform .dsc decides how each class maps onto an implementation (aka library resolution) IOW, the other patch you sent that updates ARM Juno's .dsc is sufficient.