From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif@nuviainc.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>
Subject: Re: [PATCH 1/1] ArmPlatformPkg/LcdGraphicsOutputDxe: add missing protocol dependency
Date: Wed, 4 Mar 2020 18:46:05 +0100 [thread overview]
Message-ID: <CAKv+Gu9TzwxaOPqHm4q+-N3hzVhDH97OMB_fZcMftCZeNvY6KQ@mail.gmail.com> (raw)
In-Reply-To: <20200304121117.GT23627@bivouac.eciton.net>
On Wed, 4 Mar 2020 at 13:11, Leif Lindholm <leif@nuviainc.com> wrote:
>
> On Wed, Mar 04, 2020 at 12:58:41 +0100, Ard Biesheuvel wrote:
> > This driver depends on the gEfiCpuArchProtocolGuid protocol but does
> > not declare it, and so this dependency gets satisfies transitively
> > via ArmLib. However, ArmLib will drop this dependency as it does not
> > actually use it, so declare it for LcdGraphicsOutputDxe instead.
> >
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif@nuviainc.com>
>
Pushed as ed1c70cf1a954e857eb122892f3e510966dc4a9f
Thanks
> > ---
> > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
> > index 2176e5a5789f..27453b265611 100644
> > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
> > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf
> > @@ -38,6 +38,7 @@ [LibraryClasses]
> > UefiLib
> >
> > [Protocols]
> > + gEfiCpuArchProtocolGuid
> > gEfiDevicePathProtocolGuid
> > gEfiGraphicsOutputProtocolGuid
> >
> > --
> > 2.17.1
> >
prev parent reply other threads:[~2020-03-04 17:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 11:58 [PATCH 1/1] ArmPlatformPkg/LcdGraphicsOutputDxe: add missing protocol dependency Ard Biesheuvel
2020-03-04 12:11 ` Leif Lindholm
2020-03-04 17:46 ` Ard Biesheuvel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu9TzwxaOPqHm4q+-N3hzVhDH97OMB_fZcMftCZeNvY6KQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox