From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by mx.groups.io with SMTP id smtpd.web12.15293.1583343977316464414 for ; Wed, 04 Mar 2020 09:46:17 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=mlBCwSZE; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wr1-f66.google.com with SMTP id v11so1550629wrm.9 for ; Wed, 04 Mar 2020 09:46:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rzdzkyQCwpX4kgnqmJHZ75mVNLwQMEtWRD4G5jKucpA=; b=mlBCwSZE/Mh3HnhZ2HOMm8OqjILRBmdV2J5UpUARW3Lk4EgXSe3IkutqKYvDrBF5/0 B7U7hdNiBiwIBuh6d8RlQTbgWX4FC09MaQnJrnCo4g8pZzCosrXfJSrsgwiPodNlzT7g e0oiGKm7L9PrmyYXI/ZVVZ1QrxLaIncZh9UdbnfhxFWgZrrNyL3i6U9adEUir0XIFoJ9 cwwiOUC2DyytkfADm2dPApuqeK3nxp/VxWvc8tL5lC+bvKd3KA0bEdJGD3Phdv1FAQ5l Mk2qkfSvLiK1gsE+PUBU5M/xacvoUeP0ZWGWkR544utLMIxGRWwNabCTndu9yHvxISJM qghg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rzdzkyQCwpX4kgnqmJHZ75mVNLwQMEtWRD4G5jKucpA=; b=SywiLjVtUa9sAjWwp6wCE8myMufmEAKLu9fXzYr2WBksovxIt82cX1A8ofuw5X/o4v n54zgIwnI6wOwpJlVy3HpbNRWW5yfL877RHGDM6EqypZEgjyrxhe1Yt7ApIzXMdvQVOL MsOeZWt1VeRX211m+pEpZxQBg6kAPJXZ8Jby/H49t+CYgzirGJK5oJ1CYnDYNyw+YYuD wgCwbXscM1wdiZ1BoQ2qatvv3ULwJuEbUGKRKnhtK8x4eZaYj5ESJkR8RFx+M2gasUwY 1qxxg0bmrDH4sTfDsr/CBlnRcHsa/AoBeZ48uNaQWl5hDhPiCWGbmXozqETd7vPyHIw2 cqBA== X-Gm-Message-State: ANhLgQ1XrOYg6W9vnsnc0WH92iXJ0WGfbRgwmZLGSkHRaIsf9hK00PDc PN3+hkTtO3Emr8BcLHJekdbss48xbOnh92CcpfpuB+vWKjvQAw== X-Google-Smtp-Source: ADFU+vtFSlECYhxNumZvoT9G5yASX3YVft3WVw80XZeU480AT/M3E9tCxN3p03QShgimHopeOlzieK4F5a42T/d94RQ= X-Received: by 2002:adf:f84a:: with SMTP id d10mr5282404wrq.208.1583343975865; Wed, 04 Mar 2020 09:46:15 -0800 (PST) MIME-Version: 1.0 References: <20200304115841.18243-1-ard.biesheuvel@linaro.org> <20200304121117.GT23627@bivouac.eciton.net> In-Reply-To: <20200304121117.GT23627@bivouac.eciton.net> From: "Ard Biesheuvel" Date: Wed, 4 Mar 2020 18:46:05 +0100 Message-ID: Subject: Re: [PATCH 1/1] ArmPlatformPkg/LcdGraphicsOutputDxe: add missing protocol dependency To: Leif Lindholm Cc: edk2-devel-groups-io Content-Type: text/plain; charset="UTF-8" On Wed, 4 Mar 2020 at 13:11, Leif Lindholm wrote: > > On Wed, Mar 04, 2020 at 12:58:41 +0100, Ard Biesheuvel wrote: > > This driver depends on the gEfiCpuArchProtocolGuid protocol but does > > not declare it, and so this dependency gets satisfies transitively > > via ArmLib. However, ArmLib will drop this dependency as it does not > > actually use it, so declare it for LcdGraphicsOutputDxe instead. > > > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Pushed as ed1c70cf1a954e857eb122892f3e510966dc4a9f Thanks > > --- > > ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > > index 2176e5a5789f..27453b265611 100644 > > --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > > +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputDxe.inf > > @@ -38,6 +38,7 @@ [LibraryClasses] > > UefiLib > > > > [Protocols] > > + gEfiCpuArchProtocolGuid > > gEfiDevicePathProtocolGuid > > gEfiGraphicsOutputProtocolGuid > > > > -- > > 2.17.1 > >